-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double Shared maxage for Strong caching options for Ruleset: File and image resources #1989
Comments
…ources. They wrongly were the same as for shared max age. Fixes plone/Products.CMFPlone#1989.
…ources. (#35) They wrongly were the same as for shared max age. Fixes plone/Products.CMFPlone#1989.
…ources. (#35) They wrongly were the same as for shared max age. Fixes plone/Products.CMFPlone#1989. Backported from master.
Branch: refs/heads/1.1.x Date: 2017-04-05T15:28:49+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.caching@2218a80 Fixed title and description of max age in strong caching rule for resources. (#35) They wrongly were the same as for shared max age. Fixes plone/Products.CMFPlone#1989. Backported from master. Files changed: M CHANGES.rst M plone/app/caching/profiles/with-caching-proxy/registry.xml
This had the title and description from shared maxage, due to a wrong reference. See plone/Products.CMFPlone#1989 This is run when upgrading to Plone 5.0.8 and 5.1b4.
Branch: refs/heads/master Date: 2017-04-05T17:07:12+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.upgrade@b97989b Fixed title and description of plone.resource.maxage. This had the title and description from shared maxage, due to a wrong reference. See plone/Products.CMFPlone#1989 This is run when upgrading to Plone 5.0.8 and 5.1b4. Files changed: M CHANGES.rst M plone/app/upgrade/v50/configure.zcml M plone/app/upgrade/v50/final.py M plone/app/upgrade/v50/tests.py M plone/app/upgrade/v51/configure.zcml Repository: plone.app.upgrade Branch: refs/heads/master Date: 2017-04-05T23:26:46+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.upgrade@a4a277b Merge pull request #108 from plone/fix-caching-s-maxage-master Fixed title and description of plone.resource.maxage. Files changed: M CHANGES.rst M plone/app/upgrade/v50/configure.zcml M plone/app/upgrade/v50/final.py M plone/app/upgrade/v50/tests.py M plone/app/upgrade/v51/configure.zcml
Branch: refs/heads/master Date: 2017-04-05T17:07:12+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.upgrade@b97989b Fixed title and description of plone.resource.maxage. This had the title and description from shared maxage, due to a wrong reference. See plone/Products.CMFPlone#1989 This is run when upgrading to Plone 5.0.8 and 5.1b4. Files changed: M CHANGES.rst M plone/app/upgrade/v50/configure.zcml M plone/app/upgrade/v50/final.py M plone/app/upgrade/v50/tests.py M plone/app/upgrade/v51/configure.zcml Repository: plone.app.upgrade Branch: refs/heads/master Date: 2017-04-05T23:26:46+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.upgrade@a4a277b Merge pull request #108 from plone/fix-caching-s-maxage-master Fixed title and description of plone.resource.maxage. Files changed: M CHANGES.rst M plone/app/upgrade/v50/configure.zcml M plone/app/upgrade/v50/final.py M plone/app/upgrade/v50/tests.py M plone/app/upgrade/v51/configure.zcml
This had the title and description from shared maxage, due to a wrong reference. See plone/Products.CMFPlone#1989 Backported from master.
Branch: refs/heads/1.x Date: 2017-04-06T18:45:51+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.upgrade@b2c015f Fixed title and description of plone.resource.maxage. This had the title and description from shared maxage, due to a wrong reference. See plone/Products.CMFPlone#1989 Backported from master. Files changed: M CHANGES.rst M plone/app/upgrade/v43/configure.zcml M plone/app/upgrade/v43/final.py M plone/app/upgrade/v43/tests.py Repository: plone.app.upgrade Branch: refs/heads/1.x Date: 2017-04-07T21:04:02+02:00 Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com> Commit: plone/plone.app.upgrade@b3fa5f0 Merge pull request #110 from plone/fix-caching-s-maxage-43 Fixed title and description of plone.resource.maxage. [4.3] Files changed: M CHANGES.rst M plone/app/upgrade/v43/configure.zcml M plone/app/upgrade/v43/final.py M plone/app/upgrade/v43/tests.py
In the changelog of Plone 4.3.15 says, that this ticket has been fixed. But apparently it's not the case when looking at the status of this ticket. Any reasons why it is that? |
Forgot to close it I guess. |
What I did:
What I expect to happen:
What actually happened:
What version of Plone/ Addons I am using:
This is in Plone 4.3, 5.0, 5.1 with
plone.app.caching
.Analysis
In the configuration registry, the
plone.app.caching.strongCaching.plone.resource.maxage
has the wrong title and description:The error is in these lines in the
with-caching-proxy
profile. This has been in there since six years, version 1.0b2.The code works fine, it just shows a wrong title and description, which is confusing.
Solution
plone.app.caching.strongCaching.plone.resource.maxage
is not always there, so we cannot just add aregistry.xml
inplone.app.upgrade
. But should be doable.I will have a go at this.
cc @jladage
The text was updated successfully, but these errors were encountered: