Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing per ruleset cache options shows empty fields on 5.0 and 5.1 #1993

Closed
mauritsvanrees opened this issue Apr 5, 2017 · 1 comment
Closed

Comments

@mauritsvanrees
Copy link
Member

mauritsvanrees commented Apr 5, 2017

  • Install plone.app.caching
  • Apply the 'with caching proxy' settings.
  • Go to the 'Detailed settings' tab.
  • Click 'View/edit/clear per-ruleset parameters' for one of the rulesets.
  • The form shows empty fields.
  • If you fill something in and save it, the data is set correctly when looking at the configuration registry, but the form still shows empty fields.
  • Editing the global parameters works fine.

This is on coredev 5.0 and 5.1. On 4.3 it works fine.
So we are not getting the values correctly. Restarting the instance does not help, so it does not seem a memoize problem.

@mauritsvanrees
Copy link
Member Author

I tried previous versions of plone.app.caching. It still worked fine in 1.2.13 but not anymore in 1.2.14. It went wrong in this code style change in edit.py. It seems completely innocent.

Ah, I see it. Some dots were accidentally removed in that commit.

I will make a pull request.

mauritsvanrees added a commit to plone/plone.app.caching that referenced this issue Apr 5, 2017
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Apr 6, 2017
Branch: refs/heads/master
Date: 2017-04-05T23:05:59+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.caching@cd17acf

Fixed blank edit forms of the per ruleset parameters.

Fixes plone/Products.CMFPlone#1993

Files changed:
M CHANGES.rst
M plone/app/caching/browser/edit.py
Repository: plone.app.caching
Branch: refs/heads/master
Date: 2017-04-06T10:32:04+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.caching@ac8b6a8

Merge pull request #36 from plone/issue-1993-blank-edit-forms

Fixed blank edit forms of the per ruleset parameters.

Files changed:
M CHANGES.rst
M plone/app/caching/browser/edit.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Apr 6, 2017
Branch: refs/heads/master
Date: 2017-04-05T23:05:59+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.caching@cd17acf

Fixed blank edit forms of the per ruleset parameters.

Fixes plone/Products.CMFPlone#1993

Files changed:
M CHANGES.rst
M plone/app/caching/browser/edit.py
Repository: plone.app.caching
Branch: refs/heads/master
Date: 2017-04-06T10:32:04+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.caching@ac8b6a8

Merge pull request #36 from plone/issue-1993-blank-edit-forms

Fixed blank edit forms of the per ruleset parameters.

Files changed:
M CHANGES.rst
M plone/app/caching/browser/edit.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant