Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry records containing a "/" are not editable TTW #3296

Closed
ale-rt opened this issue Aug 6, 2021 · 2 comments · Fixed by plone/plone.app.registry#52
Closed

Registry records containing a "/" are not editable TTW #3296

ale-rt opened this issue Aug 6, 2021 · 2 comments · Fixed by plone/plone.app.registry#52
Assignees
@ale-rt

Comments

@ale-rt
Copy link
Member

ale-rt commented Aug 6, 2021

BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)

What I did:

What I expect to happen:

  • The record plone.bundles/filemanager.last_compilation is changed
  • I land to the portal registry page

What actually happened:

  • You land to an error page
  • The record plone.bundles/filemanager.last_compilation is not changed

What version of Plone/ Addons I am using:

Plone 6 but IIRC this was also the case on 5
@ale-rt ale-rt self-assigned this Aug 6, 2021
@ale-rt
Copy link
Member Author

ale-rt commented Aug 6, 2021

The issue is related to the form action that is wrongly pointing to: https://6-classic.demo.plone.org/portal_registry/edit/plone.bundles.
Opening the inspector and adding a trailing /filemanager.last_compilation allows the record to be saved.

@ale-rt ale-rt mentioned this issue Aug 6, 2021
Closed
ale-rt added a commit to plone/plone.app.registry that referenced this issue Aug 6, 2021
@ale-rt
Fix an issue that was preventing the edit of a registry record
cd7f5c1 
containing a "/" in its name

Fixes #51
Fixes plone/Products.CMFPlone#3296
@ale-rt ale-rt mentioned this issue Aug 6, 2021
Merged
ale-rt added a commit to plone/plone.app.registry that referenced this issue Aug 6, 2021
@ale-rt
Fix an issue that was preventing the edit of a registry record contai…
6e077a8 
…ning a "/" in its name

Refs #51
Refs plone/Products.CMFPlone#3296
@ale-rt ale-rt mentioned this issue Aug 6, 2021
Merged
@ale-rt
Copy link
Member Author

ale-rt commented Aug 9, 2021

Fix for Plone 6: plone/plone.app.registry#52
Fix for Plone 5.2: plone/plone.app.registry#53

mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Aug 10, 2021
@mauritsvanrees
[fc] Repository: plone.app.registry
c402360 
Branch: refs/heads/1.7.x
Date: 2021-08-06T14:13:22+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.registry@6e077a8

Fix an issue that was preventing the edit of a registry record containing a "/" in its name

Refs #51
Refs plone/Products.CMFPlone#3296

Files changed:
A news/51.bugfix
M plone/app/registry/browser/edit.py
M plone/app/registry/tests/test_controlpanel.py
Repository: plone.app.registry

Branch: refs/heads/1.7.x
Date: 2021-08-10T12:12:05+02:00
Author: Maurits van Rees (mauritsvanrees) <m.van.rees@zestsoftware.nl>
Commit: plone/plone.app.registry@056df78

Merge pull request #53 from plone/51-fix-editing-plone52

[Plone 5.2] Fix an issue that was preventing the edit of a registry record containing a "/" in its name

Files changed:
A news/51.bugfix
M plone/app/registry/browser/edit.py
M plone/app/registry/tests/test_controlpanel.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Aug 10, 2021
@mauritsvanrees
[fc] Repository: plone.app.registry
ae28685 
Branch: refs/heads/master
Date: 2021-08-06T12:49:06+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.registry@cd7f5c1

Fix an issue that was preventing the edit of a registry record
containing a "/" in its name

Fixes #51
Fixes plone/Products.CMFPlone#3296

Files changed:
M CHANGES.rst
M plone/app/registry/browser/edit.py
M plone/app/registry/tests/test_controlpanel.py
Repository: plone.app.registry

Branch: refs/heads/master
Date: 2021-08-06T14:07:44+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.registry@20711c3

fixup! Fix an issue that was preventing the edit of a registry record containing a "/" in its name

Files changed:
A news/51.bugfix
M CHANGES.rst
Repository: plone.app.registry

Branch: refs/heads/master
Date: 2021-08-10T12:12:36+02:00
Author: Maurits van Rees (mauritsvanrees) <m.van.rees@zestsoftware.nl>
Commit: plone/plone.app.registry@b9af7fa

Merge pull request #52 from plone/51-fix-editing

Fix an issue that was preventing the edit of a registry record containing a "/" in its name

Files changed:
A news/51.bugfix
M plone/app/registry/browser/edit.py
M plone/app/registry/tests/test_controlpanel.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ale-rt ale-rt

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ale-rt