plone.base references plone.app.layout - undeclared dependency indirection #3731
Comments
jensens
added a commit
to plone/plone.base
that referenced
this issue
Mar 6, 2023
jensens
added a commit
to plone/plone.app.layout
that referenced
this issue
Mar 6, 2023
add deprecated bbb import. part two to fix plone/Products.CMFPlone#3731
jensens
added a commit
to plone/plone.app.layout
that referenced
this issue
Mar 6, 2023
add deprecated bbb import. part two to fix plone/Products.CMFPlone#3731
This was referenced Mar 6, 2023
jensens
added a commit
to plone/plone.base
that referenced
this issue
Mar 6, 2023
jensens
added a commit
to plone/plone.base
that referenced
this issue
Mar 6, 2023
|
Yes, thanks, I was about to create the PRs myself, but thanks for doing it 👍🏾 |
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this issue
Mar 6, 2023
Branch: refs/heads/main Date: 2023-03-06T11:06:22+01:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.base@cae106a move INavigationRoot from plone.app.layout to plone.base. part one to fix plone/Products.CMFPlone#3731 Files changed: A news/Plone-3731.bugfix M src/plone/base/interfaces/__init__.py M src/plone/base/interfaces/siteroot.py Repository: plone.base Branch: refs/heads/main Date: 2023-03-06T15:25:07+01:00 Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com> Commit: plone/plone.base@e5e8275 Merge pull request #29 from plone/fix-navigationroot-import move INavigationRoot from plone.app.layout to plone.base. Files changed: A news/Plone-3731.bugfix M src/plone/base/interfaces/__init__.py M src/plone/base/interfaces/siteroot.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this issue
Mar 6, 2023
Branch: refs/heads/master Date: 2023-03-06T10:54:14+01:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.layout@b48c4ca move INavigationRoot from plone.app.layout to plone.base. add deprecated bbb import. part two to fix plone/Products.CMFPlone#3731 Files changed: A news/Plone-3731.bugfix M plone/app/layout/navigation/interfaces.py M setup.py Repository: plone.app.layout Branch: refs/heads/master Date: 2023-03-06T11:09:27+01:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.layout@bebefce update INavigationRoot imports to import from plone.base.interfaces Files changed: M plone/app/layout/globals/context.py M plone/app/layout/globals/tests/test_context.py M plone/app/layout/globals/tests/test_layout.py M plone/app/layout/globals/tests/test_portal.py M plone/app/layout/navigation/root.py M plone/app/layout/sitemap/configure.zcml M plone/app/layout/sitemap/tests/test_sitemap.py M plone/app/layout/viewlets/tests/test_common.py Repository: plone.app.layout Branch: refs/heads/master Date: 2023-03-06T15:27:03+01:00 Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com> Commit: plone/plone.app.layout@9c9d83f Merge pull request #333 from plone/fix-navigationroot-import move INavigationRoot from plone.app.layout to plone.base. Files changed: A news/Plone-3731.bugfix M plone/app/layout/globals/context.py M plone/app/layout/globals/tests/test_context.py M plone/app/layout/globals/tests/test_layout.py M plone/app/layout/globals/tests/test_portal.py M plone/app/layout/navigation/interfaces.py M plone/app/layout/navigation/root.py M plone/app/layout/sitemap/configure.zcml M plone/app/layout/sitemap/tests/test_sitemap.py M plone/app/layout/viewlets/tests/test_common.py M setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
plone.base.interfaces.siterootimportsplone.app.layout.navigation.interfaces.INavigationRootand derivesIPloneSiteRootfrom it. This is an undeclared dependency indirection.Todo: Move interface from plone.app.layout to plone.base and add a deprecated import to plone.app.layout.
See also plone/plone.base#28
cc @gforcada
The text was updated successfully, but these errors were encountered: