fix syndication settings to not write on read #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def __setattr__(self, name, value): | ||
| if name in ('context', '_metadata', 'site_settings'): | ||
| if name in ('context', '_metadata', 'site_settings', 'annotations', | ||
| 'needs_saving'): | ||
| self.__dict__[name] = value | ||
| else: | ||
| self._metadata[name] = value |
There was a problem hiding this comment.
You missed just one part of the back-port. need to call self._set()
gforcada
force-pushed
the
write-on-read
branch
from
d97fbe0 to
2078a7d
Compare
|
Running again: http://jenkins.plone.org/job/pull-request-4.3/126 |
gforcada
force-pushed
the
write-on-read
branch
from
2078a7d to
e56026f
Compare
|
And finally tests passes http://jenkins.plone.org/job/pull-request-4.3/129 @vangheem should we merge it? |
vangheem
added a commit
that referenced
this pull request
Oct 14, 2015
fix syndication settings to not write on read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport CSRF fix to 4.3.x