fix: getIcon for archetypes #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
may you add a note to the changelog please? |
Gagaro
force-pushed
the
fix-geticon-archetypes
branch
from
683970b to
197fae6
Compare
| when obj is an image or has a lead image | ||
| or has an image field with name 'image': true else false | ||
| """ | ||
| if obj.aq_base.image: |
There was a problem hiding this comment.
if the image attribute does not exist an AttributeError would be raised, is this intended? If not I'd change to
return bool(getattr(obj.aq_base, 'image', False))
There was a problem hiding this comment.
An exception in an indexer would just give an empty value, which is okay in this case. I copied this from plone/plone.app.contenttypes@3cfc044.
I like yours better though, I'll update it.
There was a problem hiding this comment.
ah, ok, usally if I see something like
if (some condition):
return True
return False
I tend to normalize to
return bool(condition)
even bool() is not needed always, but for an indexer its good to return explicit values.
Gagaro
force-pushed
the
fix-geticon-archetypes
branch
from
197fae6 to
ad873f9
Compare
|
Changelog added and indexer updated |
|
lets get jenkins opinion :) http://jenkins.plone.org/job/pull-request-5.0/606/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archetypes show a broken img as icon since #1226