Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version of mockup from thet-pickadate-clearandset-2.1.x branch #1938

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

thet
Copy link
Member

@thet thet commented Feb 4, 2017

@thet
Copy link
Member Author

thet commented Feb 6, 2017

@jensens jensens merged commit e0e7cd5 into 5.0.x Feb 6, 2017
@jensens jensens deleted the thet-mockup-pickadate-clearandset branch February 6, 2017 23:07
@thet thet mentioned this pull request Feb 6, 2017
@tomgross
Copy link
Member

tomgross commented Feb 7, 2017

@thet Thanks for the code! This has probably nothing to do with your code but compiling the code in the browser gives me the following traceback in the Plone 5.0.x branch

2017-02-07 08:25:42 ERROR Zope.SiteErrorLog 1486452342.990.0248622759892 https://webcms.dev.fhnw.ch/less-variables.js
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module Products.CMFPlone.resources.browser.mixins, line 71, in __call__
NameError: global name 'SafeFormatter' is not defined

@thet
Copy link
Member Author

thet commented Feb 7, 2017

@tomgross see comments in referenced PRs above.

@mauritsvanrees
Copy link
Member

Ah, well spotted.
I have made pull requests #1944 and #1945 to fix this.

@thet
Copy link
Member Author

thet commented Feb 7, 2017

@mauritsvanrees tnx for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants