Move usergroups controlpanel (now using z3cform) from p.a.controlpanel to Products.CMFPlone #262
Conversation
|
Looks overall good as far as I can say. Can you please add a line or two in order to log the changes in |
|
This is ready for merge. But in https://github.com/plone/plone.app.controlpanel/tree/master/plone/app/controlpanel we have still the usergroups code in. Whats the plan here? |
|
We need two pull requests. One for CMFPlone with the new control panel and one for p.a.controlpanel removing the control panel. Someone needs to run "bin/alltests --all" with those two pull requests checked out locally to make sure we do not break Jenkins. @jensens Github says this pull request is not ready for merge. I'd be happy to review if there are two pull request and "bin/alltests --all" passes. |
|
Sorry I was a bit busy these last days and didn't have time to fix/change this. |
|
@ferewuz Awesome! Thanks! Let me know if you need any help. |
|
oh, sorry, did the rebase already. great if a PR in p.a.controlpanel comes too! |
|
Unfortunately some tests seem to be failing right now, I'll check it some more to find out what the problems are. |
|
@ferewuz What's the current status of this pull request? Would you mind doing a rebase? Which tests are failing? Anything I can do to help? |
|
Sorry for a bit late response for this one. I will find some time today in the evening, do a rebase and check the tests again. |
vanclevstik
force-pushed
the
usergroups_controlpanel
branch
from
28791dc to
97b2d07
Compare
|
@tisto Rebased now and tests for Products.CMFPlone are ok, but i get some errors in other packages, can you take a quick look when you have some time? |
|
@ferewuz Thx. Will have a look. |
…m plone.app.controlpanel.
|
New pull request for plone.app.controlpanel: plone/plone.app.controlpanel#37 |
Move usergroups controlpanel (now using z3cform) from p.a.controlpanel to Products.CMFPlone
Remove cyclic dependency with Products.CMFPlone.
Refs #221