Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plone.app.discussion extends the review workflow (Plone 5.2) #3032

Closed
wants to merge 1 commit into from
Closed

plone.app.discussion extends the review workflow (Plone 5.2) #3032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Products/CMFPlone/tests/testWorkflowTool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def testGetTitleForTransitionOnTypeSucceedsWithNonString(self):

def testListWFStatesByTitle(self):
states = self.workflow.listWFStatesByTitle()
self.assertEqual(len(states), len(all_states))
self.assertGreaterEqual(len(states), len(all_states))
pub_states = [s for s in states if s[1] == 'published']
priv_states = [s for s in states if s[1] == 'private']
pend_states = [s for s in states if s[1] == 'pending']
Expand All @@ -122,9 +122,9 @@ def testListWFStatesByTitle(self):
internal_pub_states = [s for s in states
if s[1] == 'internally_published']

self.assertEqual(len(pub_states), all_states.count('published'))
self.assertGreaterEqual(len(pub_states), all_states.count('published'))
self.assertEqual(len(priv_states), all_states.count('private'))
self.assertEqual(len(pend_states), all_states.count('pending'))
self.assertGreaterEqual(len(pend_states), all_states.count('pending'))
self.assertEqual(len(vis_states), all_states.count('visible'))
self.assertEqual(len(external_states), all_states.count('external'))
self.assertEqual(len(internal_states), all_states.count('internal'))
Expand Down
2 changes: 2 additions & 0 deletions news/3000.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
plone.app.discussion extends the review workflow for moderation of comments. This change takes the additional workflow states into account.
[ksuess]