Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Improve tests for the workflow tool method listWFStatesByTitle #3036

Merged
merged 2 commits into from
Feb 13, 2020

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Feb 8, 2020

Test also the filter_similar option.
Use a dummy setup (makes life easier for tests and simplify the life of people who are changing for some reason the Plone workflows)

Refs #3032

@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ale-rt
Copy link
Member Author

ale-rt commented Feb 8, 2020

@jenkins-plone-org please run jobs

@ale-rt ale-rt changed the title Improve tests for the workflow tool method listWFStatesByTitle [5.2] Improve tests for the workflow tool method listWFStatesByTitle Feb 8, 2020
@ale-rt
Copy link
Member Author

ale-rt commented Feb 9, 2020

@jenkins-plone-org please run jobs

@ale-rt
Copy link
Member Author

ale-rt commented Feb 11, 2020

Robot failure in branch 5.2 do not appear related.
Please also merge with #3038

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much saner.
Can be merged.

@mauritsvanrees mauritsvanrees merged commit ba0e4de into 5.2.x Feb 13, 2020
@mauritsvanrees mauritsvanrees deleted the 3032-fix-tests branch February 13, 2020 08:04
@mauritsvanrees
Copy link
Member

I have merged both this 5.2 PR and the similar 6.0 PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants