fix #3323 #3367
fix #3323 #3367
Conversation
|
@jensens thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
| # Return a list of subobjects, used by ZMI tree tag (and only there). | ||
| # see also https://github.com/plone/Products.CMFPlone/issues/3323 | ||
| return sorted( | ||
| (obj for obj in self.objectValues() if getattr(aq_base(obj), 'isPrincipiaFolderish', False)), |
There was a problem hiding this comment.
Let me try:
| (obj for obj in self.objectValues() if getattr(aq_base(obj), 'isPrincipiaFolderish', False)), | |
| ( | |
| obj | |
| for obj in self.objectValues() | |
| if getattr(aq_base(obj), "isPrincipiaFolderish", False) | |
| ), |
There was a problem hiding this comment.
ah, and now I've been to fast.
There was a problem hiding this comment.
we should run black over the code base
There was a problem hiding this comment.
but not unless the big PR's are merged
see #3323