Adapt to changes of MemberData in CMFCore #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jensens
changed the title
jensens
approved these changes
Oct 1, 2017
| @implementer(IManageCapabilities) | ||
| class MemberData(BaseMemberData): | ||
| # FIXME: MemberData should probably be a more specific adapter | ||
| # instead of a subclass. |
There was a problem hiding this comment.
If the Interface is the same, there is no need to subclass IMember just for the sake of being more specific, so IMO this is perfectly fine.
There was a problem hiding this comment.
Thanks for the review. I'll remove the the FIXME.
|
I guess we need a legacy-branch when we merge this. Because this will not work in Plone 5.x. Merging can wait untill we have a stable 5.1 release and/or a new 6.0 branch for the coredev. |
|
Imo: Branch the current master as 5.x, and set it in coredev sources.cfg as the current. Increase major version number here to 6.0.dev0, in setup.py depend on CMFCore >=... and go on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge!
Fixes #24 for compatability with Zope 4