Python3 testfixes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
status: Total: 130 tests, 13 failures, 8 errors, 0 skipped
python_to_text is alive again ...
status: py2: 6 failures, 0 errors py3: 7 failures, 0 errors
somehow the contents starts to differ after 30+ characters .... maybe thats the reason someone cut it down to the first 20 characters to get passing tests 👽
status: py2: 0 failures, 0 errors py3: 0 failures, 0 errors
petschki
added
24 status: ready
and removed
22 status: in-progress
23 status: testing
31 needs: help
labels
|
@pbauer all 130 tests are green now in py2 and py3 ... can you try this branch on https://jenkins.plone.org/view/PLIPs/job/plip-py3/ ? |
|
LGTM, I merge this in the python3 branch now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request aims to fix all tests for
python3branch. there might be some transform refactorings too ...for better test-setup I've created a fork from https://github.com/plone/coredev.vagrant here: https://github.com/petschki/coredev.vagrant/tree/trusty64-py2-py3 (@smcmahon unfortunately I have no permissions to create a branch directly there) ... this sets up a virtual machine with Ubuntu 14.04 (trusty), clones buildout.coredev to
coredev_py2(Plone5.1, python2.7) andcoredev_py3(Plone5.2, python3.6) and installs some transforms dependencies (more to come) because binaries (and their options) are different on OSX and linux distros (namely pdftohtml/pdftotext etc. ) ... @pbauer maybe interresting for other people to setup testing infrastructure ... or you have some better existing test setups already ...any input/help much appreciated at this point 💪🏼
/cc @davisagli @thet @jensens @ale-rt