Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new TestCase using AT after PloneTestcase is now DX. #5

Merged
merged 8 commits into from
Oct 17, 2018

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Sep 24, 2018

No description provided.

@pbauer
Copy link
Member Author

pbauer commented Sep 27, 2018

Plone 4.3-5.1 will now use branch 2.1.x of archetypes.schemaextender

@gforcada gforcada closed this Sep 27, 2018
@gforcada gforcada reopened this Sep 27, 2018
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petschki
Copy link
Member

@pbauer since I saw you've started this pull request in pull-request-5.2: there are some errors since my last changes in trying to fix extender adapter leaking ... I can figure this out this evening and hopefully get a green pull request tonight ...

@petschki
Copy link
Member

petschki commented Oct 10, 2018

I was able to reproduce the (archetypes.schemaextender) failing test in pull-request-5.2 (https://jenkins.plone.org/view/Core/job/pull-request-5.2/1556/) with the following command

bin/test -s archetypes.schemaextender -s Products.CMFEditions -t usage.txt -t webdav_history.txt

but this only fails with P.CMFEditions/master in combination with a.schemaextender/testlayer ... this error is gone with commit plone/Products.CMFEditions@478019c which comes with plone/Products.CMFEditions#58 which tears down AppZapper correctly and doesn't spill other test layers.

So the Jenkins job https://jenkins.plone.org/view/Core/job/pull-request-5.2/1558/ is with parameters:

https://github.com/plone/Products.CMFEditions/pull/58
https://github.com/plone/archetypes.schemaextender/pull/5

So from my point of view this PR can safely be merged since we have to merge a bunch of other PR's too.

@jensens jensens merged commit 44c6fc3 into master Oct 17, 2018
@jensens jensens deleted the testlayer branch October 17, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants