-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to new TestCase using AT after PloneTestcase is now DX. #5
Conversation
Plone 4.3-5.1 will now use branch 2.1.x of archetypes.schemaextender |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pbauer since I saw you've started this pull request in pull-request-5.2: there are some errors since my last changes in trying to fix extender adapter leaking ... I can figure this out this evening and hopefully get a green pull request tonight ... |
I was able to reproduce the (archetypes.schemaextender) failing test in pull-request-5.2 (https://jenkins.plone.org/view/Core/job/pull-request-5.2/1556/) with the following command
but this only fails with So the Jenkins job https://jenkins.plone.org/view/Core/job/pull-request-5.2/1558/ is with parameters:
So from my point of view this PR can safely be merged since we have to merge a bunch of other PR's too. |
Instead of trying own cleanup and leaking stuff afterwads. Also did a cleanup while at it.
and cleanup code
No description provided.