Skip to content

Commit

Permalink
[fc] Repository: plone.themepreview
Browse files Browse the repository at this point in the history
Branch: refs/heads/master
Date: 2015-05-31T09:04:46+03:00
Author: Asko Soukka (datakurre) <asko.soukka@iki.fi>
Commit: plone/plone.themepreview@284f380

Update Travis configuration

Files changed:
M .travis.yml
  • Loading branch information
datakurre committed May 31, 2015
1 parent 782bfd4 commit 4863fbd
Showing 1 changed file with 29 additions and 70 deletions.
99 changes: 29 additions & 70 deletions last_commit.txt
Original file line number Diff line number Diff line change
@@ -1,77 +1,36 @@
Repository: Products.CMFPlone
Repository: plone.themepreview
Branch: refs/heads/master
Date: 2015-05-30T23:49:03-05:00
Author: vangheem (vangheem) <vangheem@gmail.com>
Commit: https://github.com/plone/Products.CMFPlone/commit/6585d8f35ecdc509cb19440221bbc26c2abf4bee
Date: 2015-05-31T09:04:46+03:00
Author: Asko Soukka (datakurre) <asko.soukka@iki.fi>
Commit: https://github.com/plone/plone.themepreview/commit/284f3804e6b82856331da3a050e3548a37d0a2d7

I have wasted hours of my life trying to figure
out these 2 annoying test failures that do not make any sense.
Look at the commit if you want to get details. Robot framework
can be so annoying...
Update Travis configuration

Files changed:
M Products/CMFPlone/tests/robot/test_overlays.robot
M .travis.yml

diff --git a/Products/CMFPlone/tests/robot/test_overlays.robot b/Products/CMFPlone/tests/robot/test_overlays.robot
index 9efb0e4..45623d5 100644
--- a/Products/CMFPlone/tests/robot/test_overlays.robot
+++ b/Products/CMFPlone/tests/robot/test_overlays.robot
@@ -64,24 +64,38 @@ Scenario: Set default content item of a folder overlay opens
When I set the default content view of the test folder
Then overlay should open

-Scenario: Change default content item of a folder overlay opens
- Given a logged-in site administrator
- And a document as the default view of the test folder
- When I change the default content view of the test folder
- Then overlay should open
-
-Scenario: Change default content item of a folder overlay closes
- Given a logged-in site administrator
- And a document as the default view of the test folder
- When I change the default content view of the test folder
- And I 'Cancel' the form
- Then overlay should close
- When I change the default content view of the test folder
- And I 'Save' the form
- Then overlay should close
- When I change the default content view of the test folder
- And I close the overlay
- Then overlay should close
+# XXX Next 2 tests are commented out. After hours of messing around,
+# I still can not pinpoint why this is happening.
+# The error originates from this change https://github.com/plone/mockup/commit/ccec87028bc22e082d6d9a95874d8a961f91b707
+# which provides at least some error reporting(window.alert) to users when modals
+# experience issues. We need this change in modals...
+#
+# However, in these 2 cases, it is triggering the window.alert
+# and causing the tests to fail in certain cases.
+# It ONLY happens when running automatically by the robot framework
+# runner. If you try to use Import library DebugLibrary and
+# run the commands manually, of course it works fine. So yes,
+# there is no way to really figure out this AFAIK.
+# Also, of course, this doesn't happen in real user testing.
+#
+#Scenario: Change default content item of a folder overlay opens
+# Given a logged-in site administrator
+# And a document as the default view of the test folder
+# When I change the default content view of the test folder
+# Then overlay should open
+
+#Scenario: Change default content item of a folder overlay closes
+# Given a logged-in site administrator
+# And a document as the default view of the test folder
+# When I change the default content view of the test folder
+# And I 'Cancel' the form
+# Then overlay should close
+# When I change the default content view of the test folder
+# And I 'Save' the form
+# Then overlay should close
+# When I change the default content view of the test folder
+# And I close the overlay
+# Then overlay should close

Scenario: Delete content action overlay opens
Given a logged-in site administrator
diff --git a/.travis.yml b/.travis.yml
index 3734ccd..c3dfdf2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,12 +1,15 @@
language: python
python: '2.7'
+sudo: false
+cache:
+ directories:
+ - eggs
before_install:
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start
install:
-- virtualenv buildout
-- mkdir -p buildout-cache/downloads build/html
-- buildout/bin/python bootstrap.py -c travis.cfg
+- mkdir -p build/html
+- ython bootstrap.py -c travis.cfg
- bin/buildout -N -t 3 -c travis.cfg
before_script:
- gem install --version 0.8.9 faraday


0 comments on commit 4863fbd

Please sign in to comment.