Skip to content

Commit

Permalink
[fc] Repository: archetypes.referencebrowserwidget
Browse files Browse the repository at this point in the history
Branch: refs/heads/master
Date: 2016-07-05T23:10:32+02:00
Author: Gil Forcada (gforcada) <gforcada@gnome.org>
Commit: plone/archetypes.referencebrowserwidget@cd9a287

Use zope.interface decorator

This not only makes code more pleasent to read,
but also makes the code python 3 compatible
(while maintaining python 2 compatibility).

Files changed:
M CHANGES.rst
M src/archetypes/referencebrowserwidget/browser/view.py
Repository: archetypes.referencebrowserwidget
Branch: refs/heads/master
Date: 2016-07-09T08:51:59+02:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/archetypes.referencebrowserwidget@3b1f495

Merge pull request #33 from plone/gforcada-use-zope-decorators

Use zope.interface decorator

Files changed:
M CHANGES.rst
M src/archetypes/referencebrowserwidget/browser/view.py
  • Loading branch information
gforcada committed Jul 9, 2016
1 parent ec9b303 commit cb61b66
Showing 1 changed file with 49 additions and 63 deletions.
112 changes: 49 additions & 63 deletions last_commit.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
Repository: collective.monkeypatcher
Repository: archetypes.referencebrowserwidget


Branch: refs/heads/master
Date: 2016-07-05T23:10:55+02:00
Date: 2016-07-05T23:10:32+02:00
Author: Gil Forcada (gforcada) <gforcada@gnome.org>
Commit: https://github.com/plone/collective.monkeypatcher/commit/d19a7f6be948dcbf224ffa6c3d84892d5ad8c6cc
Commit: https://github.com/plone/archetypes.referencebrowserwidget/commit/cd9a2873d54c5e87912d39e63b3d02a3d9b9938e

Use zope.interface decorator

Expand All @@ -14,10 +14,10 @@ but also makes the code python 3 compatible

Files changed:
M CHANGES.rst
M collective/monkeypatcher/meta.py
M src/archetypes/referencebrowserwidget/browser/view.py

diff --git a/CHANGES.rst b/CHANGES.rst
index 254c90b..743ee1f 100644
index e3ec56d..80e01e3 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,7 +10,8 @@ New:
Expand All @@ -29,55 +29,48 @@ index 254c90b..743ee1f 100644
+ [gforcada]


1.1.1 (2015-03-27)
diff --git a/collective/monkeypatcher/meta.py b/collective/monkeypatcher/meta.py
index 64375f3..fe06dba 100644
--- a/collective/monkeypatcher/meta.py
+++ b/collective/monkeypatcher/meta.py
@@ -4,7 +4,7 @@
from zope.configuration.exceptions import ConfigurationError
from zope.configuration.fields import GlobalObject, PythonIdentifier
from zope.event import notify
-from zope.interface import Interface, implements
+from zope.interface import Interface, implementer
from zope.schema import Int, Bool, Text

import interfaces
@@ -131,13 +131,12 @@ def _preconditions_matching(preconditions):
raise Exception('Unknown operator %s' % op)


+@implementer(interfaces.IMonkeyPatchEvent)
class MonkeyPatchEvent(object):
"""Envent raised when a monkeypatch is applied
see interfaces.IMonkeyPatchEvent
2.5.7 (2016-02-12)
diff --git a/src/archetypes/referencebrowserwidget/browser/view.py b/src/archetypes/referencebrowserwidget/browser/view.py
index 782544b..cd8f27d 100644
--- a/src/archetypes/referencebrowserwidget/browser/view.py
+++ b/src/archetypes/referencebrowserwidget/browser/view.py
@@ -49,6 +49,7 @@
_ = MessageFactory('atreferencebrowserwidget')


+@zope.interface.implementer(IReferenceBrowserHelperView)
class ReferenceBrowserHelperView(BrowserView):
""" A helper view for the reference browser widget.

@@ -57,8 +58,6 @@ class ReferenceBrowserHelperView(BrowserView):
and can not be a view, since it is macro widget for Archetypes.
"""

- implements(interfaces.IMonkeyPatchEvent)
- zope.interface.implements(IReferenceBrowserHelperView)
-
def __init__(self, mp_info):
self.patch_info = mp_info
return
def getFieldRelations(self, field, value=None):
""" Query relations of a field and a context.



Repository: collective.monkeypatcher
Repository: archetypes.referencebrowserwidget


Branch: refs/heads/master
Date: 2016-07-09T08:51:45+02:00
Date: 2016-07-09T08:51:59+02:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: https://github.com/plone/collective.monkeypatcher/commit/bbea8c34f34f5d84ea29fbeafdbeb330fb43ad5e
Commit: https://github.com/plone/archetypes.referencebrowserwidget/commit/3b1f4958f55a542bd8045df98ffbc2cb3df9e860

Merge pull request #5 from plone/gforcada-use-zope-decorators
Merge pull request #33 from plone/gforcada-use-zope-decorators

Use zope.interface decorator

Files changed:
M CHANGES.rst
M collective/monkeypatcher/meta.py
M src/archetypes/referencebrowserwidget/browser/view.py

diff --git a/CHANGES.rst b/CHANGES.rst
index 254c90b..743ee1f 100644
index e3ec56d..80e01e3 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,7 +10,8 @@ New:
Expand All @@ -89,34 +82,27 @@ index 254c90b..743ee1f 100644
+ [gforcada]


1.1.1 (2015-03-27)
diff --git a/collective/monkeypatcher/meta.py b/collective/monkeypatcher/meta.py
index 64375f3..fe06dba 100644
--- a/collective/monkeypatcher/meta.py
+++ b/collective/monkeypatcher/meta.py
@@ -4,7 +4,7 @@
from zope.configuration.exceptions import ConfigurationError
from zope.configuration.fields import GlobalObject, PythonIdentifier
from zope.event import notify
-from zope.interface import Interface, implements
+from zope.interface import Interface, implementer
from zope.schema import Int, Bool, Text

import interfaces
@@ -131,13 +131,12 @@ def _preconditions_matching(preconditions):
raise Exception('Unknown operator %s' % op)


+@implementer(interfaces.IMonkeyPatchEvent)
class MonkeyPatchEvent(object):
"""Envent raised when a monkeypatch is applied
see interfaces.IMonkeyPatchEvent
2.5.7 (2016-02-12)
diff --git a/src/archetypes/referencebrowserwidget/browser/view.py b/src/archetypes/referencebrowserwidget/browser/view.py
index 782544b..cd8f27d 100644
--- a/src/archetypes/referencebrowserwidget/browser/view.py
+++ b/src/archetypes/referencebrowserwidget/browser/view.py
@@ -49,6 +49,7 @@
_ = MessageFactory('atreferencebrowserwidget')


+@zope.interface.implementer(IReferenceBrowserHelperView)
class ReferenceBrowserHelperView(BrowserView):
""" A helper view for the reference browser widget.

@@ -57,8 +58,6 @@ class ReferenceBrowserHelperView(BrowserView):
and can not be a view, since it is macro widget for Archetypes.
"""

- implements(interfaces.IMonkeyPatchEvent)
- zope.interface.implements(IReferenceBrowserHelperView)
-
def __init__(self, mp_info):
self.patch_info = mp_info
return
def getFieldRelations(self, field, value=None):
""" Query relations of a field and a context.



0 comments on commit cb61b66

Please sign in to comment.