Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated a few minor versions. #104

Closed
wants to merge 3 commits into from
Closed

Conversation

mauritsvanrees
Copy link
Member

Done with:
checkversions -b versions-blacklist.cfg -l 2 versions.cfg

Blacklisted plone.app.redirector 1.2.1 as it needs plone.app.contenttypes,
at least for its tests. And it does not have it in setup.py.
Some changes on that branch might need to be reverted.

A few more possible version updates are found by checkversions. I will add some of them in further commits. I will ask Jenkins to run tests in between.

Done with:
checkversions -b versions-blacklist.cfg -l 2 versions.cfg

Blacklisted plone.app.redirector 1.2.1 as it needs plone.app.contenttypes,
at least for its tests.  And it does not have it in setup.py.
Some changes on that branch might need to be reverted.
@mauritsvanrees
Copy link
Member Author

@mauritsvanrees
Copy link
Member Author

http://jenkins.plone.org/view/PLIPs/job/pull-request-4.3/75/
But those are only changes in the ecosystem packages and I don't they are actually tested in this job.

@mauritsvanrees
Copy link
Member Author

@mauritsvanrees
Copy link
Member Author

The first two commits had good result on Jenkins. The third failed.

I will cherry-pick the first one, with the obvious minor version updates to core versions.

I do not trust the updates for the ecosystem versions. Some updates look okay, others look like they might get plone.app.widgets included. Ecosystem tests on my local laptop are already failing for some with the old versions. I don't see a Jenkins job. I will leave them at their current versions.

I do not see actual errors for the robotframework version updates, but the resulting xml cannot be parsed by Jenkins. I will leave that for someone with more robotframework/Jenkins knowledge:

Total time elapsed: 2169.709 seconds

Grand total: 123 packages, 0 failures

+ [ 4.3 = 5.0 ]
Xvfb stopping
Recording test results
Robot results publisher started...
-Parsing output xml:
Failed!
java.io.IOException: remote file operation failed: /home/jenkins/workspace/pull-request-4.3@3/parts/test at hudson.remoting.Channel@45f8e0b8:Node4: java.io.IOException: Parsing of output xml failed!
    at hudson.FilePath.act(FilePath.java:987)
    at hudson.FilePath.act(FilePath.java:969)
    at hudson.plugins.robot.RobotParser.parse(RobotParser.java:46)
    at hudson.plugins.robot.RobotPublisher.parse(RobotPublisher.java:218)
    at hudson.plugins.robot.RobotPublisher.perform(RobotPublisher.java:241)
    at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
    at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
    at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:726)
    at hudson.model.Build$BuildExecution.post2(Build.java:185)
    at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:671)
    at hudson.model.Run.execute(Run.java:1769)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
    at hudson.model.ResourceController.execute(ResourceController.java:98)
    at hudson.model.Executor.run(Executor.java:374)
Caused by: java.io.IOException: Parsing of output xml failed!
    at hudson.plugins.robot.RobotParser$RobotParserCallable.invoke(RobotParser.java:100)
    at hudson.plugins.robot.RobotParser$RobotParserCallable.invoke(RobotParser.java:51)
    at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2691)
    at hudson.remoting.UserRequest.perform(UserRequest.java:121)
    at hudson.remoting.UserRequest.perform(UserRequest.java:49)
    at hudson.remoting.Request$2.run(Request.java:325)
    at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)
    at ......remote call to Node4(Native Method)
    at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1361)
    at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
    at hudson.remoting.Channel.call(Channel.java:753)
    at hudson.FilePath.act(FilePath.java:980)
    ... 13 more
Caused by: javax.xml.stream.XMLStreamException: Could not find element tags (at line: 211 column: 1)
    at hudson.plugins.robot.RobotParser$RobotParserCallable.xmlException(RobotParser.java:164)
    at hudson.plugins.robot.RobotParser$RobotParserCallable.ignoreUntilStarts(RobotParser.java:205)
    at hudson.plugins.robot.RobotParser$RobotParserCallable.processTest(RobotParser.java:255)
    at hudson.plugins.robot.RobotParser$RobotParserCallable.processSuite(RobotParser.java:145)
    at hudson.plugins.robot.RobotParser$RobotParserCallable.processSuite(RobotParser.java:143)
    at hudson.plugins.robot.RobotParser$RobotParserCallable.parseResult(RobotParser.java:119)
    at hudson.plugins.robot.RobotParser$RobotParserCallable.invoke(RobotParser.java:95)
    at hudson.plugins.robot.RobotParser$RobotParserCallable.invoke(RobotParser.java:51)
    at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2691)
    at hudson.remoting.UserRequest.perform(UserRequest.java:121)
    at hudson.remoting.UserRequest.perform(UserRequest.java:49)
    at hudson.remoting.Request$2.run(Request.java:325)
    at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)
Build step 'Publish Robot Framework test results' changed build result to FAILURE

@jensens jensens deleted the maurits-43-minor-versions branch October 20, 2015 10:37
mister-roboto pushed a commit that referenced this pull request Apr 12, 2016
Branch: refs/heads/master
Date: 2016-04-12T00:18:47+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plonetheme.barceloneta@8036806

Structure pattern - alert classes
Use ``.alert.status`` selector as an alternative to ``.portalMessage`` for better support of the structure pattern.

Files changed:
M CHANGES.rst
M plonetheme/barceloneta/theme/less/alerts.plone.less
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css.map
Repository: plonetheme.barceloneta
Branch: refs/heads/master
Date: 2016-04-11T20:05:04-05:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plonetheme.barceloneta@51d16d2

Merge pull request #104 from plone/thet-alertclasses

Structure pattern - alert classes

Files changed:
M CHANGES.rst
M plonetheme/barceloneta/theme/less/alerts.plone.less
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css.map
mister-roboto pushed a commit that referenced this pull request Apr 12, 2016
Branch: refs/heads/master
Date: 2016-04-12T00:18:47+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plonetheme.barceloneta@8036806

Structure pattern - alert classes
Use ``.alert.status`` selector as an alternative to ``.portalMessage`` for better support of the structure pattern.

Files changed:
M CHANGES.rst
M plonetheme/barceloneta/theme/less/alerts.plone.less
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css.map
Repository: plonetheme.barceloneta
Branch: refs/heads/master
Date: 2016-04-11T20:05:04-05:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plonetheme.barceloneta@51d16d2

Merge pull request #104 from plone/thet-alertclasses

Structure pattern - alert classes

Files changed:
M CHANGES.rst
M plonetheme/barceloneta/theme/less/alerts.plone.less
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css
M plonetheme/barceloneta/theme/less/barceloneta-compiled.css.map
mister-roboto pushed a commit that referenced this pull request Jun 13, 2016
Branch: refs/heads/master
Date: 2016-06-11T15:56:31+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.discussion@bfeb66e

Removed `comment-migration` view.

This did not work anymore on Plone 5.  If you still need to migrate
from old-style comments, so from Plone 4.0 or earlier, please upgrade
to Plone 4.3 first.

Files changed:
M CHANGES.rst
M plone/app/discussion/browser/configure.zcml
M plone/app/discussion/browser/controlpanel.pt
M plone/app/discussion/browser/controlpanel.py
D plone/app/discussion/browser/migration.py
Repository: plone.app.discussion
Branch: refs/heads/master
Date: 2016-06-13T09:48:39+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.discussion@69ded59

Merge pull request #104 from plone/maurits-remove-migration

Removed `comment-migration` view.

Files changed:
M CHANGES.rst
M plone/app/discussion/browser/configure.zcml
M plone/app/discussion/browser/controlpanel.pt
M plone/app/discussion/browser/controlpanel.py
D plone/app/discussion/browser/migration.py
mister-roboto pushed a commit that referenced this pull request Jun 13, 2016
Branch: refs/heads/master
Date: 2016-06-11T15:56:31+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.discussion@bfeb66e

Removed `comment-migration` view.

This did not work anymore on Plone 5.  If you still need to migrate
from old-style comments, so from Plone 4.0 or earlier, please upgrade
to Plone 4.3 first.

Files changed:
M CHANGES.rst
M plone/app/discussion/browser/configure.zcml
M plone/app/discussion/browser/controlpanel.pt
M plone/app/discussion/browser/controlpanel.py
D plone/app/discussion/browser/migration.py
Repository: plone.app.discussion
Branch: refs/heads/master
Date: 2016-06-13T09:48:39+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.discussion@69ded59

Merge pull request #104 from plone/maurits-remove-migration

Removed `comment-migration` view.

Files changed:
M CHANGES.rst
M plone/app/discussion/browser/configure.zcml
M plone/app/discussion/browser/controlpanel.pt
M plone/app/discussion/browser/controlpanel.py
D plone/app/discussion/browser/migration.py
mister-roboto pushed a commit that referenced this pull request Aug 25, 2016
Branch: refs/heads/master
Date: 2016-08-23T16:52:57+02:00
Author: Rene Jochum (pcdummy) <rene@jochums.at>
Commit: plone/plone.app.content@dafc702

Fix a circular reference error in the json dumper.

Signed-off-by: Rene Jochum &lt;rene@jochums.at&gt;

Files changed:
M CHANGES.rst
M plone/app/content/utils.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-08-26T01:32:38+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.content@b87e937

Merge pull request #104 from plone/circular_reference_fix

Fix a circular reference error in the json dumper.

Files changed:
M CHANGES.rst
M plone/app/content/utils.py
mister-roboto pushed a commit that referenced this pull request Aug 25, 2016
Branch: refs/heads/master
Date: 2016-08-23T16:52:57+02:00
Author: Rene Jochum (pcdummy) <rene@jochums.at>
Commit: plone/plone.app.content@dafc702

Fix a circular reference error in the json dumper.

Signed-off-by: Rene Jochum &lt;rene@jochums.at&gt;

Files changed:
M CHANGES.rst
M plone/app/content/utils.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-08-26T01:32:38+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.content@b87e937

Merge pull request #104 from plone/circular_reference_fix

Fix a circular reference error in the json dumper.

Files changed:
M CHANGES.rst
M plone/app/content/utils.py
mister-roboto pushed a commit that referenced this pull request Nov 13, 2016
Branch: refs/heads/master
Date: 2016-11-13T21:30:52+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.layout@d12465b

showEditableBorder was renamed to showToolbar

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/contentactions_blank.pt
M plone/app/layout/viewlets/contentviews.pt
M plone/app/layout/viewlets/menu.pt
Repository: plone.app.layout
Branch: refs/heads/master
Date: 2016-11-13T21:30:52+01:00
Author: Gil Forcada (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.layout@8da53a1

have_portets is on plone_layout

It was on @@plone view but it was already deprecated and
finally it has been removed.

Files changed:
M plone/app/layout/viewlets/common.py
Repository: plone.app.layout
Branch: refs/heads/master
Date: 2016-11-13T23:31:41+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.layout@d358eb5

Merge pull request #104 from plone/gforcada-patch-2

Replace showEditableBorder with showToolbar

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/common.py
M plone/app/layout/viewlets/contentactions_blank.pt
M plone/app/layout/viewlets/contentviews.pt
M plone/app/layout/viewlets/menu.pt
mister-roboto pushed a commit that referenced this pull request Feb 6, 2018
Branch: refs/heads/master
Date: 2017-10-22T12:48:30+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.portlets@e8a7cfa

Imports are Python3 compatible

Files changed:
M CHANGES.rst
M plone/app/portlets/exportimport/portlets.py
M plone/app/portlets/tests/test_actions_portlet.py
M plone/app/portlets/tests/test_exportimport.py
M setup.py
Repository: plone.app.portlets

Branch: refs/heads/master
Date: 2018-02-06T11:00:14+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.portlets@a82becc

Merge pull request #104 from plone/py3_imports

Imports are Python3 compatible

Files changed:
M CHANGES.rst
M plone/app/portlets/exportimport/portlets.py
M plone/app/portlets/tests/test_actions_portlet.py
M plone/app/portlets/tests/test_exportimport.py
M setup.py
mister-roboto pushed a commit that referenced this pull request Feb 7, 2019
Branch: refs/heads/master
Date: 2019-02-07T16:30:38+01:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.robotframework@7178ed1

Replace "Zope 2 server" with the more appropriate "Zope robot server"

Files changed:
M CHANGES.rst
M src/plone/app/robotframework/server.py
Repository: plone.app.robotframework

Branch: refs/heads/master
Date: 2019-02-07T17:33:35+01:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.robotframework@c4674a6

Fix killing the child of a process

Files changed:
M CHANGES.rst
M src/plone/app/robotframework/reload.py
Repository: plone.app.robotframework

Branch: refs/heads/master
Date: 2019-02-08T00:51:58+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.robotframework@8fe1974

Merge pull request #104 from plone/improvements

Assorted improvements

Files changed:
M CHANGES.rst
M src/plone/app/robotframework/reload.py
M src/plone/app/robotframework/server.py
mister-roboto pushed a commit that referenced this pull request Apr 11, 2019
Branch: refs/heads/master
Date: 2019-03-26T18:01:16+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@6f7498d

fix value conversion see plone/plone.app.vocabularies#56 (comment)

Files changed:
M plone/app/z3cform/converters.py
M plone/app/z3cform/tests/test_widgets.py
M plone/app/z3cform/widget.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-03-26T18:01:33+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@84c735a

document changes

Files changed:
M CHANGES.rst
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-03-26T20:11:40+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@5507d50

check explicit for None

Files changed:
M plone/app/z3cform/widget.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-03-26T20:17:31+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@3c26391

happiness for code analysis

Files changed:
M plone/app/z3cform/converters.py
M plone/app/z3cform/tests/test_widgets.py
M plone/app/z3cform/widget.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-03-26T20:19:40+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@54b0948

happiness for code analysis (2)

Files changed:
M plone/app/z3cform/converters.py
M plone/app/z3cform/widget.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-03-27T08:35:17+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@468e06a

lowercase bool arg

Files changed:
M plone/app/z3cform/widget.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-03-27T09:57:32+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@7fd4cdb

require recent plone.app.z3cform

Files changed:
M setup.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-03-27T09:58:22+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@f5f94e9

fix test and check deeper after refactroring plone.app.z3cform

Files changed:
M plone/app/z3cform/interfaces.py
M plone/app/z3cform/tests/test_widgets.py
M plone/app/z3cform/widget.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-03-27T10:03:29+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@93c8c3a

this is kind of a feature change.

Nothing that should go into 5.1

Files changed:
M CHANGES.rst
M setup.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-03-27T21:20:54+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@e6c66f2

add display mode for ajaxselectwidget

Files changed:
A plone/app/z3cform/templates/ajaxselect_display.pt
M CHANGES.rst
M plone/app/z3cform/configure.zcml
M plone/app/z3cform/widget.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-03-28T14:50:51+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@7612ce0

housekeeping - steps to get rid of plone.app.widgets

Files changed:
A plone/app/z3cform/factories.py
M plone/app/z3cform/configure.zcml
M plone/app/z3cform/interfaces.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-03-28T16:13:11+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@59ffe5b

missing class

Files changed:
M plone/app/z3cform/factories.py
M plone/app/z3cform/widget.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-04-08T13:55:42+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@6abfd8b

document interface move

Files changed:
M CHANGES.rst
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2019-04-11T14:04:44+02:00
Author: agitator (agitator) <agitator@users.noreply.github.com>
Commit: plone/plone.app.z3cform@ca65b28

Merge pull request #104 from plone/fix-ajax-select-widget-value-conversion

Fix value conversion in AjaxSelectWidget to respect tokens

Files changed:
A plone/app/z3cform/factories.py
A plone/app/z3cform/templates/ajaxselect_display.pt
M CHANGES.rst
M plone/app/z3cform/configure.zcml
M plone/app/z3cform/converters.py
M plone/app/z3cform/interfaces.py
M plone/app/z3cform/tests/test_widgets.py
M plone/app/z3cform/widget.py
M setup.py
mister-roboto pushed a commit that referenced this pull request May 10, 2019
Branch: refs/heads/master
Date: 2019-05-06T16:39:50-05:00
Author: Jens Vagelpohl (dataflake) <jens@mineralware.com>
Commit: plone/plone.recipe.zope2instance@1b1971b

Try to look up a suitable log file for the ``logtail`` verb (fixes #85)

Files changed:
M buildout.cfg
M src/plone/recipe/zope2instance/ctl.py
Repository: plone.recipe.zope2instance

Branch: refs/heads/master
Date: 2019-05-06T16:43:55-05:00
Author: Jens Vagelpohl (dataflake) <jens@mineralware.com>
Commit: plone/plone.recipe.zope2instance@c39943e

- change log entry

Files changed:
A news/85.bugfix
Repository: plone.recipe.zope2instance

Branch: refs/heads/master
Date: 2019-05-06T16:44:44-05:00
Author: Jens Vagelpohl (dataflake) <jens@mineralware.com>
Commit: plone/plone.recipe.zope2instance@62f7bf1

- remove inadvertent checkin

Files changed:
M buildout.cfg
Repository: plone.recipe.zope2instance

Branch: refs/heads/master
Date: 2019-05-10T13:00:49+02:00
Author: Maurits van Rees (mauritsvanrees) <m.van.rees@zestsoftware.nl>
Commit: plone/plone.recipe.zope2instance@e539531

Merge pull request #104 from plone/issue_85

Try to look up a suitable log file for the ``logtail`` verb

Files changed:
A news/85.bugfix
M src/plone/recipe/zope2instance/ctl.py
mister-roboto pushed a commit that referenced this pull request Oct 8, 2021
Branch: refs/heads/master
Date: 2021-10-07T17:22:41+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.users@db322f0

remove bbb adapter to access controlpanel registry data

Files changed:
A news/104.bugfix
M plone/app/users/browser/register.py
Repository: plone.app.users

Branch: refs/heads/master
Date: 2021-10-08T12:37:11+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.users@7132145

Merge pull request #104 from plone/rm-bbb-controlpanel-adapter

Remove bbb adapter to access controlpanel registry data

Files changed:
A news/104.bugfix
M plone/app/users/browser/register.py
mister-roboto pushed a commit that referenced this pull request Dec 25, 2021
Branch: refs/heads/master
Date: 2021-12-22T17:22:43+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.namedfile@2b46502

Add support for tiles in DefaultImageScalingFactory.

plone.app.tiles has its [own image scale factory](https://github.com/plone/plone.app.tiles/blob/3.2.2/plone/app/tiles/imagescaling.py#L110).
It [passes this around](https://github.com/plone/plone.app.tiles/blob/3.2.2/plone/app/tiles/imagescaling.py#L180) in a [deprecated way](https://github.com/plone/plone.scale/blob/3.1.2/plone/scale/storage.py#L207-L212).
Its scale factory does almost the same as the DefaultImageScalingFactory, although it is structured differently, as a function instead of a class.
Result is that the tiles scale factory is missing some features and fixes from the default, at least support for SVG and passing a quality parameter.

The only *intended* difference of the tile scale factory, is that it gets the original field value from the [tile data](https://github.com/plone/plone.app.tiles/blob/3.2.2/plone/app/tiles/imagescaling.py#L114),
instead of a [field on the context](https://github.com/plone/plone.namedfile/blob/5.5.1/plone/namedfile/scaling.py#L214).

The current commit makes the DefaultImageScalingFactory work for tiles.
Next step would be to update plone.app.tiles to use this.  This mostly involves removing code.

(Maybe something similar would be useful/needed for images in portlets, but I did not check. Do scales of images fields in portlets even work today?)

This will also make future support for focal points easier: there will be just one scaling factory to fix, instead of two.

Files changed:
A news/104.feature
M plone/namedfile/scaling.py
M setup.py
Repository: plone.namedfile

Branch: refs/heads/master
Date: 2021-12-23T23:05:19+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.namedfile@5fb1c8b

Make DefaultImageScalingFactory more flexible by splitting out methods.

Sub classes can override these.
This replaces adding support for tiles.

Files changed:
M news/104.feature
M plone/namedfile/scaling.py
Repository: plone.namedfile

Branch: refs/heads/master
Date: 2021-12-23T23:05:19+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.namedfile@b4f8020

Also factor out creating the scale or handling an svg.

Makes the __call__ method smaller.
And makes it easier to close the possibly open blob file.

Files changed:
M plone/namedfile/scaling.py
Repository: plone.namedfile

Branch: refs/heads/master
Date: 2021-12-25T17:08:30+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.namedfile@e2b0830

Merge pull request #104 from plone/maurits-tiles-support-in-scaling

Split DefaultImageScalingFactory into more methods for flexibility

Files changed:
A news/104.feature
M plone/namedfile/scaling.py
M setup.py
mister-roboto pushed a commit that referenced this pull request Dec 25, 2021
Branch: refs/heads/master
Date: 2021-12-22T17:22:43+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.namedfile@2b46502

Add support for tiles in DefaultImageScalingFactory.

plone.app.tiles has its [own image scale factory](https://github.com/plone/plone.app.tiles/blob/3.2.2/plone/app/tiles/imagescaling.py#L110).
It [passes this around](https://github.com/plone/plone.app.tiles/blob/3.2.2/plone/app/tiles/imagescaling.py#L180) in a [deprecated way](https://github.com/plone/plone.scale/blob/3.1.2/plone/scale/storage.py#L207-L212).
Its scale factory does almost the same as the DefaultImageScalingFactory, although it is structured differently, as a function instead of a class.
Result is that the tiles scale factory is missing some features and fixes from the default, at least support for SVG and passing a quality parameter.

The only *intended* difference of the tile scale factory, is that it gets the original field value from the [tile data](https://github.com/plone/plone.app.tiles/blob/3.2.2/plone/app/tiles/imagescaling.py#L114),
instead of a [field on the context](https://github.com/plone/plone.namedfile/blob/5.5.1/plone/namedfile/scaling.py#L214).

The current commit makes the DefaultImageScalingFactory work for tiles.
Next step would be to update plone.app.tiles to use this.  This mostly involves removing code.

(Maybe something similar would be useful/needed for images in portlets, but I did not check. Do scales of images fields in portlets even work today?)

This will also make future support for focal points easier: there will be just one scaling factory to fix, instead of two.

Files changed:
A news/104.feature
M plone/namedfile/scaling.py
M setup.py
Repository: plone.namedfile

Branch: refs/heads/master
Date: 2021-12-23T23:05:19+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.namedfile@5fb1c8b

Make DefaultImageScalingFactory more flexible by splitting out methods.

Sub classes can override these.
This replaces adding support for tiles.

Files changed:
M news/104.feature
M plone/namedfile/scaling.py
Repository: plone.namedfile

Branch: refs/heads/master
Date: 2021-12-23T23:05:19+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.namedfile@b4f8020

Also factor out creating the scale or handling an svg.

Makes the __call__ method smaller.
And makes it easier to close the possibly open blob file.

Files changed:
M plone/namedfile/scaling.py
Repository: plone.namedfile

Branch: refs/heads/master
Date: 2021-12-25T17:08:30+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.namedfile@e2b0830

Merge pull request #104 from plone/maurits-tiles-support-in-scaling

Split DefaultImageScalingFactory into more methods for flexibility

Files changed:
A news/104.feature
M plone/namedfile/scaling.py
M setup.py
mister-roboto pushed a commit that referenced this pull request Jan 31, 2022
Branch: refs/heads/master
Date: 2022-01-31T19:50:01+01:00
Author: Balázs Reé (reebalazs) <ree@greenfinity.hu>
Commit: plone/plone.app.querystring@2e7e326

Add lazy attribute to vocabularies to prevent fetching any results (#104)

* Add lazy attribute to vocabularies to prevent fetching any results

Huge vocabularies cause serious performance problems in the server
memory, in the network payload, and in the browser, because the large
result set is fetched pointlessly. An application can set lazy=True
for such vocabularies, and at the same time override the operations
from xml to provide an "autocomplete" widget. Such a widget does not
need any initial results but will search and fetch the vocabulary
lazily, on demand.

The use case targets Volto sites, but the problem is not specific to
Volto.

* Update attribute name to fetch_vocabulary, fix tests

- fix tests in registry_testdata.py
- update attribute name to fetch_vocabulary, default False

Files changed:
A news/104.feature
M plone/app/querystring/interfaces.py
M plone/app/querystring/registryreader.py
M plone/app/querystring/tests/registry_testdata.py
mister-roboto pushed a commit that referenced this pull request Jan 31, 2022
Branch: refs/heads/master
Date: 2022-01-31T19:50:01+01:00
Author: Balázs Reé (reebalazs) <ree@greenfinity.hu>
Commit: plone/plone.app.querystring@2e7e326

Add lazy attribute to vocabularies to prevent fetching any results (#104)

* Add lazy attribute to vocabularies to prevent fetching any results

Huge vocabularies cause serious performance problems in the server
memory, in the network payload, and in the browser, because the large
result set is fetched pointlessly. An application can set lazy=True
for such vocabularies, and at the same time override the operations
from xml to provide an "autocomplete" widget. Such a widget does not
need any initial results but will search and fetch the vocabulary
lazily, on demand.

The use case targets Volto sites, but the problem is not specific to
Volto.

* Update attribute name to fetch_vocabulary, fix tests

- fix tests in registry_testdata.py
- update attribute name to fetch_vocabulary, default False

Files changed:
A news/104.feature
M plone/app/querystring/interfaces.py
M plone/app/querystring/registryreader.py
M plone/app/querystring/tests/registry_testdata.py
mister-roboto pushed a commit that referenced this pull request Dec 12, 2022
Branch: refs/heads/main
Date: 2022-12-12T18:51:02+01:00
Author: Victor Fernandez de Alba (sneridagh) <sneridagh@gmail.com>
Commit: plone/plone.volto@1a83706

Add changelog to #103

Files changed:
A news/103.bugfix
Repository: plone.volto

Branch: refs/heads/main
Date: 2022-12-12T18:56:44+01:00
Author: Víctor Fernández de Alba (sneridagh) <sneridagh@gmail.com>
Commit: plone/plone.volto@5352b32

Merge pull request #104 from plone/addchangelogto103

Add changelog to #103

Files changed:
A news/103.bugfix
mister-roboto pushed a commit that referenced this pull request Feb 25, 2023
Branch: refs/heads/master
Date: 2023-02-25T01:57:49+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.iterate@f501923

Drop support for Plone 5.2.

Removed `archetypes` extra.
Use `plone.base` more.

Files changed:
M plone/app/iterate/util.py
M setup.py
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2023-02-25T02:22:58+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.iterate@da57b29

Drop Archetypes related code.

Files changed:
M plone/app/iterate/configure.zcml
M plone/app/iterate/interfaces.py
M plone/app/iterate/testing.py
M plone/app/iterate/tests/dexterity.rst
M plone/app/iterate/tests/test_doctests.py
D plone/app/iterate/at.zcml
D plone/app/iterate/copier.py
D plone/app/iterate/policy.py
D plone/app/iterate/relation.py
D plone/app/iterate/tests/browser.rst
D plone/app/iterate/tests/content.py
D plone/app/iterate/tests/test_iterate_at.py
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2023-02-25T02:22:59+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.iterate@9b39f51

Removed check and warning for plone.app.stagingbehavior.

Files changed:
M plone/app/iterate/__init__.py
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2023-02-25T02:24:35+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.iterate@dad6f22

Add news snippet.

Files changed:
A news/1.breaking
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2023-02-25T02:27:37+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.iterate@e2f651e

Nuke trailing white space.

Files changed:
M CHANGES.rst
M plone/app/iterate/browser/checkout.pt
Repository: plone.app.iterate

Branch: refs/heads/master
Date: 2023-02-25T09:50:21+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.iterate@ac4f353

Merge pull request #104 from plone/maurits-drop-52

Drop support for Plone 5.2, Python 2, Archetypes.

Files changed:
A news/1.breaking
M CHANGES.rst
M plone/app/iterate/__init__.py
M plone/app/iterate/browser/checkout.pt
M plone/app/iterate/configure.zcml
M plone/app/iterate/interfaces.py
M plone/app/iterate/testing.py
M plone/app/iterate/tests/dexterity.rst
M plone/app/iterate/tests/test_doctests.py
M plone/app/iterate/util.py
M setup.py
D plone/app/iterate/at.zcml
D plone/app/iterate/copier.py
D plone/app/iterate/policy.py
D plone/app/iterate/relation.py
D plone/app/iterate/tests/browser.rst
D plone/app/iterate/tests/content.py
D plone/app/iterate/tests/test_iterate_at.py
mister-roboto pushed a commit that referenced this pull request Jun 30, 2023
Branch: refs/heads/master
Date: 2023-06-30T10:05:13+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.schemaeditor@8f4aae0

remove dependency on `plone.app.z3cform`

Files changed:
M plone/schemaeditor/schema.py
M setup.py
Repository: plone.schemaeditor

Branch: refs/heads/master
Date: 2023-06-30T10:06:47+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.schemaeditor@fd61e7f

changenote

Files changed:
A news/104.bugfix
Repository: plone.schemaeditor

Branch: refs/heads/master
Date: 2023-06-30T16:16:33+03:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.schemaeditor@cd01589

Merge pull request #104 from plone/petschki-dependency

Remove dependency on `plone.app.z3cform`

Files changed:
A news/104.bugfix
M plone/schemaeditor/schema.py
M setup.py
mister-roboto pushed a commit that referenced this pull request Jun 30, 2023
Branch: refs/heads/master
Date: 2023-06-30T10:05:13+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.schemaeditor@8f4aae0

remove dependency on `plone.app.z3cform`

Files changed:
M plone/schemaeditor/schema.py
M setup.py
Repository: plone.schemaeditor

Branch: refs/heads/master
Date: 2023-06-30T10:06:47+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.schemaeditor@fd61e7f

changenote

Files changed:
A news/104.bugfix
Repository: plone.schemaeditor

Branch: refs/heads/master
Date: 2023-06-30T16:16:33+03:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.schemaeditor@cd01589

Merge pull request #104 from plone/petschki-dependency

Remove dependency on `plone.app.z3cform`

Files changed:
A news/104.bugfix
M plone/schemaeditor/schema.py
M setup.py
mister-roboto pushed a commit that referenced this pull request May 25, 2024
Branch: refs/heads/master
Date: 2024-05-14T19:55:52+02:00
Author: Paul Grunewald (pgrunewald) <paul.grunewald@tu-dresden.de>
Commit: plone/plone.app.linkintegrity@3d2a436

Fix potential issue calculating breaches with objects sharing the same prefix

Files changed:
A news/97.bugfix
M plone/app/linkintegrity/browser/info.py
M plone/app/linkintegrity/tests/test_references.py
Repository: plone.app.linkintegrity

Branch: refs/heads/master
Date: 2024-05-25T12:24:43-07:00
Author: David Glick (davisagli) <david.glick@plone.org>
Commit: plone/plone.app.linkintegrity@bbf124e

Merge pull request #104 from plone/fix_97

Fix potential issue calculating breaches with objects sharing the same prefix

Files changed:
A news/97.bugfix
M plone/app/linkintegrity/browser/info.py
M plone/app/linkintegrity/tests/test_references.py
mister-roboto pushed a commit that referenced this pull request May 25, 2024
Branch: refs/heads/master
Date: 2024-05-14T19:55:52+02:00
Author: Paul Grunewald (pgrunewald) <paul.grunewald@tu-dresden.de>
Commit: plone/plone.app.linkintegrity@3d2a436

Fix potential issue calculating breaches with objects sharing the same prefix

Files changed:
A news/97.bugfix
M plone/app/linkintegrity/browser/info.py
M plone/app/linkintegrity/tests/test_references.py
Repository: plone.app.linkintegrity

Branch: refs/heads/master
Date: 2024-05-25T12:24:43-07:00
Author: David Glick (davisagli) <david.glick@plone.org>
Commit: plone/plone.app.linkintegrity@bbf124e

Merge pull request #104 from plone/fix_97

Fix potential issue calculating breaches with objects sharing the same prefix

Files changed:
A news/97.bugfix
M plone/app/linkintegrity/browser/info.py
M plone/app/linkintegrity/tests/test_references.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant