Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout Products.GenericSetup. #114

Closed
wants to merge 1 commit into from
Closed

Checkout Products.GenericSetup. #114

wants to merge 1 commit into from

Conversation

mauritsvanrees
Copy link
Member

This is to check plone/Products.CMFPlone#1041

@mauritsvanrees
Copy link
Member Author

http://jenkins.plone.org/job/pull-request-5.0/368/

@pbauer
Copy link
Member

pbauer commented Sep 20, 2015

@mauritsvanrees there are still test-failures. An easy way to reproduce:
./bin/test -s plone.app.contenttypes -t test_content_profile

@pbauer pbauer mentioned this pull request Sep 20, 2015
Closed
@mauritsvanrees
Copy link
Member Author

Hopefully fixed with plone/plone.app.contenttypes@325a63c
At least then the p.a.contenttypes tests pass for me locally with old and new GS.

New Jenkins run (in the queue): http://jenkins.plone.org/job/pull-request-5.0/370/

@mauritsvanrees
Copy link
Member Author

The problem was: plone.app.contenttypes was correctly installed, I can see that in a pdb in that setUp method. Before anything is executed of this method, portal.portal_types has Document and various others in it. Then we would until now apply Products.CMFPlone:plone, which also applies several dependencies, and when we check after this, the portal_types tool is almost empty.
With the old (well current 1.7.7) GS, the subsequent applyProfile of our content profile would also apply its dependency profile-plone.app.contenttypes:default and all would have been well again.

In this case I removed the applyProfile of CMFPlone, because this was totally not needed.

You can compare it with this scenario:

  • plone.app.contenttypes is installed
  • the user removes the Document type from portal_types (manually, or by applying some other profile that does this)
  • the user applies the content profile of plone.app.contenttypes.

Old result: GS ruthlessly applies its dependency profile (p.a.c. default) and all is well. Downside: I think most people here agree that reapplying should be avoided if possible.

New result: GS sees its dependency profile is already is installed, and leaves it alone, giving a traceback when the content profile tries to create a Document.

I guess we should accept that this new result can happen. And in the case of failing tests, we need to fix those tests.

@pbauer
Copy link
Member

pbauer commented Sep 21, 2015

I also had to fix a test in Products.CMFPlacefulWorkflow: plone/Products.CMFPlacefulWorkflow@3c7bd2b
@mauritsvanrees we need to add your changes to the plone-documentation (probably also to the upgrade-guide) and I think we should bump the version of Generic Setup to 1.8

@pbauer pbauer closed this Sep 21, 2015
@jensens jensens deleted the maurits-gs-178-unreleased branch September 29, 2015 20:30
mister-roboto pushed a commit that referenced this pull request Feb 24, 2016
@vangheem
[fc] Repository: plone.app.widgets
880e8d5 
Branch: refs/heads/master
Date: 2016-02-24T16:04:31+01:00
Author: Gagaro (Gagaro) <gagaro42@gmail.com>
Commit: plone/plone.app.widgets@f74dfb4

fix: ensure we have all content for tree query in relateditems

Files changed:
M CHANGES.rst
M plone/app/widgets/utils.py
Repository: plone.app.widgets
Branch: refs/heads/master
Date: 2016-02-24T09:24:06-06:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.widgets@8d52223

Merge pull request #114 from plone/fix-relateditems-treequery

fix: ensure we have all content for tree query in relateditems

Files changed:
M CHANGES.rst
M plone/app/widgets/utils.py
mister-roboto pushed a commit that referenced this pull request Sep 16, 2016
@jensens
[fc] Repository: plone.app.theming
1797493 
Branch: refs/heads/master
Date: 2016-09-01T10:05:05+03:00
Author: Asko Soukka (datakurre) <asko.soukka@iki.fi>
Commit: plone/plone.app.theming@a15be7d

Add update button to theming control panel

Files changed:
M CHANGES.rst
M src/plone/app/theming/browser/controlpanel.pt
Repository: plone.app.theming
Branch: refs/heads/master
Date: 2016-09-16T23:39:00+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.theming@eea1435

Merge pull request #114 from plone/datakurre-update-theme

Add update button to theming control panel

Files changed:
M CHANGES.rst
M src/plone/app/theming/browser/controlpanel.pt
mister-roboto pushed a commit that referenced this pull request Sep 16, 2016
@jensens
[fc] Repository: plone.app.theming
3f7385b 
Branch: refs/heads/master
Date: 2016-09-01T10:05:05+03:00
Author: Asko Soukka (datakurre) <asko.soukka@iki.fi>
Commit: plone/plone.app.theming@a15be7d

Add update button to theming control panel

Files changed:
M CHANGES.rst
M src/plone/app/theming/browser/controlpanel.pt
Repository: plone.app.theming
Branch: refs/heads/master
Date: 2016-09-16T23:39:00+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.theming@eea1435

Merge pull request #114 from plone/datakurre-update-theme

Add update button to theming control panel

Files changed:
M CHANGES.rst
M src/plone/app/theming/browser/controlpanel.pt
mister-roboto pushed a commit that referenced this pull request Jan 13, 2017
@gforcada
[fc] Repository: plone.app.layout
45ea8c6 
Branch: refs/heads/2.3.x
Date: 2017-01-13T14:58:42+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.layout@15156a4

Fix error in viewlet when related dexterity item has been deleted.

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/content.py
M plone/app/layout/viewlets/tests/test_content.py
Repository: plone.app.layout
Branch: refs/heads/2.3.x
Date: 2017-01-13T20:41:23+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.layout@3f9516a

Merge pull request #114 from plone/fix-deleted-related-dexterity-item-23

Fix error in viewlet when related dexterity item has been deleted. [2.3.x]

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/content.py
M plone/app/layout/viewlets/tests/test_content.py
mister-roboto pushed a commit that referenced this pull request Apr 12, 2017
@jensens
[fc] Repository: plone.app.upgrade
8c97a27 
Branch: refs/heads/master
Date: 2017-04-11T16:21:55+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.upgrade@21ff333

Add Plone 5.1 beta 4 upgrade profile.

Files changed:
A plone/app/upgrade/v51/profiles/to_beta4/registry.xml
M CHANGES.rst
M plone/app/upgrade/v51/configure.zcml
M plone/app/upgrade/v51/profiles.zcml
Repository: plone.app.upgrade
Branch: refs/heads/master
Date: 2017-04-12T13:11:31+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@c47b942

Merge pull request #114 from plone/thet-51beta4

Add Plone 5.1 beta 4 upgrade profile.

Files changed:
A plone/app/upgrade/v51/profiles/to_beta4/registry.xml
M CHANGES.rst
M plone/app/upgrade/v51/configure.zcml
M plone/app/upgrade/v51/profiles.zcml
mister-roboto pushed a commit that referenced this pull request Apr 12, 2017
@jensens
[fc] Repository: plone.app.upgrade
47ae01c 
Branch: refs/heads/master
Date: 2017-04-11T16:21:55+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.upgrade@21ff333

Add Plone 5.1 beta 4 upgrade profile.

Files changed:
A plone/app/upgrade/v51/profiles/to_beta4/registry.xml
M CHANGES.rst
M plone/app/upgrade/v51/configure.zcml
M plone/app/upgrade/v51/profiles.zcml
Repository: plone.app.upgrade
Branch: refs/heads/master
Date: 2017-04-12T13:11:31+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@c47b942

Merge pull request #114 from plone/thet-51beta4

Add Plone 5.1 beta 4 upgrade profile.

Files changed:
A plone/app/upgrade/v51/profiles/to_beta4/registry.xml
M CHANGES.rst
M plone/app/upgrade/v51/configure.zcml
M plone/app/upgrade/v51/profiles.zcml
mister-roboto pushed a commit that referenced this pull request Jun 14, 2018
@jensens
[fc] Repository: plone.app.portlets
bf67a0b 
Branch: refs/heads/master
Date: 2018-06-14T16:37:41+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.portlets@c9f4492

make work with merged plone.login

Files changed:
M CHANGES.rst
M plone/app/portlets/tests/testMemberDashboard.rst
Repository: plone.app.portlets

Branch: refs/heads/master
Date: 2018-06-14T17:54:31+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.portlets@183984f

Merge pull request #114 from plone/merge-plone-login

make work with merged plone.login

Files changed:
M CHANGES.rst
M plone/app/portlets/tests/testMemberDashboard.rst
mister-roboto pushed a commit that referenced this pull request Oct 2, 2019
@agitator
[fc] Repository: plone.dexterity
2b78117 
Branch: refs/heads/master
Date: 2019-10-01T16:34:39+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.dexterity@5547ef2

speedup schema cache by avoiding providedBy call if not necessary

Files changed:
A news/113.bugfix
M plone/dexterity/schema.py
Repository: plone.dexterity

Branch: refs/heads/master
Date: 2019-10-01T16:34:39+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.dexterity@9ed4625

fix travis to test 5.2

Files changed:
M .travis.yml
Repository: plone.dexterity

Branch: refs/heads/master
Date: 2019-10-01T16:34:39+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.dexterity@3403c8a

queryUtility is expensive, cache the fti on the request

Files changed:
M plone/dexterity/schema.py
M setup.py
Repository: plone.dexterity

Branch: refs/heads/master
Date: 2019-10-01T16:34:39+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.dexterity@87f1db8

fix tests deprecation warnings

Files changed:
M plone/dexterity/tests/test_fti.py
Repository: plone.dexterity

Branch: refs/heads/master
Date: 2019-10-01T16:34:39+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.dexterity@290b740

on clear, clear also fti cache

Files changed:
M plone/dexterity/schema.py
Repository: plone.dexterity

Branch: refs/heads/master
Date: 2019-10-02T08:36:06+02:00
Author: agitator (agitator) <agitator@users.noreply.github.com>
Commit: plone/plone.dexterity@768bc02

Merge pull request #114 from plone/jensens-performance-schema-cache-pure

Performance: Schema cache speedup.

Files changed:
A news/113.bugfix
M .travis.yml
M plone/dexterity/schema.py
M plone/dexterity/tests/test_fti.py
M setup.py
mister-roboto pushed a commit that referenced this pull request Nov 14, 2019
@thet
[fc] Repository: plone.app.robotframework
3c14f08 
Branch: refs/heads/master
Date: 2019-11-13T13:35:35Z
Author: Cillian de Roiste (cillianderoiste) <deroiste@syslab.com>
Commit: plone/plone.app.robotframework@a7a4d1d

Fix the Debug keyword

Fixes #114

Files changed:
A news/114.fixed
M src/plone/app/robotframework/keywords.robot
Repository: plone.app.robotframework

Branch: refs/heads/master
Date: 2019-11-14T13:00:49Z
Author: Cillian de Roiste (cillianderoiste) <deroiste@syslab.com>
Commit: plone/plone.app.robotframework@116ad14

Debug keyword: fix fallbacks

Files changed:
M src/plone/app/robotframework/keywords.robot
Repository: plone.app.robotframework

Branch: refs/heads/master
Date: 2019-11-14T23:53:11+01:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.robotframework@f79eead

Merge pull request #115 from plone/fix-debug-keyword

Fix the Debug keyword

Files changed:
A news/114.fixed
M src/plone/app/robotframework/keywords.robot
mister-roboto pushed a commit that referenced this pull request Dec 20, 2020
@tisto
[fc] Repository: plone.rest
0825d45 
Branch: refs/heads/master
Date: 2020-12-20T13:28:01+01:00
Author: Timo Stollenwerk (tisto) <tisto@users.noreply.github.com>
Commit: plone/plone.rest@14637bb

Gh actions (#114)

* make update

* Pin httpie to last py2 compatible version

* Fix Plone 5.2 buildout with version pins.

* Fix p 5.2 buildout

* Properly pin httpie

* make update

* make update

* Remove httpie

* Add gh actions

* black

* pin check-manifest

* pin check-manifest

* pin urllib3

* Exclude 3.7 with plone 5.1

* Pin idna

* Remove Travis

Files changed:
A .github/workflows/ci.yml
A ci.cfg
M Makefile
M README.rst
M base.cfg
M plone-4.3.x.cfg
M plone-5.1.x.cfg
M plone-5.2.x.cfg
M requirements.txt
M src/plone/rest/cors.py
M src/plone/rest/errors.py
M src/plone/rest/events.py
M src/plone/rest/interfaces.py
M src/plone/rest/negotiation.py
M src/plone/rest/patches.py
M src/plone/rest/traverse.py
M src/plone/rest/zcml.py
M versions.cfg
D .travis.yml
mister-roboto pushed a commit that referenced this pull request Jul 11, 2022
@petschki
[fc] Repository: plone.app.querystring
278b4f3 
Branch: refs/heads/master
Date: 2022-07-11T08:07:33+02:00
Author: Peter Mathis (petschki) <petschki@users.noreply.github.com>
Commit: plone/plone.app.querystring@c8bc778

Revert "Fixes #111 for master and make it Plone 6 only"

Files changed:
M plone/app/querystring/querybuilder.py
M plone/app/querystring/tests/testQueryBuilder.py
M setup.py
D news/111.bugfix
Repository: plone.app.querystring

Branch: refs/heads/master
Date: 2022-07-11T08:08:12+02:00
Author: Peter Mathis (petschki) <petschki@users.noreply.github.com>
Commit: plone/plone.app.querystring@47c5c8f

Merge pull request #114 from plone/revert-113-erral-issue-111-master

Revert "Fixes #111 for master and make it Plone 6 only"

Files changed:
M plone/app/querystring/querybuilder.py
M plone/app/querystring/tests/testQueryBuilder.py
M setup.py
D news/111.bugfix
mister-roboto pushed a commit that referenced this pull request Oct 31, 2022
@jensens
[fc] Repository: plone.app.users
bf9bae9 
Branch: refs/heads/master
Date: 2022-10-25T13:28:49+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.users@055767d

Add regression tests for issue 76: user info appears empty.

Actually, with the current code, test_regression_76_user_information fails and test_regression_76_personal_information passes.
With manual testing in a site, they both fail.

Files changed:
M plone/app/users/tests/test_schema_types.py
Repository: plone.app.users

Branch: refs/heads/master
Date: 2022-10-25T13:41:22+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.users@3b9c508

For user schemas use a volatile cache on the request instead of on the portal.

This prevents seeing an empty user profile when you have custom user schemas.
This fixes plone/plone.app.users#76.

Files changed:
A news/76.bugfix
M plone/app/users/browser/account.py
M plone/app/users/browser/register.py
M plone/app/users/browser/userdatapanel.py
Repository: plone.app.users

Branch: refs/heads/master
Date: 2022-10-31T15:38:38+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.users@e32d33a

Merge pull request #114 from plone/maurits-issue-76-empty-user-profile

For user schemas use a volatile cache on the request instead of on the portal.

Files changed:
A news/76.bugfix
M plone/app/users/browser/account.py
M plone/app/users/browser/register.py
M plone/app/users/browser/userdatapanel.py
M plone/app/users/tests/test_schema_types.py
mister-roboto pushed a commit that referenced this pull request Feb 19, 2024
@pbauer
[fc] Repository: plone.app.iterate
dcbe137 
Branch: refs/heads/master
Date: 2024-02-19T14:15:01+01:00
Author: Kim Paulissen (spereverde) <spereverde@gmail.com>
Commit: plone/plone.app.iterate@f37417f

Plone6 styles (#114)

* Adapt viewlet styles to Plone 6

* add button css vclasses

* add plone.app.layout as dependency

* wrap messages in container

* zpretty

---------

Co-authored-by: Philip Bauer &lt;bauer@starzel.de&gt;

Files changed:
A news/95.news
M plone/app/iterate/browser/cancel.pt
M plone/app/iterate/browser/checkin.pt
M plone/app/iterate/browser/checkout.pt
M plone/app/iterate/browser/info.py
M plone/app/iterate/browser/info_baseline.pt
M plone/app/iterate/browser/info_checkout.pt
M setup.py
mister-roboto pushed a commit that referenced this pull request Feb 19, 2024
@pbauer
[fc] Repository: plone.app.iterate
e8e506b 
Branch: refs/heads/master
Date: 2024-02-19T14:15:01+01:00
Author: Kim Paulissen (spereverde) <spereverde@gmail.com>
Commit: plone/plone.app.iterate@f37417f

Plone6 styles (#114)

* Adapt viewlet styles to Plone 6

* add button css vclasses

* add plone.app.layout as dependency

* wrap messages in container

* zpretty

---------

Co-authored-by: Philip Bauer &lt;bauer@starzel.de&gt;

Files changed:
A news/95.news
M plone/app/iterate/browser/cancel.pt
M plone/app/iterate/browser/checkin.pt
M plone/app/iterate/browser/checkout.pt
M plone/app/iterate/browser/info.py
M plone/app/iterate/browser/info_baseline.pt
M plone/app/iterate/browser/info_checkout.pt
M setup.py
mister-roboto pushed a commit that referenced this pull request May 7, 2024
@jensens
[fc] Repository: plone.protect
82252a4 
Branch: refs/heads/master
Date: 2024-05-06T19:54:24Z
Author: pre-commit-ci[bot] (pre-commit-ci[bot]) <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Commit: plone/plone.protect@282b708

[pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/psf/black: 24.3.0 → 24.4.2](psf/black@24.3.0...24.4.2)
- [github.com/collective/i18ndude: 6.1.0 → 6.2.0](collective/i18ndude@6.1.0...6.2.0)

Files changed:
M .pre-commit-config.yaml
Repository: plone.protect

Branch: refs/heads/master
Date: 2024-05-07T21:25:28+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.protect@03af9a4

Merge pull request #114 from plone/pre-commit-ci-update-config

[pre-commit.ci] pre-commit autoupdate

Files changed:
M .pre-commit-config.yaml
mister-roboto pushed a commit that referenced this pull request May 7, 2024
@jensens
[fc] Repository: plone.protect
c119fd4 
Branch: refs/heads/master
Date: 2024-05-06T19:54:24Z
Author: pre-commit-ci[bot] (pre-commit-ci[bot]) <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Commit: plone/plone.protect@282b708

[pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/psf/black: 24.3.0 → 24.4.2](psf/black@24.3.0...24.4.2)
- [github.com/collective/i18ndude: 6.1.0 → 6.2.0](collective/i18ndude@6.1.0...6.2.0)

Files changed:
M .pre-commit-config.yaml
Repository: plone.protect

Branch: refs/heads/master
Date: 2024-05-07T21:25:28+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.protect@03af9a4

Merge pull request #114 from plone/pre-commit-ci-update-config

[pre-commit.ci] pre-commit autoupdate

Files changed:
M .pre-commit-config.yaml
mister-roboto pushed a commit that referenced this pull request Jun 4, 2024
@jensens
[fc] Repository: plone.schemaeditor
9cecd74 
Branch: refs/heads/master
Date: 2024-06-03T20:01:14Z
Author: pre-commit-ci[bot] (pre-commit-ci[bot]) <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Commit: plone/plone.schemaeditor@9783674

[pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0)

Files changed:
M .pre-commit-config.yaml
Repository: plone.schemaeditor

Branch: refs/heads/master
Date: 2024-06-04T03:23:19-04:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.schemaeditor@9248757

Merge pull request #114 from plone/pre-commit-ci-update-config

[pre-commit.ci] pre-commit autoupdate

Files changed:
M .pre-commit-config.yaml
mister-roboto pushed a commit that referenced this pull request Jun 4, 2024
@jensens
[fc] Repository: plone.schemaeditor
ec2a357 
Branch: refs/heads/master
Date: 2024-06-03T20:01:14Z
Author: pre-commit-ci[bot] (pre-commit-ci[bot]) <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Commit: plone/plone.schemaeditor@9783674

[pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0)

Files changed:
M .pre-commit-config.yaml
Repository: plone.schemaeditor

Branch: refs/heads/master
Date: 2024-06-04T03:23:19-04:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.schemaeditor@9248757

Merge pull request #114 from plone/pre-commit-ci-update-config

[pre-commit.ci] pre-commit autoupdate

Files changed:
M .pre-commit-config.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
23 status: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauritsvanrees @pbauer