Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code QA package versions #350

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Update code QA package versions #350

merged 1 commit into from
Jun 28, 2017

Conversation

thet
Copy link
Member

@thet thet commented Jun 28, 2017

/cc @gforcada

seems an updated version of flake8-isort among others need those updated versions.
not an issue with buildout.coredev 5.1, as these version pins aren't present there.

@thet thet requested a review from gforcada June 28, 2017 09:29
@gforcada
Copy link
Member

@thet I'm curious about who is using these version pins actually. At jenkins.plone.org we do run some QA checks with flake8,but rather than tests.cfg they use experimental/qa.cfg...

gforcada
gforcada approved these changes Jun 28, 2017
View reviewed changes
Copy link
Member

@gforcada gforcada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, but as noted on the other comment, I'm not sure who is using these version pins, so is hard to say what can break

@thet
Copy link
Member Author

thet commented Jun 28, 2017

@gforcada tnx for the review, I'll merge.

In 5.1 these version pins are removed.
Anyway, I'd prefer to have them in versions.cfg - I even did not know that there are version pins in test.cfg...

@thet thet merged commit 9be1293 into 5.0 Jun 28, 2017
@thet thet deleted the thet-updca branch June 28, 2017 19:31
mister-roboto pushed a commit that referenced this pull request Oct 30, 2019
@jensens
[fc] Repository: plone.app.multilingual
7d0cbd9 
Branch: refs/heads/master
Date: 2019-05-14T10:52:46+02:00
Author: Joni Orponen (Rotonen) <joni.orponen@gmail.com>
Commit: plone/plone.app.multilingual@9a335e0

Use the shared test setup and test teardown keywords in Robot tests.

Files changed:
A news/349.bugfix
M src/plone/app/multilingual/tests/robot/test_add_translation.robot
M src/plone/app/multilingual/tests/robot/test_schemaeditor.robot
M src/plone/app/multilingual/tests/robot/test_translate_content.robot
Repository: plone.app.multilingual

Branch: refs/heads/master
Date: 2019-10-30T11:13:06+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.multilingual@95be612

Merge pull request #350 from plone/roto-window-resize-huge

Default to a 4K x 4K browser window in Robot tests

Files changed:
A news/349.bugfix
M src/plone/app/multilingual/tests/robot/test_add_translation.robot
M src/plone/app/multilingual/tests/robot/test_schemaeditor.robot
M src/plone/app/multilingual/tests/robot/test_translate_content.robot
mister-roboto pushed a commit that referenced this pull request May 9, 2022
@mauritsvanrees
[fc] Repository: plone.app.dexterity
157ba50 
Branch: refs/heads/master
Date: 2022-05-09T15:32:39+02:00
Author: Peter Holzer (agitator) <peter.holzer@agitator.com>
Commit: plone/plone.app.dexterity@9ff07c6

Don't acquire .language from portal root.

Files changed:
M plone/app/dexterity/behaviors/metadata.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2022-05-09T15:36:08+02:00
Author: Peter Holzer (agitator) <peter.holzer@agitator.com>
Commit: plone/plone.app.dexterity@3e57847

add news

Files changed:
A news/350.bugfix
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2022-05-09T18:37:12+02:00
Author: Peter Holzer (agitator) <peter.holzer@agitator.com>
Commit: plone/plone.app.dexterity@e0cd920

use getattr

Files changed:
M plone/app/dexterity/behaviors/metadata.py
Repository: plone.app.dexterity

Branch: refs/heads/master
Date: 2022-05-09T21:42:12+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.dexterity@692d932

Merge pull request #350 from plone/defaultlanglookup

[6.0] Don't acquire .language from portal root.

Files changed:
A news/350.bugfix
M plone/app/dexterity/behaviors/metadata.py
mister-roboto pushed a commit that referenced this pull request Jun 27, 2023
@mauritsvanrees
[fc] Repository: plone.app.layout
c546a5e 
Branch: refs/heads/master
Date: 2023-06-27T16:29:25+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.layout@2558772

Fix markup in `contentviews.pt` after zpretty

Files changed:
M plone/app/layout/viewlets/contentviews.pt
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2023-06-27T16:30:48+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.layout@a9bf889

changenote

Files changed:
A news/350.bugfix
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2023-06-28T00:02:45+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.layout@6b6590b

Merge pull request #350 from plone/petschki-contentviews-fix

Fix markup in `contentviews.pt` after zpretty

Files changed:
A news/350.bugfix
M plone/app/layout/viewlets/contentviews.pt
mister-roboto pushed a commit that referenced this pull request Jun 27, 2023
@mauritsvanrees
[fc] Repository: plone.app.layout
aee0bd4 
Branch: refs/heads/master
Date: 2023-06-27T16:29:25+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.layout@2558772

Fix markup in `contentviews.pt` after zpretty

Files changed:
M plone/app/layout/viewlets/contentviews.pt
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2023-06-27T16:30:48+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.layout@a9bf889

changenote

Files changed:
A news/350.bugfix
Repository: plone.app.layout

Branch: refs/heads/master
Date: 2023-06-28T00:02:45+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.layout@6b6590b

Merge pull request #350 from plone/petschki-contentviews-fix

Fix markup in `contentviews.pt` after zpretty

Files changed:
A news/350.bugfix
M plone/app/layout/viewlets/contentviews.pt
mister-roboto pushed a commit that referenced this pull request Oct 24, 2023
@petschki
[fc] Repository: plonetheme.barceloneta
fa23399 
Branch: refs/heads/master
Date: 2023-10-23T10:08:19+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plonetheme.barceloneta@833974a

Update TinyMCE -&gt; 6

Files changed:
M package.json
Repository: plonetheme.barceloneta

Branch: refs/heads/master
Date: 2023-10-23T10:08:25+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plonetheme.barceloneta@ddc84a9

npm install

Files changed:
M package-lock.json
Repository: plonetheme.barceloneta

Branch: refs/heads/master
Date: 2023-10-23T10:08:29+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plonetheme.barceloneta@af1800a

compile

Files changed:
M plonetheme/barceloneta/theme/tinymce/tinymce-ui-content.css
Repository: plonetheme.barceloneta

Branch: refs/heads/master
Date: 2023-10-23T10:10:23+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plonetheme.barceloneta@7d857dd

changenote

Files changed:
A news/350.feature
Repository: plonetheme.barceloneta

Branch: refs/heads/master
Date: 2023-10-24T12:34:42+02:00
Author: Peter Mathis (petschki) <petschki@users.noreply.github.com>
Commit: plone/plonetheme.barceloneta@d1a39c9

Merge pull request #350 from plone/petschki-tinymce6

TinyMCE 6 style updates

Files changed:
A news/350.feature
M package-lock.json
M package.json
M plonetheme/barceloneta/theme/tinymce/tinymce-ui-content.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforcada gforcada gforcada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thet @gforcada