Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Install Text.rst #62

Merged
merged 1 commit into from
Feb 3, 2015
Merged

Update Install Text.rst #62

merged 1 commit into from
Feb 3, 2015

Conversation

Killthebug
Copy link
Contributor

In the install Instructions, it is wrongly written as
buildout boostrap
Whereas it should be:
buildout bootstrap.

In the install Instructions, it is wrongly written as 
buildout boostrap
Whereas it should be:
buildout bootstrap.
vangheem added a commit that referenced this pull request Feb 3, 2015
@vangheem vangheem merged commit 48f5ed5 into plone:5.0 Feb 3, 2015
gforcada added a commit that referenced this pull request Feb 25, 2015
Branch: refs/heads/master
Date: 2015-02-16T11:28:49+01:00
Author: Gil Forcada (gforcada) <gforcada@gnome.org>
Commit: plone/plone.app.discussion@535af3a

Count acquisition wrapped comments

If the View permission is not set directly on the workflow,
but instead is left to be acquired,
total_comments will always return 0.

Files changed:
M plone/app/discussion/conversation.py

diff --git a/plone/app/discussion/conversation.py b/plone/app/discussion/conversation.py
index 540bf97..e73546a 100644
--- a/plone/app/discussion/conversation.py
+++ b/plone/app/discussion/conversation.py
@@ -80,7 +80,7 @@ def enabled(self):
     @Property
     def total_comments(self):
         public_comments = [
-            x for x in self._comments.values()
+            x for x in self.values()
             if user_nobody.has_permission('View', x)
         ]
         return len(public_comments)


Repository: plone.app.discussion
Branch: refs/heads/master
Date: 2015-02-16T11:31:47+01:00
Author: Gil Forcada (gforcada) <gforcada@gnome.org>
Commit: plone/plone.app.discussion@d5b5b1c

Fix total_comments indexer

"@Property removes Acquisition wrappers from 'self'.
I don't remember why exactly (some implementation detail of Acquisition),
but it's a fact of life."

Quote from @davisagli on
plone/plone.app.discussion#58

In short: removing the @Property from total_comments fix the problem.

Files changed:
M plone/app/discussion/catalog.py
M plone/app/discussion/conversation.py

diff --git a/plone/app/discussion/catalog.py b/plone/app/discussion/catalog.py
index 12382df..5034928 100644
--- a/plone/app/discussion/catalog.py
+++ b/plone/app/discussion/catalog.py
@@ -33,7 +33,7 @@ def total_comments(object):
     if object.meta_type != 'Discussion Item':
         try:
             conversation = IConversation(object)
-            return conversation.total_comments
+            return conversation.total_comments()
         except TypeError:  # pragma: no cover
             # The item is contentish but nobody
             # implemented an adapter for it
diff --git a/plone/app/discussion/conversation.py b/plone/app/discussion/conversation.py
index e73546a..01d3182 100644
--- a/plone/app/discussion/conversation.py
+++ b/plone/app/discussion/conversation.py
@@ -77,7 +77,6 @@ def enabled(self):
         parent = aq_inner(self.__parent__)
         return parent.restrictedTraverse('@@conversation_view').enabled()
 
-    @Property
     def total_comments(self):
         public_comments = [
             x for x in self.values()


Repository: plone.app.discussion
Branch: refs/heads/master
Date: 2015-02-16T16:35:43+01:00
Author: Gil Forcada (gforcada) <gforcada@gnome.org>
Commit: plone/plone.app.discussion@4ea41ab

Fix tests

Files changed:
M plone/app/discussion/tests/test_comment.py
M plone/app/discussion/tests/test_conversation.py

diff --git a/plone/app/discussion/tests/test_comment.py b/plone/app/discussion/tests/test_comment.py
index 5277f5f..467680b 100644
--- a/plone/app/discussion/tests/test_comment.py
+++ b/plone/app/discussion/tests/test_comment.py
@@ -433,7 +433,7 @@ def test_delete_comment(self):
         self.assertEqual(len(replies), 0)
 
         # Make sure the first comment is still in the conversation
-        self.assertEqual(conversation.total_comments, 1)
+        self.assertEqual(conversation.total_comments(), 1)
 
     def test_traversal(self):
         # Create a nested structure of comment replies and check the traversal
diff --git a/plone/app/discussion/tests/test_conversation.py b/plone/app/discussion/tests/test_conversation.py
index 8400b05..b990a54 100644
--- a/plone/app/discussion/tests/test_conversation.py
+++ b/plone/app/discussion/tests/test_conversation.py
@@ -78,7 +78,7 @@ def test_add_comment(self):
         self.assertEqual(new_id, comment.comment_id)
         self.assertEqual(len(list(conversation.getComments())), 1)
         self.assertEqual(len(tuple(conversation.getThreads())), 1)
-        self.assertEqual(conversation.total_comments, 1)
+        self.assertEqual(conversation.total_comments(), 1)
         self.assertTrue(
             conversation.last_comment_date - datetime.utcnow() <
             timedelta(seconds=1)
@@ -91,7 +91,7 @@ def test_private_comment(self):
         comment.author_username = "nobody"
         conversation.addComment(comment)
         comment.manage_permission("View", roles=tuple())
-        self.assertEqual(0, conversation.total_comments)
+        self.assertEqual(0, conversation.total_comments())
         self.assertEqual(None, conversation.last_comment_date)
         self.assertEqual(["nobody"], list(conversation.commentators))
         self.assertEqual([], list(conversation.public_commentators))
@@ -112,7 +112,7 @@ def test_delete_comment(self):
         # make sure the comment has been added
         self.assertEqual(len(list(conversation.getComments())), 1)
         self.assertEqual(len(tuple(conversation.getThreads())), 1)
-        self.assertEqual(conversation.total_comments, 1)
+        self.assertEqual(conversation.total_comments(), 1)
 
         # delete the comment we just created
         del conversation[new_id]
@@ -120,7 +120,7 @@ def test_delete_comment(self):
         # make sure there is no comment left in the conversation
         self.assertEqual(len(list(conversation.getComments())), 0)
         self.assertEqual(len(tuple(conversation.getThreads())), 0)
-        self.assertEqual(conversation.total_comments, 0)
+        self.assertEqual(conversation.total_comments(), 0)
 
     def test_delete_recursive(self):
         # Create a conversation. In this case we doesn't assign it to an
@@ -195,7 +195,7 @@ def test_delete_comment_when_content_object_is_deleted(self):
         # Make sure the comment has been deleted as well
         self.assertEqual(len(list(conversation.getComments())), 0)
         self.assertEqual(len(tuple(conversation.getThreads())), 0)
-        self.assertEqual(conversation.total_comments, 0)
+        self.assertEqual(conversation.total_comments(), 0)
 
     def test_comments_enabled_on_doc_in_subfolder(self):
         typetool = self.portal.portal_types
@@ -422,7 +422,7 @@ def test_total_comments(self):
         conversation.addComment(comment2)
         conversation.addComment(comment3)
 
-        self.assertEqual(conversation.total_comments, 3)
+        self.assertEqual(conversation.total_comments(), 3)
 
     def test_commentators(self):
         # add and remove a few comments to make sure the commentators
@@ -432,7 +432,7 @@ def test_commentators(self):
         # object, as we just want to check the Conversation object API.
         conversation = IConversation(self.portal.doc1)
 
-        self.assertEqual(conversation.total_comments, 0)
+        self.assertEqual(conversation.total_comments(), 0)
 
         # Add a four comments from three different users
         # Note: in real life, we always create
@@ -459,7 +459,7 @@ def test_commentators(self):
         new_comment4_id = conversation.addComment(comment4)
 
         # check if all commentators are in the commentators list
-        self.assertEqual(conversation.total_comments, 4)
+        self.assertEqual(conversation.total_comments(), 4)
         self.assertTrue('Jim' in conversation.commentators)
         self.assertTrue('Joe' in conversation.commentators)
         self.assertTrue('Jack' in conversation.commentators)
@@ -472,7 +472,7 @@ def test_commentators(self):
         self.assertTrue('Jim' in conversation.commentators)
         self.assertTrue('Joe' in conversation.commentators)
         self.assertTrue('Jack' in conversation.commentators)
-        self.assertEqual(conversation.total_comments, 3)
+        self.assertEqual(conversation.total_comments(), 3)
 
         # remove the second comment from Jack
         del conversation[new_comment4_id]
@@ -481,7 +481,7 @@ def test_commentators(self):
         self.assertTrue('Jim' in conversation.commentators)
         self.assertTrue('Joe' in conversation.commentators)
         self.assertFalse('Jack' in conversation.commentators)
-        self.assertEqual(conversation.total_comments, 2)
+        self.assertEqual(conversation.total_comments(), 2)
 
     def test_last_comment_date(self):
         # add and remove some comments and check if last_comment_date
@@ -868,7 +868,7 @@ def test_dict_api(self):
 
         # check that replies only contain the direct comments
         # and no comments deeper than 1
-        self.assertEqual(conversation.total_comments, 6)
+        self.assertEqual(conversation.total_comments(), 6)
         self.assertEqual(len(replies), 2)
         self.assertEqual(len(replies_to_comment1), 2)
         self.assertEqual(len(replies_to_comment1_1), 1)


Repository: plone.app.discussion
Branch: refs/heads/master
Date: 2015-02-25T21:47:08+01:00
Author: Gil Forcada (gforcada) <gforcada@gnome.org>
Commit: plone/plone.app.discussion@2a42309

Add note on CHANGES.rst

Files changed:
M CHANGES.rst

diff --git a/CHANGES.rst b/CHANGES.rst
index b0bbbb8..5b8ca9f 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -20,6 +20,10 @@ Changelog
 - Read mail settings from new (Plone 5) registry.
   [timo]
 
+- Remove @Property from Conversation.total_comments as @Property and
+  Acquisition don't play well together.
+  [gforcada]
+
 
 2.3.3 (2014-10-23)
 ------------------


Repository: plone.app.discussion
Branch: refs/heads/master
Date: 2015-02-25T21:47:42+01:00
Author: Gil Forcada (gforcada) <gforcada@gnome.org>
Commit: plone/plone.app.discussion@2faf69b

Merge pull request #62 from plone/acquisition-total-comments-4

Acquisition total comments

Files changed:
M CHANGES.rst
M plone/app/discussion/catalog.py
M plone/app/discussion/conversation.py
M plone/app/discussion/tests/test_comment.py
M plone/app/discussion/tests/test_conversation.py

diff --git a/CHANGES.rst b/CHANGES.rst
index b0bbbb8..5b8ca9f 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -20,6 +20,10 @@ Changelog
 - Read mail settings from new (Plone 5) registry.
   [timo]
 
+- Remove @Property from Conversation.total_comments as @Property and
+  Acquisition don't play well together.
+  [gforcada]
+
 
 2.3.3 (2014-10-23)
 ------------------
diff --git a/plone/app/discussion/catalog.py b/plone/app/discussion/catalog.py
index 12382df..5034928 100644
--- a/plone/app/discussion/catalog.py
+++ b/plone/app/discussion/catalog.py
@@ -33,7 +33,7 @@ def total_comments(object):
     if object.meta_type != 'Discussion Item':
         try:
             conversation = IConversation(object)
-            return conversation.total_comments
+            return conversation.total_comments()
         except TypeError:  # pragma: no cover
             # The item is contentish but nobody
             # implemented an adapter for it
diff --git a/plone/app/discussion/conversation.py b/plone/app/discussion/conversation.py
index 540bf97..01d3182 100644
--- a/plone/app/discussion/conversation.py
+++ b/plone/app/discussion/conversation.py
@@ -77,10 +77,9 @@ def enabled(self):
         parent = aq_inner(self.__parent__)
         return parent.restrictedTraverse('@@conversation_view').enabled()
 
-    @Property
     def total_comments(self):
         public_comments = [
-            x for x in self._comments.values()
+            x for x in self.values()
             if user_nobody.has_permission('View', x)
         ]
         return len(public_comments)
diff --git a/plone/app/discussion/tests/test_comment.py b/plone/app/discussion/tests/test_comment.py
index 5277f5f..467680b 100644
--- a/plone/app/discussion/tests/test_comment.py
+++ b/plone/app/discussion/tests/test_comment.py
@@ -433,7 +433,7 @@ def test_delete_comment(self):
         self.assertEqual(len(replies), 0)
 
         # Make sure the first comment is still in the conversation
-        self.assertEqual(conversation.total_comments, 1)
+        self.assertEqual(conversation.total_comments(), 1)
 
     def test_traversal(self):
         # Create a nested structure of comment replies and check the traversal
diff --git a/plone/app/discussion/tests/test_conversation.py b/plone/app/discussion/tests/test_conversation.py
index 8400b05..b990a54 100644
--- a/plone/app/discussion/tests/test_conversation.py
+++ b/plone/app/discussion/tests/test_conversation.py
@@ -78,7 +78,7 @@ def test_add_comment(self):
         self.assertEqual(new_id, comment.comment_id)
         self.assertEqual(len(list(conversation.getComments())), 1)
         self.assertEqual(len(tuple(conversation.getThreads())), 1)
-        self.assertEqual(conversation.total_comments, 1)
+        self.assertEqual(conversation.total_comments(), 1)
         self.assertTrue(
             conversation.last_comment_date - datetime.utcnow() <
             timedelta(seconds=1)
@@ -91,7 +91,7 @@ def test_private_comment(self):
         comment.author_username = "nobody"
         conversation.addComment(comment)
         comment.manage_permission("View", roles=tuple())
-        self.assertEqual(0, conversation.total_comments)
+        self.assertEqual(0, conversation.total_comments())
         self.assertEqual(None, conversation.last_comment_date)
         self.assertEqual(["nobody"], list(conversation.commentators))
         self.assertEqual([], list(conversation.public_commentators))
@@ -112,7 +112,7 @@ def test_delete_comment(self):
         # make sure the comment has been added
         self.assertEqual(len(list(conversation.getComments())), 1)
         self.assertEqual(len(tuple(conversation.getThreads())), 1)
-        self.assertEqual(conversation.total_comments, 1)
+        self.assertEqual(conversation.total_comments(), 1)
 
         # delete the comment we just created
         del conversation[new_id]
@@ -120,7 +120,7 @@ def test_delete_comment(self):
         # make sure there is no comment left in the conversation
         self.assertEqual(len(list(conversation.getComments())), 0)
         self.assertEqual(len(tuple(conversation.getThreads())), 0)
-        self.assertEqual(conversation.total_comments, 0)
+        self.assertEqual(conversation.total_comments(), 0)
 
     def test_delete_recursive(self):
         # Create a conversation. In this case we doesn't assign it to an
@@ -195,7 +195,7 @@ def test_delete_comment_when_content_object_is_deleted(self):
         # Make sure the comment has been deleted as well
         self.assertEqual(len(list(conversation.getComments())), 0)
         self.assertEqual(len(tuple(conversation.getThreads())), 0)
-        self.assertEqual(conversation.total_comments, 0)
+        self.assertEqual(conversation.total_comments(), 0)
 
     def test_comments_enabled_on_doc_in_subfolder(self):
         typetool = self.portal.portal_types
@@ -422,7 +422,7 @@ def test_total_comments(self):
         conversation.addComment(comment2)
         conversation.addComment(comment3)
 
-        self.assertEqual(conversation.total_comments, 3)
+        self.assertEqual(conversation.total_comments(), 3)
 
     def test_commentators(self):
         # add and remove a few comments to make sure the commentators
@@ -432,7 +432,7 @@ def test_commentators(self):
         # object, as we just want to check the Conversation object API.
         conversation = IConversation(self.portal.doc1)
 
-        self.assertEqual(conversation.total_comments, 0)
+        self.assertEqual(conversation.total_comments(), 0)
 
         # Add a four comments from three different users
         # Note: in real life, we always create
@@ -459,7 +459,7 @@ def test_commentators(self):
         new_comment4_id = conversation.addComment(comment4)
 
         # check if all commentators are in the commentators list
-        self.assertEqual(conversation.total_comments, 4)
+        self.assertEqual(conversation.total_comments(), 4)
         self.assertTrue('Jim' in conversation.commentators)
         self.assertTrue('Joe' in conversation.commentators)
         self.assertTrue('Jack' in conversation.commentators)
@@ -472,7 +472,7 @@ def test_commentators(self):
         self.assertTrue('Jim' in conversation.commentators)
         self.assertTrue('Joe' in conversation.commentators)
         self.assertTrue('Jack' in conversation.commentators)
-        self.assertEqual(conversation.total_comments, 3)
+        self.assertEqual(conversation.total_comments(), 3)
 
         # remove the second comment from Jack
         del conversation[new_comment4_id]
@@ -481,7 +481,7 @@ def test_commentators(self):
         self.assertTrue('Jim' in conversation.commentators)
         self.assertTrue('Joe' in conversation.commentators)
         self.assertFalse('Jack' in conversation.commentators)
-        self.assertEqual(conversation.total_comments, 2)
+        self.assertEqual(conversation.total_comments(), 2)
 
     def test_last_comment_date(self):
         # add and remove some comments and check if last_comment_date
@@ -868,7 +868,7 @@ def test_dict_api(self):
 
         # check that replies only contain the direct comments
         # and no comments deeper than 1
-        self.assertEqual(conversation.total_comments, 6)
+        self.assertEqual(conversation.total_comments(), 6)
         self.assertEqual(len(replies), 2)
         self.assertEqual(len(replies_to_comment1), 2)
         self.assertEqual(len(replies_to_comment1_1), 1)
vangheem added a commit that referenced this pull request Jul 3, 2015
Branch: refs/heads/master
Date: 2015-07-02T11:08:38+03:00
Author: Volodymyr Maksymiv (vmaksymiv) <vmaksymiv@quintagroup.com>
Commit: plone/plone.app.theming@81ed8eb

added secondary theme for test reasons

Files changed:
A src/plone/app/theming/tests/secondary-theme/manifest.cfg
A src/plone/app/theming/tests/secondary-theme/rules.xml
M src/plone/app/theming/tests/configure.zcml
Repository: plone.app.theming
Branch: refs/heads/master
Date: 2015-07-02T11:08:46+03:00
Author: Volodymyr Maksymiv (vmaksymiv) <vmaksymiv@quintagroup.com>
Commit: plone/plone.app.theming@e8a868a

added createThemeFromTemplate test

Files changed:
M src/plone/app/theming/tests/test_utils.py
Repository: plone.app.theming
Branch: refs/heads/master
Date: 2015-07-02T12:09:26+03:00
Author: Volodymyr Maksymiv (vmaksymiv) <vmaksymiv@quintagroup.com>
Commit: plone/plone.app.theming@e986f22

fixed configuration of copied themes

Files changed:
M src/plone/app/theming/utils.py
Repository: plone.app.theming
Branch: refs/heads/master
Date: 2015-07-02T15:21:04+03:00
Author: Volodymyr Maksymiv (vmaksymiv) <vmaksymiv@quintagroup.com>
Commit: plone/plone.app.theming@69f4344

updated changelog

Files changed:
M CHANGES.rst
Repository: plone.app.theming
Branch: refs/heads/master
Date: 2015-07-03T10:41:40-05:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.theming@037420e

Merge pull request #62 from vmaksymiv/master

Fix for copied theme configuration

Files changed:
A src/plone/app/theming/tests/secondary-theme/manifest.cfg
A src/plone/app/theming/tests/secondary-theme/rules.xml
M CHANGES.rst
M src/plone/app/theming/tests/configure.zcml
M src/plone/app/theming/tests/test_utils.py
M src/plone/app/theming/utils.py
vangheem added a commit that referenced this pull request Sep 19, 2015
Branch: refs/heads/master
Date: 2015-09-19T10:35:14-03:00
Author: Rodrigo Ferreira de Souza (rodfersou) <rodfersou@gmail.com>
Commit: plone/plone.app.layout@42ac72e

Respect @@site_controlpanel configuration to show publication date in document_byline

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/content.py
M plone/app/layout/viewlets/tests/test_content.py
Repository: plone.app.layout
Branch: refs/heads/master
Date: 2015-09-19T10:57:24-05:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.layout@dd1f14d

Merge pull request #62 from plone/issue_1037

Issue 1037 - Respect @@site_controlpanel configuration to show publication date in…

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/content.py
M plone/app/layout/viewlets/tests/test_content.py
vangheem added a commit that referenced this pull request Nov 22, 2015
Branch: refs/heads/master
Date: 2015-11-21T11:49:55-08:00
Author: David Glick (davisagli) <david@glicksoftware.com>
Commit: plone/plone.app.content@63ec896

make @@getsource work for autocomplete widget

(The autocomplete widget sends a text query rather than a JSON-encoded querystring query.)

This is needed to work for sources that implement a `search` method but not `search_catalog`,
such as the UsersSource in plone.app.vocabularies.

Files changed:
M CHANGES.rst
M plone/app/content/browser/vocabulary.py
M plone/app/content/tests/test_widgets.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2015-11-21T23:35:47-06:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.content@e55ed9a

Merge pull request #62 from plone/davisagli-fix-getSource

make @@getsource work for autocomplete widget

Files changed:
M CHANGES.rst
M plone/app/content/browser/vocabulary.py
M plone/app/content/tests/test_widgets.py
vangheem added a commit that referenced this pull request Nov 23, 2015
Branch: refs/heads/master
Date: 2015-11-22T22:11:02-06:00
Author: vangheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.portlets@34c899d

Add authenticator token to group portlet links

Files changed:
M CHANGES.rst
M plone/app/portlets/browser/templates/manage-group-dashboard.pt
M plone/app/portlets/browser/templates/manage-group.pt
Repository: plone.app.portlets
Branch: refs/heads/master
Date: 2015-11-22T23:22:05-06:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.portlets@c893298

Merge pull request #62 from plone/add-authenticator-to-group-portlet-links

Add authenticator token to group portlet links

Files changed:
M CHANGES.rst
M plone/app/portlets/browser/templates/manage-group-dashboard.pt
M plone/app/portlets/browser/templates/manage-group.pt
jensens added a commit that referenced this pull request Dec 4, 2015
Branch: refs/heads/master
Date: 2015-12-03T17:55:50+01:00
Author: Gagaro (Gagaro) <gagaro42@gmail.com>
Commit: plone/plone.app.upgrade@24de095

fix: update getIcon metadata only in to501

Files changed:
M plone/app/upgrade/v50/final.py
Repository: plone.app.upgrade
Branch: refs/heads/master
Date: 2015-12-04T15:26:56+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@c6bb01d

Merge pull request #62 from plone/fix-getIcon-to501

fix: update getIcon metadata only in to501

Files changed:
M plone/app/upgrade/v50/final.py
jensens added a commit that referenced this pull request Dec 4, 2015
Branch: refs/heads/master
Date: 2015-12-03T17:55:50+01:00
Author: Gagaro (Gagaro) <gagaro42@gmail.com>
Commit: plone/plone.app.upgrade@24de095

fix: update getIcon metadata only in to501

Files changed:
M plone/app/upgrade/v50/final.py
Repository: plone.app.upgrade
Branch: refs/heads/master
Date: 2015-12-04T15:26:56+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@c6bb01d

Merge pull request #62 from plone/fix-getIcon-to501

fix: update getIcon metadata only in to501

Files changed:
M plone/app/upgrade/v50/final.py
mister-roboto pushed a commit that referenced this pull request May 21, 2016
Branch: refs/heads/master
Date: 2016-05-18T02:03:41+02:00
Author: vangheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.querystring@73d142f

Add missing _referenceIs query parser

Files changed:
M CHANGES.rst
M plone/app/querystring/indexmodifiers/query_index_modifiers.py
M plone/app/querystring/queryparser.py
Repository: plone.app.querystring
Branch: refs/heads/master
Date: 2016-05-21T15:11:13+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.querystring@de66ea1

Merge pull request #62 from plone/missing-reference-is

Add missing _referenceIs query parser

Files changed:
M CHANGES.rst
M plone/app/querystring/indexmodifiers/query_index_modifiers.py
M plone/app/querystring/queryparser.py
mister-roboto pushed a commit that referenced this pull request May 21, 2016
Branch: refs/heads/master
Date: 2016-05-18T02:03:41+02:00
Author: vangheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.querystring@73d142f

Add missing _referenceIs query parser

Files changed:
M CHANGES.rst
M plone/app/querystring/indexmodifiers/query_index_modifiers.py
M plone/app/querystring/queryparser.py
Repository: plone.app.querystring
Branch: refs/heads/master
Date: 2016-05-21T15:11:13+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.querystring@de66ea1

Merge pull request #62 from plone/missing-reference-is

Add missing _referenceIs query parser

Files changed:
M CHANGES.rst
M plone/app/querystring/indexmodifiers/query_index_modifiers.py
M plone/app/querystring/queryparser.py
mister-roboto pushed a commit that referenced this pull request Sep 1, 2016
Branch: refs/heads/master
Date: 2016-09-01T09:40:22+02:00
Author: Stephan Klinger (staeff) <staeff@users.noreply.github.com>
Commit: plone/plone.app.robotframework@00fd30d

Update url

Link has changed

Files changed:
M docs/source/happy.rst
Repository: plone.app.robotframework
Branch: refs/heads/master
Date: 2016-09-01T09:42:11+02:00
Author: Stephan Klinger (staeff) <staeff@users.noreply.github.com>
Commit: plone/plone.app.robotframework@55e1c7e

Update CHANGES.rst

Files changed:
M CHANGES.rst
Repository: plone.app.robotframework
Branch: refs/heads/master
Date: 2016-09-01T11:15:18+02:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.robotframework@b71fbdb

Merge pull request #62 from plone/staeff-patch-1

Update url

Files changed:
M CHANGES.rst
M docs/source/happy.rst
mister-roboto pushed a commit that referenced this pull request Sep 1, 2016
Branch: refs/heads/master
Date: 2016-09-01T09:40:22+02:00
Author: Stephan Klinger (staeff) <staeff@users.noreply.github.com>
Commit: plone/plone.app.robotframework@00fd30d

Update url

Link has changed

Files changed:
M docs/source/happy.rst
Repository: plone.app.robotframework
Branch: refs/heads/master
Date: 2016-09-01T09:42:11+02:00
Author: Stephan Klinger (staeff) <staeff@users.noreply.github.com>
Commit: plone/plone.app.robotframework@55e1c7e

Update CHANGES.rst

Files changed:
M CHANGES.rst
Repository: plone.app.robotframework
Branch: refs/heads/master
Date: 2016-09-01T11:15:18+02:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.robotframework@b71fbdb

Merge pull request #62 from plone/staeff-patch-1

Update url

Files changed:
M CHANGES.rst
M docs/source/happy.rst
mister-roboto pushed a commit that referenced this pull request Sep 1, 2016
Branch: refs/heads/master
Date: 2016-09-01T09:40:22+02:00
Author: Stephan Klinger (staeff) <staeff@users.noreply.github.com>
Commit: plone/plone.app.robotframework@00fd30d

Update url

Link has changed

Files changed:
M docs/source/happy.rst
Repository: plone.app.robotframework
Branch: refs/heads/master
Date: 2016-09-01T09:42:11+02:00
Author: Stephan Klinger (staeff) <staeff@users.noreply.github.com>
Commit: plone/plone.app.robotframework@55e1c7e

Update CHANGES.rst

Files changed:
M CHANGES.rst
Repository: plone.app.robotframework
Branch: refs/heads/master
Date: 2016-09-01T11:15:18+02:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.robotframework@b71fbdb

Merge pull request #62 from plone/staeff-patch-1

Update url

Files changed:
M CHANGES.rst
M docs/source/happy.rst
mister-roboto pushed a commit that referenced this pull request Oct 9, 2016
Branch: refs/heads/master
Date: 2016-10-10T00:39:56+02:00
Author: David Glick (davisagli) <david.glick@plone.org>
Commit: plone/plone.dexterity@ea3bc8a

Remove dependency on plone.mocktestcase and mocker (#62)

removing dependency on plone.mocktestcase and mocker with mock

* convert test_fti to use mock
* make sure all global patches get removed

Files changed:
A plone/dexterity/tests/case.py
M CHANGES.rst
M plone/dexterity/tests/schemata.py
M plone/dexterity/tests/test.xml
M plone/dexterity/tests/test_behavior.py
M plone/dexterity/tests/test_content.py
M plone/dexterity/tests/test_factory.py
M plone/dexterity/tests/test_fti.py
M plone/dexterity/tests/test_primary.py
M plone/dexterity/tests/test_schema.py
M plone/dexterity/tests/test_schema_cache.py
M plone/dexterity/tests/test_security.py
M plone/dexterity/tests/test_utils.py
M plone/dexterity/tests/test_views.py
M plone/dexterity/tests/test_webdav.py
M setup.py
mister-roboto pushed a commit that referenced this pull request Oct 9, 2016
Branch: refs/heads/master
Date: 2016-10-10T00:39:56+02:00
Author: David Glick (davisagli) <david.glick@plone.org>
Commit: plone/plone.dexterity@ea3bc8a

Remove dependency on plone.mocktestcase and mocker (#62)

removing dependency on plone.mocktestcase and mocker with mock

* convert test_fti to use mock
* make sure all global patches get removed

Files changed:
A plone/dexterity/tests/case.py
M CHANGES.rst
M plone/dexterity/tests/schemata.py
M plone/dexterity/tests/test.xml
M plone/dexterity/tests/test_behavior.py
M plone/dexterity/tests/test_content.py
M plone/dexterity/tests/test_factory.py
M plone/dexterity/tests/test_fti.py
M plone/dexterity/tests/test_primary.py
M plone/dexterity/tests/test_schema.py
M plone/dexterity/tests/test_schema_cache.py
M plone/dexterity/tests/test_security.py
M plone/dexterity/tests/test_utils.py
M plone/dexterity/tests/test_views.py
M plone/dexterity/tests/test_webdav.py
M setup.py
jensens added a commit that referenced this pull request Oct 9, 2016
Branch: refs/heads/master
Date: 2016-10-10T00:39:56+02:00
Author: David Glick (davisagli) <david.glick@plone.org>
Commit: plone/plone.dexterity@ea3bc8a

Remove dependency on plone.mocktestcase and mocker (#62)

removing dependency on plone.mocktestcase and mocker with mock

* convert test_fti to use mock
* make sure all global patches get removed

Files changed:
A plone/dexterity/tests/case.py
M CHANGES.rst
M plone/dexterity/tests/schemata.py
M plone/dexterity/tests/test.xml
M plone/dexterity/tests/test_behavior.py
M plone/dexterity/tests/test_content.py
M plone/dexterity/tests/test_factory.py
M plone/dexterity/tests/test_fti.py
M plone/dexterity/tests/test_primary.py
M plone/dexterity/tests/test_schema.py
M plone/dexterity/tests/test_schema_cache.py
M plone/dexterity/tests/test_security.py
M plone/dexterity/tests/test_utils.py
M plone/dexterity/tests/test_views.py
M plone/dexterity/tests/test_webdav.py
M setup.py
mister-roboto pushed a commit that referenced this pull request Mar 8, 2017
Branch: refs/heads/master
Date: 2017-03-08T21:03:52Z
Author: Tom Gross (tomgross) <itconsense@gmail.com>
Commit: plone/plone.app.z3cform@5106714

Catch TypeError occuring on conflicting subrequests in inline validation

Files changed:
M CHANGES.rst
M plone/app/z3cform/inline_validation.py
Repository: plone.app.z3cform
Branch: refs/heads/master
Date: 2017-03-08T23:09:04+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.z3cform@04076b0

Merge pull request #62 from plone/catch_typerror

Catch TypeError occuring on conflicting subrequests in inline validation

Files changed:
M CHANGES.rst
M plone/app/z3cform/inline_validation.py
mister-roboto pushed a commit that referenced this pull request Feb 1, 2018
Branch: refs/heads/master
Date: 2018-01-30T18:06:06+01:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.namedfile@68026c6

fixes for py3 startup

Files changed:
M plone/namedfile/interfaces.py
M plone/namedfile/marshaler.py
Repository: plone.namedfile

Branch: refs/heads/master
Date: 2018-02-01T23:55:50+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.namedfile@c5358f2

Merge pull request #62 from plone/python3

fixes for py3 startup

Files changed:
M plone/namedfile/interfaces.py
M plone/namedfile/marshaler.py
mister-roboto pushed a commit that referenced this pull request Aug 14, 2018
Branch: refs/heads/master
Date: 2018-08-14T16:53:42+12:00
Author: ezvirtual (ezvirtual) <ezvirtual@thevirtual.co.nz>
Commit: plone/plone.schemaeditor@b294102

Allow defaults to be set on dexterity type fields via the web UI

Files changed:
M CHANGES.rst
M plone/schemaeditor/browser/schema/listing.py
Repository: plone.schemaeditor

Branch: refs/heads/master
Date: 2018-08-14T09:46:21+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.schemaeditor@0bd2d1e

Merge pull request #62 from TheVirtualLtd/master

Allow defaults to be set on dexterity type fields via the web UI

Files changed:
M CHANGES.rst
M plone/schemaeditor/browser/schema/listing.py
mister-roboto pushed a commit that referenced this pull request Aug 14, 2018
Branch: refs/heads/master
Date: 2018-08-14T16:53:42+12:00
Author: ezvirtual (ezvirtual) <ezvirtual@thevirtual.co.nz>
Commit: plone/plone.schemaeditor@b294102

Allow defaults to be set on dexterity type fields via the web UI

Files changed:
M CHANGES.rst
M plone/schemaeditor/browser/schema/listing.py
Repository: plone.schemaeditor

Branch: refs/heads/master
Date: 2018-08-14T09:46:21+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.schemaeditor@0bd2d1e

Merge pull request #62 from TheVirtualLtd/master

Allow defaults to be set on dexterity type fields via the web UI

Files changed:
M CHANGES.rst
M plone/schemaeditor/browser/schema/listing.py
mister-roboto pushed a commit that referenced this pull request Aug 14, 2018
Branch: refs/heads/master
Date: 2018-08-14T16:53:42+12:00
Author: ezvirtual (ezvirtual) <ezvirtual@thevirtual.co.nz>
Commit: plone/plone.schemaeditor@b294102

Allow defaults to be set on dexterity type fields via the web UI

Files changed:
M CHANGES.rst
M plone/schemaeditor/browser/schema/listing.py
Repository: plone.schemaeditor

Branch: refs/heads/master
Date: 2018-08-14T09:46:21+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.schemaeditor@0bd2d1e

Merge pull request #62 from TheVirtualLtd/master

Allow defaults to be set on dexterity type fields via the web UI

Files changed:
M CHANGES.rst
M plone/schemaeditor/browser/schema/listing.py
mister-roboto pushed a commit that referenced this pull request Oct 22, 2018
Branch: refs/heads/2.3.x
Date: 2018-10-06T15:23:04+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.ATContentTypes@0343f2e

Use check_id function from CMFPlone.utils.

Files changed:
A news/60.bugfix
M Products/ATContentTypes/content/base.py
Repository: Products.ATContentTypes

Branch: refs/heads/2.3.x
Date: 2018-10-22T21:22:33+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.ATContentTypes@19fcd49

Merge pull request #62 from plone/use-check-id-function-23x

Use check_id function from CMFPlone.utils. [2.3.x/5.1]

Files changed:
A news/60.bugfix
M Products/ATContentTypes/content/base.py
mister-roboto pushed a commit that referenced this pull request Oct 29, 2018
Branch: refs/heads/master
Date: 2018-10-29T19:35:30+01:00
Author: Huub Bouma (huubbouma) <bouma@w20e.com>
Commit: plone/Products.CMFEditions@7e2b602

Fix success() responses in controller actions browser views for AT types (Fixes #62)

Files changed:
A news/62.bugfix
M Products/CMFEditions/browser/views.py
Repository: Products.CMFEditions

Branch: refs/heads/master
Date: 2018-10-29T19:44:02+01:00
Author: Huub Bouma (huubbouma) <bouma@w20e.com>
Commit: plone/Products.CMFEditions@cbc6a30

Merge pull request #63 from huubbouma/master

Fix success() responses in browser views for AT types

Files changed:
A news/62.bugfix
M Products/CMFEditions/browser/views.py
mister-roboto pushed a commit that referenced this pull request Feb 7, 2020
Branch: refs/heads/master
Date: 2020-02-05T15:51:08+01:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.testing@e8ba5ff

Fix some test isolation issues

Fix a test isolation issue that was preventing the MOCK_MAILHOST_FIXTURE
to be used in multiple testcases (Fixes #61),

Properly configure the mail sender setting the appropriate registry
records (Fixes #62),

Adds test coverage.

Files changed:
A news/61.bugfix
A news/62.bugfix
M src/plone/app/testing/layers.py
M src/plone/app/testing/layers.rst
M src/plone/app/testing/tests.py
Repository: plone.app.testing

Branch: refs/heads/master
Date: 2020-02-07T12:03:23+01:00
Author: Maurits van Rees (mauritsvanrees) <m.van.rees@zestsoftware.nl>
Commit: plone/plone.app.testing@d0a6bdd

Merge pull request #64 from plone/isolation

Fix some test isolation issues

Files changed:
A news/61.bugfix
A news/62.bugfix
M src/plone/app/testing/layers.py
M src/plone/app/testing/layers.rst
M src/plone/app/testing/tests.py
mister-roboto pushed a commit that referenced this pull request Jun 30, 2020
Branch: refs/heads/master
Date: 2020-06-30T10:38:55+02:00
Author: Vincent Fretin (vincentfretin) <vincent.fretin@gmail.com>
Commit: plone/plone.app.vocabularies@c680d49

Add new plone.app.vocabularies.MetadataFields vocabulary

Files changed:
A news/62.feature
A plone/app/vocabularies/metadatafields.py
M plone/app/vocabularies/configure.zcml
Repository: plone.app.vocabularies

Branch: refs/heads/master
Date: 2020-06-30T11:23:19+02:00
Author: Vincent Fretin (vincentfretin) <vincent.fretin@gmail.com>
Commit: plone/plone.app.vocabularies@1b669bb

add the new vocabulary in the README

Files changed:
M README.rst
Repository: plone.app.vocabularies

Branch: refs/heads/master
Date: 2020-06-30T11:42:19+02:00
Author: Vincent Fretin (vincentfretin) <vincent.fretin@gmail.com>
Commit: plone/plone.app.vocabularies@37c837b

add a test for metadatafields

Files changed:
M plone/app/vocabularies/metadatafields.py
M plone/app/vocabularies/tests/test_vocabularies.py
Repository: plone.app.vocabularies

Branch: refs/heads/master
Date: 2020-06-30T13:28:18+02:00
Author: Vincent Fretin (vincentfretin) <vincent.fretin@gmail.com>
Commit: plone/plone.app.vocabularies@b31710c

Merge pull request #62 from plone/fix-i18n-columns-title

Add new plone.app.vocabularies.MetadataFields vocabulary

Files changed:
A news/62.feature
A plone/app/vocabularies/metadatafields.py
M README.rst
M plone/app/vocabularies/configure.zcml
M plone/app/vocabularies/tests/test_vocabularies.py
mister-roboto pushed a commit that referenced this pull request Sep 11, 2020
Branch: refs/heads/master
Date: 2020-09-10T17:43:31+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.caching@d31efb9

Fixed invalid escape sequences.

Files changed:
A news/3130.bugfix
M plone/app/caching/operations/utils.py
Repository: plone.app.caching

Branch: refs/heads/master
Date: 2020-09-11T08:47:13+02:00
Author: Maurits van Rees (mauritsvanrees) <m.van.rees@zestsoftware.nl>
Commit: plone/plone.app.caching@883d41e

Merge pull request #62 from plone/maurits/fix-warnings

Fixed invalid escape sequences.

Files changed:
A news/3130.bugfix
M plone/app/caching/operations/utils.py
mister-roboto pushed a commit that referenced this pull request Jul 2, 2021
Branch: refs/heads/6.x
Date: 2021-07-01T16:27:01+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.PlonePAS@54cef66

Fixed tests for cookie auth to also work with zope.interface 5.3.0.

This uses simpler representations for interfaces.
Tests now pass with earlier and later versions.

Original error from [Jenkins](https://jenkins.plone.org/job/pull-request-5.2-3.6/1938/testReport/junit/Products.PlonePAS/tests/cookie_auth_rst/):

```
File "/home/jenkins/.buildout/eggs/cp36m/Products.PlonePAS-6.0.7-py3.6.egg/Products/PlonePAS/tests/cookie_auth.rst", line 55, in cookie_auth.rst
Failed example:
    for active, iface in actives:
        print(iface)
        for id, plugin in active:
            if id == 'credentials_cookie_auth':
               print(True)
Expected:
    &lt;...IExtraction...&gt;...True
    &lt;...IChallenge...&gt;...True
    &lt;...ICredentialsUpdate...&gt;...&lt;...ICredentialsReset...&gt;
Got:
    Products.PluggableAuthService.interfaces.plugins.IExtractionPlugin
    True
    Products.PluggableAuthService.interfaces.plugins.IChallengePlugin
    True
    Products.PluggableAuthService.interfaces.plugins.ICredentialsUpdatePlugin
    Products.PluggableAuthService.interfaces.plugins.ICredentialsResetPlugin
```

The fix is to print `iface.__name__`, which looks the same in all versions.

Files changed:
A news/237.bugfix
M src/Products/PlonePAS/tests/cookie_auth.rst
Repository: Products.PlonePAS

Branch: refs/heads/6.x
Date: 2021-07-02T08:50:12+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/Products.PlonePAS@a2ed9fb

Merge pull request #62 from plone/maurits/fix-interface-repr-tests

Fixed tests for cookie auth to also work with zope.interface 5.3.0. [6.x]

Files changed:
A news/237.bugfix
M src/Products/PlonePAS/tests/cookie_auth.rst
mister-roboto pushed a commit that referenced this pull request Feb 4, 2022
Branch: refs/heads/master
Date: 2022-02-03T11:04:37+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.versioningbehavior@75ea67f

Removed deprecated `plone.namedfile[blobs]` from the test requirements.

I overlooked this in plone/plone.app.versioningbehavior#61

Also removed duplicate `plone.app.testing` from this list.
And removed `plone.app.dexterity`, as we already have `plone.app.dexterity[relations]` in the `install_requires`.

Note that we might want to remove `tests_requires`.
And rename the `tests` extra to the more common `test`, but this requires a change in `buildout.coredev` 5.2 and 6.0.
So maybe not for now.

Files changed:
A news/106.bugfix
M setup.py
Repository: plone.app.versioningbehavior

Branch: refs/heads/master
Date: 2022-02-04T09:18:59+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.versioningbehavior@fec288b

Merge pull request #62 from plone/maurits-cleanup-test-requirements

Removed deprecated `plone.namedfile[blobs]` from the test requirements.

Files changed:
A news/106.bugfix
M setup.py
mister-roboto pushed a commit that referenced this pull request Feb 4, 2022
Branch: refs/heads/master
Date: 2022-02-03T11:04:37+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.versioningbehavior@75ea67f

Removed deprecated `plone.namedfile[blobs]` from the test requirements.

I overlooked this in plone/plone.app.versioningbehavior#61

Also removed duplicate `plone.app.testing` from this list.
And removed `plone.app.dexterity`, as we already have `plone.app.dexterity[relations]` in the `install_requires`.

Note that we might want to remove `tests_requires`.
And rename the `tests` extra to the more common `test`, but this requires a change in `buildout.coredev` 5.2 and 6.0.
So maybe not for now.

Files changed:
A news/106.bugfix
M setup.py
Repository: plone.app.versioningbehavior

Branch: refs/heads/master
Date: 2022-02-04T09:18:59+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.versioningbehavior@fec288b

Merge pull request #62 from plone/maurits-cleanup-test-requirements

Removed deprecated `plone.namedfile[blobs]` from the test requirements.

Files changed:
A news/106.bugfix
M setup.py
mister-roboto pushed a commit that referenced this pull request Apr 14, 2022
Branch: refs/heads/master
Date: 2022-04-13T13:02:13+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.registry@dabcab7

Allow up to one dash in an a record key. Fixes plone/Products.CMFPlone#3499

Files changed:
M plone/app/registry/browser/records.py
Repository: plone.app.registry

Branch: refs/heads/master
Date: 2022-04-13T13:05:25+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.registry@b703ce9

changenote

Files changed:
A news/62.bugfix
Repository: plone.app.registry

Branch: refs/heads/master
Date: 2022-04-13T14:09:33+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.registry@fd5d9dc

add missing import

Files changed:
M plone/app/registry/browser/records.py
Repository: plone.app.registry

Branch: refs/heads/master
Date: 2022-04-14T14:02:22+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.registry@3e869bf

Merge pull request #62 from plone/allow_dash_in_record_key

Allow up to one dash in key when creating an a record ttw

Files changed:
A news/62.bugfix
M plone/app/registry/browser/records.py
mister-roboto pushed a commit that referenced this pull request Jun 14, 2023
Branch: refs/heads/master
Date: 2023-06-13T16:56:19-07:00
Author: David Glick (davisagli) <david@glicksoftware.com>
Commit: plone/plone.outputfilters@c08c89b

fix error when resolveuid is called with no uuid

Files changed:
A news/43.bugfix
M plone/outputfilters/browser/resolveuid.py
M plone/outputfilters/tests/test_resolveuid_and_caption.py
Repository: plone.outputfilters

Branch: refs/heads/master
Date: 2023-06-14T10:57:28-07:00
Author: David Glick (davisagli) <david@glicksoftware.com>
Commit: plone/plone.outputfilters@e9e38f4

Merge pull request #62 from plone/fix-resolveuid-missing-uuid

fix error when resolveuid is called with no uuid

Files changed:
A news/43.bugfix
M plone/outputfilters/browser/resolveuid.py
M plone/outputfilters/tests/test_resolveuid_and_caption.py
mister-roboto pushed a commit that referenced this pull request Jun 14, 2023
Branch: refs/heads/master
Date: 2023-06-13T16:56:19-07:00
Author: David Glick (davisagli) <david@glicksoftware.com>
Commit: plone/plone.outputfilters@c08c89b

fix error when resolveuid is called with no uuid

Files changed:
A news/43.bugfix
M plone/outputfilters/browser/resolveuid.py
M plone/outputfilters/tests/test_resolveuid_and_caption.py
Repository: plone.outputfilters

Branch: refs/heads/master
Date: 2023-06-14T10:57:28-07:00
Author: David Glick (davisagli) <david@glicksoftware.com>
Commit: plone/plone.outputfilters@e9e38f4

Merge pull request #62 from plone/fix-resolveuid-missing-uuid

fix error when resolveuid is called with no uuid

Files changed:
A news/43.bugfix
M plone/outputfilters/browser/resolveuid.py
M plone/outputfilters/tests/test_resolveuid_and_caption.py
mister-roboto pushed a commit that referenced this pull request Nov 30, 2023
Branch: refs/heads/master
Date: 2023-09-19T00:12:49+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@99c8407

Add manage command 'versions2constraints'.

Files changed:
M plone/releaser/manage.py
M plone/releaser/utils.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-09-19T00:12:50+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@a2d72e2

Support writing to [versions:pythonx]

Files changed:
M plone/releaser/buildout.py
M plone/releaser/manage.py
M plone/releaser/tests/input/versions.cfg
M plone/releaser/tests/test_buildout.py
M plone/releaser/utils.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-09-19T00:12:50+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@fdad9eb

Read 'extends' lines from versions.cfg.

Only local for now.

Files changed:
A plone/releaser/tests/input/versions2.cfg
A plone/releaser/tests/input/versions3.cfg
A plone/releaser/tests/input/versions4.cfg
M plone/releaser/buildout.py
M plone/releaser/tests/test_buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-07T20:54:02+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@3d800c3

Support reading extends (-c) in constraints as well.

Files changed:
A plone/releaser/tests/input/constraints2.txt
A plone/releaser/tests/input/constraints3.txt
A plone/releaser/tests/input/constraints4.txt
M plone/releaser/pip.py
M plone/releaser/tests/input/constraints.txt
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-07T22:15:36+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@990f64e

Add VersionsFile.rewrite.

This takes the parsed 'extends' and 'versions' and writes them back.
This normalizes some stuff, so it will not be exactly the same.

In the end we want to take versions.cfg and translate it to constraints.txt.
But translating versions.cfg to its own should work as well, and is a good first step.

Files changed:
M plone/releaser/buildout.py
M plone/releaser/tests/test_buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-09T12:05:44+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@b41ea5b

constraints: platform_system is darwin, not macosx.

Files changed:
M plone/releaser/tests/input/constraints4.txt
M plone/releaser/tests/test_pip.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-12T20:37:44+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@fb2968b

Add ConstraintsFile.rewrite.

Files changed:
M plone/releaser/pip.py
M plone/releaser/tests/test_pip.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-12T22:45:33+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@a034175

Add CheckoutsFile.rewrite.

Files changed:
M plone/releaser/buildout.py
M plone/releaser/tests/test_buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-12T23:30:30+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@6b56b8f

Add Inifile.rewrite.

Files changed:
M plone/releaser/pip.py
M plone/releaser/tests/test_pip.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-27T00:10:23+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@667d09c

Fix manage.py to work with argh 0.30+.

Full traceback with info:

```
$ bin/manage -h
Traceback (most recent call last):
  File "/Users/maurits/community/plone-coredev/6.0/bin/manage", line 63, in &lt;module&gt;
    sys.exit(plone.releaser.manage.manage())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/maurits/community/plone-coredev/6.0/src/plone.releaser/plone/releaser/manage.py", line 277, in __call__
    parser.add_commands(
  File "/Users/maurits/shared-eggs/cp312/argh-0.30.2-py3.12.egg/argh/helpers.py", line 47, in add_commands
    return add_commands(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/maurits/shared-eggs/cp312/argh-0.30.2-py3.12.egg/argh/assembling.py", line 592, in add_commands
    set_default_command(
  File "/Users/maurits/shared-eggs/cp312/argh-0.30.2-py3.12.egg/argh/assembling.py", line 331, in set_default_command
    inferred_args: List[ParserAddArgumentSpec] = list(
                                                 ^^^^^
  File "/Users/maurits/shared-eggs/cp312/argh-0.30.2-py3.12.egg/argh/assembling.py", line 155, in infer_argspecs_from_function
    raise ArgumentNameMappingError(
argh.assembling.ArgumentNameMappingError: Argument "path" in function "add_checkout"
is not keyword-only but has a default value.

Please note that since Argh v.0.30 the default name mapping
policy has changed.

More information:
https://argh.readthedocs.io/en/latest/changes.html#version-0-30-0-2023-10-21

You need to upgrade your functions so that the arguments
that have default values become keyword-only:

    f(x=1) -&gt; f(*, x=1)

If you actually want an optional positional argument,
please set the name mapping policy explicitly to `BY_NAME_IF_KWONLY`.

If you choose to postpone the migration, you have two options:

a) set the policy explicitly to `BY_NAME_IF_HAS_DEFAULT`;
b) pin Argh version to 0.29 until you are ready to migrate.

Thank you for understanding!
```

Files changed:
M plone/releaser/manage.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-30T10:56:01+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@4f5492c

SourcesFile: use config/data and a raw version without interpolation.

Files changed:
M plone/releaser/buildout.py
M plone/releaser/tests/test_buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-16T18:50:15+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@d03ac9a

SourcesFile.rewrite: take all non-sources sections.

Files changed:
M plone/releaser/buildout.py
M plone/releaser/tests/test_buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-16T19:34:08+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@9a2ba07

Get versions2constraints working for simple cases.

Files changed:
A plone/releaser/tests/test_versions2constraints.py
M plone/releaser/manage.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-16T19:59:26+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@b718af0

Add BaseBuildoutFile and let the others inherit from it.

Then everything has a config, raw_config, and extends.

Files changed:
M plone/releaser/buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-16T23:26:00+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@28983c6

Get versions2constraints working

Files changed:
M plone/releaser/buildout.py
M plone/releaser/manage.py
M plone/releaser/pip.py
M plone/releaser/tests/test_utils.py
M plone/releaser/tests/test_versions2constraints.py
M plone/releaser/utils.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-17T00:24:47+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@004aed8

Add news snippet: Add bin/manage versions2constraints command.

Files changed:
A news/3670.feature
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-30T20:12:59+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@c59ad3f

Merge pull request #62 from plone/maurits-buildout2pip

Add bin/manage versions2constraints command.

Files changed:
A news/3670.feature
A plone/releaser/tests/input/constraints2.txt
A plone/releaser/tests/input/constraints3.txt
A plone/releaser/tests/input/constraints4.txt
A plone/releaser/tests/input/versions2.cfg
A plone/releaser/tests/input/versions3.cfg
A plone/releaser/tests/input/versions4.cfg
A plone/releaser/tests/test_versions2constraints.py
M plone/releaser/buildout.py
M plone/releaser/manage.py
M plone/releaser/pip.py
M plone/releaser/tests/input/constraints.txt
M plone/releaser/tests/input/versions.cfg
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
M plone/releaser/tests/test_utils.py
M plone/releaser/utils.py
mister-roboto pushed a commit that referenced this pull request Nov 30, 2023
Branch: refs/heads/master
Date: 2023-09-19T00:12:49+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@99c8407

Add manage command 'versions2constraints'.

Files changed:
M plone/releaser/manage.py
M plone/releaser/utils.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-09-19T00:12:50+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@a2d72e2

Support writing to [versions:pythonx]

Files changed:
M plone/releaser/buildout.py
M plone/releaser/manage.py
M plone/releaser/tests/input/versions.cfg
M plone/releaser/tests/test_buildout.py
M plone/releaser/utils.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-09-19T00:12:50+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@fdad9eb

Read 'extends' lines from versions.cfg.

Only local for now.

Files changed:
A plone/releaser/tests/input/versions2.cfg
A plone/releaser/tests/input/versions3.cfg
A plone/releaser/tests/input/versions4.cfg
M plone/releaser/buildout.py
M plone/releaser/tests/test_buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-07T20:54:02+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@3d800c3

Support reading extends (-c) in constraints as well.

Files changed:
A plone/releaser/tests/input/constraints2.txt
A plone/releaser/tests/input/constraints3.txt
A plone/releaser/tests/input/constraints4.txt
M plone/releaser/pip.py
M plone/releaser/tests/input/constraints.txt
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-07T22:15:36+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@990f64e

Add VersionsFile.rewrite.

This takes the parsed 'extends' and 'versions' and writes them back.
This normalizes some stuff, so it will not be exactly the same.

In the end we want to take versions.cfg and translate it to constraints.txt.
But translating versions.cfg to its own should work as well, and is a good first step.

Files changed:
M plone/releaser/buildout.py
M plone/releaser/tests/test_buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-09T12:05:44+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@b41ea5b

constraints: platform_system is darwin, not macosx.

Files changed:
M plone/releaser/tests/input/constraints4.txt
M plone/releaser/tests/test_pip.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-12T20:37:44+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@fb2968b

Add ConstraintsFile.rewrite.

Files changed:
M plone/releaser/pip.py
M plone/releaser/tests/test_pip.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-12T22:45:33+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@a034175

Add CheckoutsFile.rewrite.

Files changed:
M plone/releaser/buildout.py
M plone/releaser/tests/test_buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-12T23:30:30+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@6b56b8f

Add Inifile.rewrite.

Files changed:
M plone/releaser/pip.py
M plone/releaser/tests/test_pip.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-27T00:10:23+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@667d09c

Fix manage.py to work with argh 0.30+.

Full traceback with info:

```
$ bin/manage -h
Traceback (most recent call last):
  File "/Users/maurits/community/plone-coredev/6.0/bin/manage", line 63, in &lt;module&gt;
    sys.exit(plone.releaser.manage.manage())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/maurits/community/plone-coredev/6.0/src/plone.releaser/plone/releaser/manage.py", line 277, in __call__
    parser.add_commands(
  File "/Users/maurits/shared-eggs/cp312/argh-0.30.2-py3.12.egg/argh/helpers.py", line 47, in add_commands
    return add_commands(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/maurits/shared-eggs/cp312/argh-0.30.2-py3.12.egg/argh/assembling.py", line 592, in add_commands
    set_default_command(
  File "/Users/maurits/shared-eggs/cp312/argh-0.30.2-py3.12.egg/argh/assembling.py", line 331, in set_default_command
    inferred_args: List[ParserAddArgumentSpec] = list(
                                                 ^^^^^
  File "/Users/maurits/shared-eggs/cp312/argh-0.30.2-py3.12.egg/argh/assembling.py", line 155, in infer_argspecs_from_function
    raise ArgumentNameMappingError(
argh.assembling.ArgumentNameMappingError: Argument "path" in function "add_checkout"
is not keyword-only but has a default value.

Please note that since Argh v.0.30 the default name mapping
policy has changed.

More information:
https://argh.readthedocs.io/en/latest/changes.html#version-0-30-0-2023-10-21

You need to upgrade your functions so that the arguments
that have default values become keyword-only:

    f(x=1) -&gt; f(*, x=1)

If you actually want an optional positional argument,
please set the name mapping policy explicitly to `BY_NAME_IF_KWONLY`.

If you choose to postpone the migration, you have two options:

a) set the policy explicitly to `BY_NAME_IF_HAS_DEFAULT`;
b) pin Argh version to 0.29 until you are ready to migrate.

Thank you for understanding!
```

Files changed:
M plone/releaser/manage.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-10-30T10:56:01+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@4f5492c

SourcesFile: use config/data and a raw version without interpolation.

Files changed:
M plone/releaser/buildout.py
M plone/releaser/tests/test_buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-16T18:50:15+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@d03ac9a

SourcesFile.rewrite: take all non-sources sections.

Files changed:
M plone/releaser/buildout.py
M plone/releaser/tests/test_buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-16T19:34:08+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@9a2ba07

Get versions2constraints working for simple cases.

Files changed:
A plone/releaser/tests/test_versions2constraints.py
M plone/releaser/manage.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-16T19:59:26+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@b718af0

Add BaseBuildoutFile and let the others inherit from it.

Then everything has a config, raw_config, and extends.

Files changed:
M plone/releaser/buildout.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-16T23:26:00+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@28983c6

Get versions2constraints working

Files changed:
M plone/releaser/buildout.py
M plone/releaser/manage.py
M plone/releaser/pip.py
M plone/releaser/tests/test_utils.py
M plone/releaser/tests/test_versions2constraints.py
M plone/releaser/utils.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-17T00:24:47+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@004aed8

Add news snippet: Add bin/manage versions2constraints command.

Files changed:
A news/3670.feature
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-11-30T20:12:59+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@c59ad3f

Merge pull request #62 from plone/maurits-buildout2pip

Add bin/manage versions2constraints command.

Files changed:
A news/3670.feature
A plone/releaser/tests/input/constraints2.txt
A plone/releaser/tests/input/constraints3.txt
A plone/releaser/tests/input/constraints4.txt
A plone/releaser/tests/input/versions2.cfg
A plone/releaser/tests/input/versions3.cfg
A plone/releaser/tests/input/versions4.cfg
A plone/releaser/tests/test_versions2constraints.py
M plone/releaser/buildout.py
M plone/releaser/manage.py
M plone/releaser/pip.py
M plone/releaser/tests/input/constraints.txt
M plone/releaser/tests/input/versions.cfg
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
M plone/releaser/tests/test_utils.py
M plone/releaser/utils.py
mister-roboto pushed a commit that referenced this pull request Apr 24, 2024
Branch: refs/heads/master
Date: 2024-04-24T00:13:06+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.PortalTransforms@df24def

Use Cleaner from new package lxml_html_clean.

This was factored out from ``lxml`` in version 5.2.0.
See https://lxml-html-clean.readthedocs.io/

Fixes plone/Products.CMFPlone#3938

Alternatively we could depend on `lxml[html_clean]`, but I think it is cleaner (pun intended) to directly depend on the new package.
Also, this means it is still possible to use an older `lxml` version that does not have the `html_clean` extra, if needed.

Files changed:
A news/3938.bugfix
M Products/PortalTransforms/transforms/safe_html.py
M setup.py
Repository: Products.PortalTransforms

Branch: refs/heads/master
Date: 2024-04-24T18:16:09+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.PortalTransforms@ad6ddf2

Fix test_xss test_38 to pass on both lxml 4 and 5.

See also this change from two years ago:
plone/Products.PortalTransforms@47eee97#diff-efe2731249aad855e92cb1a1095e921edec654ef09fe9c6af8b8094f49acf646L231-R232

Files changed:
M Products/PortalTransforms/tests/test_xss.py
Repository: Products.PortalTransforms

Branch: refs/heads/master
Date: 2024-04-24T20:49:48+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.PortalTransforms@8fe2a57

Merge pull request #62 from plone/maurits-lxml-html-clean-package

Use Cleaner from new package lxml_html_clean.

Files changed:
A news/3938.bugfix
M Products/PortalTransforms/tests/test_xss.py
M Products/PortalTransforms/transforms/safe_html.py
M setup.py
mister-roboto pushed a commit that referenced this pull request Apr 24, 2024
Branch: refs/heads/master
Date: 2024-04-24T00:13:06+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.PortalTransforms@df24def

Use Cleaner from new package lxml_html_clean.

This was factored out from ``lxml`` in version 5.2.0.
See https://lxml-html-clean.readthedocs.io/

Fixes plone/Products.CMFPlone#3938

Alternatively we could depend on `lxml[html_clean]`, but I think it is cleaner (pun intended) to directly depend on the new package.
Also, this means it is still possible to use an older `lxml` version that does not have the `html_clean` extra, if needed.

Files changed:
A news/3938.bugfix
M Products/PortalTransforms/transforms/safe_html.py
M setup.py
Repository: Products.PortalTransforms

Branch: refs/heads/master
Date: 2024-04-24T18:16:09+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.PortalTransforms@ad6ddf2

Fix test_xss test_38 to pass on both lxml 4 and 5.

See also this change from two years ago:
plone/Products.PortalTransforms@47eee97#diff-efe2731249aad855e92cb1a1095e921edec654ef09fe9c6af8b8094f49acf646L231-R232

Files changed:
M Products/PortalTransforms/tests/test_xss.py
Repository: Products.PortalTransforms

Branch: refs/heads/master
Date: 2024-04-24T20:49:48+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/Products.PortalTransforms@8fe2a57

Merge pull request #62 from plone/maurits-lxml-html-clean-package

Use Cleaner from new package lxml_html_clean.

Files changed:
A news/3938.bugfix
M Products/PortalTransforms/tests/test_xss.py
M Products/PortalTransforms/transforms/safe_html.py
M setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants