Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Zope 4.4.5 #663

Closed
wants to merge 1 commit into from

Conversation

vincentfretin
Copy link
Member

Don't merge, I want to run the tests.

@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

@vincentfretin
Copy link
Member Author

Plone Jenkins CI - pull-request-5.2
plone.restapi.tests.test_services_querystringsearch.TestQuerystringSearchEndpoint.test_querystringsearch_do_not_return_context

u'http://localhost:44923/plone/testdocument2' != 'http://localhost:55001/plone/testdocument2'

  File "/srv/python2.7/lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File "/home/jenkins/workspace/pull-request-5.2/src/plone.restapi/src/plone/restapi/tests/test_services_querystringsearch.py", line 168, in test_querystringsearch_do_not_return_context
    "http://localhost:55001/plone/testdocument2",
  File "/srv/python2.7/lib/python2.7/unittest/case.py", line 513, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/srv/python2.7/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
    raise self.failureException(msg)

It seems we have a random port now instead of hard coded 55001?

@vincentfretin
Copy link
Member Author

@tisto Can you please make a fix for this test in plone.restapi to not hard code the port?

@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

@ale-rt
Copy link
Member

ale-rt commented Jul 9, 2020

I started #664 cause I did not see this one, feel free to close it if you already have ongoing work!

@ale-rt
Copy link
Member

ale-rt commented Jul 9, 2020

Aniway I think #664 will fail for the same reason this one is failing...

@ale-rt
Copy link
Member

ale-rt commented Jul 9, 2020

The error should be fixed by: plone/plone.restapi#979
No wonder all the builds are failing :)

@ale-rt
Copy link
Member

ale-rt commented Jul 9, 2020

@jenkins-plone-org please run jobs

@vincentfretin
Copy link
Member Author

Thanks @ale-rt

@vincentfretin vincentfretin deleted the vincentfretin-upgrade-to-zope-4.4.5 branch July 10, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants