Remove Products.CMFFormController / portal_form_controller. #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the package from the buildout files. Use branches of CMFPlone and plone.app.upgrade. We could also remove a CMFFormController line from plone.app.testing, but it's not in the way. Could be done once we make a plone.app.testing branch for Plone 6 only. In plone.app.upgrade I remove the portal_form_controller tool. We could also conditionally remove it: check if the tool is an instance of `ZODB.broken.Broken`. This is to support the theoretical case that someone explicitly adds the CMFFormController package, because it is still needed in a specific site. But same could be done for portal_quickinstaller, and we don't do it there either.
This was referenced Jan 15, 2021
|
Removal is fine IMO, if this is an issue we can refactor later. But I do not expect it to be one. I would say, just merge if ready, LGTM (also the connected PRs) |
jensens
approved these changes
Jan 15, 2021
mauritsvanrees
added a commit
that referenced
this pull request
Jan 15, 2021
Edited from #696 after merging the CMFPlone and plone.app.upgrade PRs.
|
I have merged all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the package from the buildout files.
Use branches of
CMFPlone(plone/Products.CMFPlone#3226) andplone.app.upgrade(plone/plone.app.upgrade#251).We could also remove a
CMFFormControllerline fromplone.app.testing, but it's not in the way.Could be done once we make a
plone.app.testingbranch for Plone 6 only.In
plone.app.upgradeI remove theportal_form_controllertool.We could also conditionally remove it: check if the tool is an instance of
ZODB.broken.Broken.This is to support the theoretical case that someone explicitly adds the
CMFFormControllerpackage, because it is still needed in a specific site.But same could be done for
portal_quickinstaller, and we don't do it there either.Once green and approved, I can do the merges. The two PRs should be merged, and then on coredev we can keep using the master branches, and only merge the part of this PR that removes
CMFFormControllerfrom thetest-eggsand sources/versions.