Add version pins for robotframework-browser #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With these version pins we can test the new changes in plone.app.robotframework to add support for playwright based tests (that uses robotframework-browser as a glue between playwright and robotframework).
|
@jenkins-plone-org please run jobs |
|
@mauritsvanrees I'm merging it, so we can unblock plone/plone.app.robotframework#149 in jenkins, it will fail, but not at running buildout 😅 |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these version pins we can test the new changes in plone.app.robotframework to add support for playwright based tests (that uses robotframework-browser as a glue between playwright and robotframework).
That's part of #868 but it's the minimal changes needed so we can get plone/plone.app.robotframework#149 to run.