This repository has been archived by the owner on May 15, 2024. It is now read-only.
Add noaddon option
#8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericof
suggested changes
Apr 3, 2024
| @@ -6,6 +6,7 @@ | |||
| "email": "collective@plone.org", | |||
| "github_organization": "collective", | |||
| "npm_package_name": "{{ cookiecutter.addon_name }}", | |||
| "noaddon": false, | |||
There was a problem hiding this comment.
Please, also add the user friendly version under __prompts__
| @@ -38,8 +44,18 @@ def run_cmd(command: str, shell: bool, cwd: str) -> bool: | |||
| return False if proc.returncode else True | |||
|
|
|||
|
|
|||
| def remove(filepath): | |||
| if os.path.isfile(filepath): | |||
| @@ -34,8 +34,12 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@plone/volto": "workspace:*", | |||
| {% if not cookiecutter.noaddon -%} | |||
There was a problem hiding this comment.
Why not to use:
"dependencies": {
"@plone/volto": "workspace:*",
"@plone/registry": "workspace:*"{%- if not cookiecutter.noaddon -%},
"{{ cookiecutter.npm_package_name }}": "workspace:*"
{%- endif %}
},
| @@ -1,4 +1,8 @@ | |||
| {% if not cookiecutter.noaddon -%} | |||
There was a problem hiding this comment.
Why not to use:
const addons = [{%- if not cookiecutter.noaddon -%}'{{ cookiecutter.npm_package_name }}'{%- endif -%}];
|
@ericof It's needed for the generation of the image without add-on. It can be even be a hidden feature. If not, when we generate the image, there will be always the default add-on in there. |
|
Naming is hard :-)
I like the idea of a hidden option that would control this, let me try to
implement it
…On Fri, Apr 5, 2024, 03:52 Víctor Fernández de Alba < ***@***.***> wrote:
@ericof <https://github.com/ericof> It's needed for the generation of the
image without add-on. It can be even be a hidden feature. If not, when we
generate the image, there will be always the default add-on in there.
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKWXWBX2O3R5KAP7YNTYLY3ZC2VAVCNFSM6AAAAABFUYMTGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZZGA3TQOJVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Let's do this in the image stage, not having a public facing way to do this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the use case of the upcoming image. We need no addon in there to have a "clean" Volto if the image alone is run for demo purposes.