-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support python 3.13 and drop python 3.8 and 3.9 #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on Python 3.13.1, building complete project!
-> Initialize Git repository
-> Setup Backend
Traceback (most recent call last):
File "/tmp/tmpzm2e3o52.py", line 180, in <module>
main()
~~~~^^
File "/tmp/tmpzm2e3o52.py", line 146, in main
func(new_context, output_dir)
~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/tmpzm2e3o52.py", line 63, in generate_backend_addon
generator.generate_subtemplate(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
"backend_addon", output_dir, folder_name, context, BACKEND_ADDON_REMOVE
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
File "/home/rohnsha0/code/plone/cookieplone-templates/lib/python3.13/site-packages/cookieplone/generator.py", line 104, in generate_subtemplate
repository = _get_repository_root(context, template)
File "/home/rohnsha0/code/plone/cookieplone-templates/lib/python3.13/site-packages/cookieplone/generator.py", line 37, in _get_repository_root
raise exc.RepositoryNotFound()
cookiecutter.exceptions.RepositoryNotFound
ERROR: Stopping generation because post_gen_project hook script didn't exit successfully
Hook script failed (exit status: 1)
@rohnsha0 did you use the changes in this PR? |
Yep! I've used the same branch as in this PR! |
The main branch fails as not supported version as in preprompt script |
Running |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This LGTM, but let's get a maintainer, too.
FYI, @rohnsha0 comments are for an unrelated issue, once he was able to run Cookeplone with your PR on Python 3.13. |
wait, dont merge now! |
the PR still throws the same error...
sorry for the confusion, the reviews for this PR was tested on this branch for the same error, and still throws the same error! |
@rohnsha0 it sounds like you're talking about installing or running the generated project, not just generating the project. This PR is intended to resolve only being able to run Cookieplone on Python 3.13 to generate a project. If your issue arises after you have generated the project, then you try to build, install, or run your project, then you must create a new separate issue and not hijack this PR. |
@rohnsha0 I don't know how you are testing and what is the fault of your error. python3-13-cookieplone.mp4If you try with my branch and you still get the same error I suggest you open a new issue for it to be tracked separately from this work which simply allows the use of python 3.13 to be used as the python version to generate the project, backend or frontend addon boilerplate. |
I am so sorry @stevepiercy @ichim-david |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ichim-david I thought I had taken care of this in plone/cookieplone#55, but it seems my testing was flawed. This looks good and works for me. Thanks for taking care of it!
@davisagli yup I was going to say that I noticed that you added the support for cookieplone itself but it seems that there were still a small hiccup with the pre script. Then it turned into a bit more of a change after @stevepiercy suggestions and here we are now :). |
@ichim-david I'm working through my inbox and will get to your question eventually. |
Fixes #130