-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix case when theme is provided via an remote https source #41
Conversation
…lem, where a IOError is raised on https sources
from urllib2 import urlopen # For Python 2 | ||
else: | ||
from urllib.requests import urlopen # For Python 3 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what's causing the flake8 error. Diazo depends on the future module, so it should work to just import from the new location (may need to bump the minimum version for future in setup.py) http://python-future.org/standard_library_imports.html
well now it should work in general. If you accept it and merge it it would be nice. |
I've fixed the flake8 failures on master, but it looks like there are other errors coming up with this change. Sorry, I don't have time to look more into it now. |
have looked into the problem and fixed, so that all test passes again. |
Fix case when theme is provided via an remote https source
Diazo brakes with an IOError due to lxml when the theme is from an remote https source.
Fallback to an urllib urlopen call to get the theme if it is https.
solevs #40