Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case when theme is provided via an remote https source #41

Merged
merged 12 commits into from
Apr 8, 2015
Merged

Fix case when theme is provided via an remote https source #41

merged 12 commits into from
Apr 8, 2015

Conversation

loechel
Copy link
Member

@loechel loechel commented Mar 2, 2015

Diazo brakes with an IOError due to lxml when the theme is from an remote https source.
Fallback to an urllib urlopen call to get the theme if it is https.

solevs #40

from urllib2 import urlopen # For Python 2
else:
from urllib.requests import urlopen # For Python 3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is what's causing the flake8 error. Diazo depends on the future module, so it should work to just import from the new location (may need to bump the minimum version for future in setup.py) http://python-future.org/standard_library_imports.html

@loechel
Copy link
Member Author

loechel commented Mar 2, 2015

well now it should work in general. If you accept it and merge it it would be nice.

@lrowe
Copy link
Member

lrowe commented Mar 2, 2015

I've fixed the flake8 failures on master, but it looks like there are other errors coming up with this change. Sorry, I don't have time to look more into it now.

@loechel
Copy link
Member Author

loechel commented Mar 3, 2015

have looked into the problem and fixed, so that all test passes again.
We should write another explicit test for checking remote themes via varios protocols. If anybody can give me a hint, i would do that, but I don't understand the current test setup.

lrowe added a commit that referenced this pull request Apr 8, 2015
Fix case when theme is provided via an remote https source
@lrowe lrowe merged commit 7bb1137 into plone:master Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants