Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container examples with traefik #1501

Merged
merged 3 commits into from
May 26, 2023
Merged

Conversation

margaridasp
Copy link

Fixes #1500

I think we still need to create simpler examples with less components.

@netlify
Copy link

netlify bot commented May 20, 2023

Deploy Preview for 6-docs-plone-org ready!

Name Link
🔨 Latest commit 72ad7c5
🔍 Latest deploy log https://app.netlify.com/sites/6-docs-plone-org/deploys/6470941539bfe00008b5f101
😎 Deploy Preview https://deploy-preview-1501--6-docs-plone-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@margaridasp margaridasp force-pushed the container-examples-with-traefik branch from f95dc63 to 7d66080 Compare May 20, 2023 11:13
@margaridasp margaridasp requested a review from ericof May 20, 2023 11:13
@ericof
Copy link
Member

ericof commented May 25, 2023

@margaridasp Let's merge this one, then create other examples :-)

@margaridasp margaridasp force-pushed the container-examples-with-traefik branch from 7d66080 to 18cfe38 Compare May 26, 2023 09:31
@margaridasp margaridasp marked this pull request as ready for review May 26, 2023 09:32
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions for proper names, renaming headings, MyST syntax for files.

docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Contributor

It is safe to ignore the failing docs build. I have another PR open that fixes the redirect in #1504

Co-authored-by: Steve Piercy <web@stevepiercy.com>
@ericof
Copy link
Member

ericof commented May 26, 2023

@stevepiercy We can merge this whenever you are ready :-)

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I love me some tasty docs!

@stevepiercy stevepiercy merged commit b4e8482 into 6.0 May 26, 2023
@stevepiercy stevepiercy deleted the container-examples-with-traefik branch May 26, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create container examples using Traefik instead of nginx
3 participants