Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try upgrading sphinx and sphinx-book-theme #1600

Closed
wants to merge 2 commits into from
Closed

Try upgrading sphinx and sphinx-book-theme #1600

wants to merge 2 commits into from

Conversation

davisagli
Copy link
Member

@stevepiercy Tried this locally. It installs but I'm getting errors while building the docs, so I'll push it here to make it easier to take a look.

Copy link

netlify bot commented Jan 14, 2024

Deploy Preview for 6-docs-plone-org ready!

Name Link
🔨 Latest commit 81098f2
🔍 Latest deploy log https://app.netlify.com/sites/6-docs-plone-org/deploys/65a36a54a0450a000811549b
😎 Deploy Preview https://deploy-preview-1600--6-docs-plone-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davisagli
Copy link
Member Author

@stevepiercy It looks like there were some updates to the theme templates that went along with upgrading the theme in plone/training#757. I haven't had time to look at the details yet.

@stevepiercy
Copy link
Contributor

@davisagli I'm putting this off until I can release https://github.com/plone/plone-sphinx-theme. There are too many things that need to be copied over from Training to make this work for all the docs.

@davisagli
Copy link
Member Author

@stevepiercy oh, phooey, I didn't know about that, and I've been working on copying things from training for the past hour or two

@davisagli
Copy link
Member Author

@stevepiercy I pushed what I got to... probably some of this should go in plone-sphinx-theme instead. Things seem to be generally working, but the search results still need some style love.

@davisagli
Copy link
Member Author

Closing this since we should use plone-sphinx-theme instead

@davisagli davisagli closed this Sep 30, 2024
@stevepiercy stevepiercy deleted the sphinx-5 branch October 2, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants