Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for plone/cookiecutter-zope-instance 2.x: naming zcml variables #1632

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

ksuess
Copy link
Member

@ksuess ksuess commented Feb 29, 2024

See https://github.com/plone/cookiecutter-zope-instance?tab=readme-ov-file#upgrading

Fix needed. Otherwise the build (make build-backend) fails.

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for 6-docs-plone-org ready!

Name Link
🔨 Latest commit 7b7dcae
🔍 Latest deploy log https://app.netlify.com/sites/6-docs-plone-org/deploys/65e035e0c8bc6a0008ded0ce
😎 Deploy Preview https://deploy-preview-1632--6-docs-plone-org.netlify.app/install/manage-add-ons-packages.html
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Will merge right away.

@stevepiercy
Copy link
Contributor

I'll fix the broken links in another PR.

@stevepiercy stevepiercy merged commit e63e83a into 6.0 Feb 29, 2024
5 of 6 checks passed
@stevepiercy stevepiercy deleted the Fix-for-plone/cookiecutter-zope-instance branch February 29, 2024 09:09
@jensens
Copy link
Member

jensens commented Feb 29, 2024

No idea how its done best, but we need version-management for cookiecutters.
The call supports option cookiecutter --checkout=1.0.1 ... for those who do not want the new 2.0.0 major release.

@stevepiercy
Copy link
Contributor

@jensens are you talking about adding support for that call in the cookiecutter itself or in documentation, or both?

We could add a note to the documentation under Install Plone 6, but the assumption is that the user is creating a new project and should use the latest supported versions of everything. I think adding a note here would add confusion.

But in management of existing projects, we have a note to see the readme for Configuration with cookiecutter-zope-instance. Would that be a good place to add a note about specifying the version of this cookiecutter?

Please let me know. Thank you!

@jensens
Copy link
Member

jensens commented Mar 1, 2024

We should change cookiecutter-plone-starter to pin it and update the Makefile snippet accordingly.

@davisagli
Copy link
Member

@jensens I added an issue over there: collective/cookiecutter-plone-starter#123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants