-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for plone/cookiecutter-zope-instance 2.x: naming zcml variables #1632
Conversation
✅ Deploy Preview for 6-docs-plone-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Will merge right away.
I'll fix the broken links in another PR. |
No idea how its done best, but we need version-management for cookiecutters. |
@jensens are you talking about adding support for that call in the cookiecutter itself or in documentation, or both? We could add a note to the documentation under Install Plone 6, but the assumption is that the user is creating a new project and should use the latest supported versions of everything. I think adding a note here would add confusion. But in management of existing projects, we have a note to see the readme for Configuration with Please let me know. Thank you! |
We should change cookiecutter-plone-starter to pin it and update the Makefile snippet accordingly. |
@jensens I added an issue over there: collective/cookiecutter-plone-starter#123 |
See https://github.com/plone/cookiecutter-zope-instance?tab=readme-ov-file#upgrading
Fix needed. Otherwise the build (
make build-backend
) fails.