Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more info about RichText field and the usage of transforms and RichTextValue #1648

Merged
merged 9 commits into from
May 9, 2024

Conversation

MrTango
Copy link
Contributor

@MrTango MrTango commented Apr 11, 2024

part of #1445

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for 6-docs-plone-org ready!

Name Link
🔨 Latest commit f3ec361
🔍 Latest deploy log https://app.netlify.com/sites/6-docs-plone-org/deploys/663b93ae29ace90008557b40
😎 Deploy Preview https://deploy-preview-1648--6-docs-plone-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good stuff. Just a few minor nitpicks, and it passes my English and MyST syntax and grammar check. It should still get reviewed by someone with technical familiarity.

docs/backend/fields.md Outdated Show resolved Hide resolved
docs/backend/fields.md Outdated Show resolved Hide resolved
docs/backend/fields.md Outdated Show resolved Hide resolved
docs/backend/fields.md Outdated Show resolved Hide resolved
docs/backend/fields.md Outdated Show resolved Hide resolved
docs/backend/fields.md Outdated Show resolved Hide resolved
docs/backend/fields.md Outdated Show resolved Hide resolved
docs/backend/fields.md Outdated Show resolved Hide resolved
docs/backend/fields.md Outdated Show resolved Hide resolved
docs/backend/fields.md Outdated Show resolved Hide resolved
docs/backend/fields.md Outdated Show resolved Hide resolved
docs/backend/fields.md Outdated Show resolved Hide resolved
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a technical perspective. One small suggestion

docs/backend/fields.md Show resolved Hide resolved
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed my suggestions. A couple of nitpicks for Blackifying the code and another suggestion from @davisagli need to be addressed. @MrTango let's finish this PR.

docs/backend/fields.md Show resolved Hide resolved
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting changes look good. Let's wait for @davisagli's review before merging.

@stevepiercy stevepiercy merged commit 803d68e into 6.0 May 9, 2024
6 checks passed
@stevepiercy stevepiercy deleted the backend-richtextfield branch May 9, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants