Javascript > JavaScript #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
svx
commented
Feb 16, 2016
svx
commented
- Following best practices about 'wording'
cewing
added a commit
that referenced
this pull request
Feb 16, 2016
cewing
added a commit
that referenced
this pull request
Feb 16, 2016
I misread the title of that commit and did exactly the wrong thing. This reverts commit 09f9e58.
cewing
added a commit
that referenced
this pull request
Feb 24, 2016
Atomic commit messages to follow: update the introduction to improve the structure, clarify a few explanations, add links to external definitions of terms, and provide a bit more background for the concepts to follow small improvement to wording improve the clarity of the description of bundle registration. Be more explicit about what is allowed, required, etc improve the documentation about various options for resource registry records, include cross-links for better clarity provide more numerous examples of different forms of resource records. Include more textual explanation of the important attributes of each example add a note about the difference between values for the js option and those for the css option minor grammatical fixes minor improvements to docs regarding resources begin re-organizing bundle section of the documentation. Make formatting and language around defining and configuring bundles consistent with the language used for resources. Make section sub-headings more consistent fix method signature to make it clear this is for resources, not bundles improve the section on compiling bundles, including specific instructions on making the compiling script available. Fix up the organization a bit to better match the resources section improve documentation of the new plone traversal namespace improve explanation of using your own build system for compiled bundle resources improve structure and English syntax of the description of the mismatched anonymous define() error fix errors and omissions noted by @seanupton improvement to naming. The 'static' part should not be included in the title, as it is specific to Plone's own registration of a folder for that namespace. Update the section on Diazo Theme Bundles Provide improved Bundle registration examples (more are needed) Improve documentation of the resource request APIs Fix up the build to migrating older code, including links to more complete documentation of module definition patterns. Improve the syntax of the English in the section on including non-RequireJS resources in Diazo themes. add a few more example bundles thanks to @ebrehault. Also improve the descriptions of each to point out some differences in usage and the reasons for them fix typo, thx @svx fix external linking style according to styleguide. Thx @svx for the pointer. improve the link text a bit for this link in accordance with @svx's wishes. follow the lead of @svx in #522 and spell it 'Javascript' provide an example of registering a simple non-AMD javascript as a 'pre-compiled' bundle (thanks @ebrehault) Revert "follow the lead of @svx in #522 and spell it 'Javascript'" I misread the title of that commit and did exactly the wrong thing. This reverts commit 09f9e58. fix wording for clarity, thx @jensens document the stub_js_resources option and mention it's use in the documentation for minimizing bundles. Replace the docs for adding your stuff to the plone bundle as that is not recommended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.