Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove router from aio app constructor. #313

Closed
wants to merge 1 commit into from
Closed

Conversation

jordic
Copy link
Contributor

@jordic jordic commented Jul 23, 2018

As I understood on the original aiohttp issue, seems that this could solve the problem.
But it's not so clear for me, as seems, like they delegates the router creation to the wrapped App.
What's your thought on it? @vangheem

@jordic jordic requested a review from vangheem July 23, 2018 09:09
@vangheem
Copy link
Member

This will prevent the warning; however, I don't think it will fix the problem. They are removing the router infrastructure.

@jordic
Copy link
Contributor Author

jordic commented Jul 23, 2018

That's something I also understood... but anyway seems wired to have a webframework without router infraestructure... :/

@bloodbare
Copy link
Member

I agree that the aproach would need to be router /* to guillotina router, still no need to merge until aiohttp 4

@bloodbare
Copy link
Member

Just to keep track a reference to aiohttp issue: aio-libs/aiohttp#2766

@vangheem
Copy link
Member

@bloodbare what do you think about merging this still so our logs get cleaned up on test runs?

@jordic thoughts?

@jordic
Copy link
Contributor Author

jordic commented Aug 29, 2018

will ask it on the aio gitter.

@vangheem
Copy link
Member

vangheem commented Nov 7, 2018

Closing ticket for now until we decide on a solution.

@vangheem vangheem closed this Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants