Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pat-modal or rename it #483

Closed
jcbrand opened this issue Apr 15, 2015 · 1 comment
Closed

Remove pat-modal or rename it #483

jcbrand opened this issue Apr 15, 2015 · 1 comment
Assignees
@jcbrand
Labels
99 tag: pattern:modal

Comments

@jcbrand
Copy link
Member

jcbrand commented Apr 15, 2015

Currently we have a pat-modal pattern in both Patterns core and Mockup.

We can't have two different patterns with the same name in the same website. Ideally we want to remove the modal pattern from Mockup, but in the meantime I propose we rename it to something else, to at least avoid this naming conflict.

This will gives us some breathing space until we can eventually replace it with the one from Patterns.

Can I rename it to pat-mockup-modal, or pat-plone-modal?
@jcbrand jcbrand self-assigned this Apr 15, 2015
@vangheem
Copy link
Member

That's fine. Rename it to pat-plone-modal. There are a few places in Plone
core where it is used that will need to be updated.
On Apr 15, 2015 1:51 PM, "JC Brand" notifications@github.com wrote:

Currently we have a pat-modal pattern in both Patterns core and Mockup.

We can't have two different patterns with the same name in the same
website. Ideally we want to remove the modal pattern from Mockup, but in
the meantime I propose we rename it to something else, to at least avoid
this naming conflict.

This will gives us some breathing space until we can eventually replace it
with the one from Patterns.

Can I rename it to pat-mockup-modal, or pat-plone-modal?

—
Reply to this email directly or view it on GitHub
#483.

jcbrand added a commit that referenced this issue Apr 17, 2015
@jcbrand
Rename pat-modal to pat-plone-modal. updates #483
30c30e3 
This is to avoid a naming clash with pat-modal implemented in Patternslib.
jcbrand added a commit to plone/plone.app.dexterity that referenced this issue Apr 17, 2015
@jcbrand
Rename pat-modal to pat-plone-modal. updates plone/mockup#483
dbfcd58
jcbrand added a commit to plone/plone.app.layout that referenced this issue Apr 17, 2015
@jcbrand
Rename pat-modal to pat-plone-modal. updates plone/mockup#483
f978146
jcbrand added a commit to plone/plone.app.portlets that referenced this issue Apr 17, 2015
@jcbrand
Rename pat-modal to pat-plone-modal. updates plone/mockup#483
7e5fea8
jcbrand added a commit to plone/plone.app.theming that referenced this issue Apr 17, 2015
@jcbrand
Rename pat-modal to pat-plone-modal. updates plone/mockup#483
90ca716
jcbrand added a commit to plone/plone.schemaeditor that referenced this issue Apr 17, 2015
@jcbrand
Rename pat-modal to pat-plone-modal. updates plone/mockup#483
2f96e1c
This was referenced Apr 17, 2015
Merged
Merged
Merged
Closed
Merged
jcbrand added a commit to plone/Products.CMFPlone that referenced this issue Apr 18, 2015
@jcbrand
Rename modal key to plone-modal in registry.
2d83af0 
For context, see: plone/mockup#483
jcbrand added a commit to plone/Products.CMFPlone that referenced this issue Apr 21, 2015
@jcbrand
Add compiled files (pat-modal was renamed to pat-plone-modal)
ba6c7ee 
For context see:

* plone/mockup#485
* plone/mockup#483
vangheem added a commit to plone/buildout.coredev that referenced this issue Apr 22, 2015
@vangheem
[fc] Repository: plone.app.dexterity
82e2cdc 
Branch: refs/heads/master
Date: 2015-04-17T18:14:00+02:00
Author: JC Brand (jcbrand) <jc@opkode.com>
Commit: plone/plone.app.dexterity@dbfcd58

Rename pat-modal to pat-plone-modal. updates plone/mockup#483

Files changed:
M plone/app/dexterity/browser/types_listing.pt
Repository: plone.app.dexterity
Branch: refs/heads/master
Date: 2015-04-18T19:24:55+02:00
Author: JC Brand (jcbrand) <jc@opkode.com>
Commit: plone/plone.app.dexterity@74b7811

Add changelog entry

Files changed:
M CHANGES.rst
Repository: plone.app.dexterity
Branch: refs/heads/master
Date: 2015-04-22T15:01:30-05:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.dexterity@2d064cb

Merge pull request #154 from plone/pat-modal-rename

Rename pat-modal to pat-plone-modal.

Files changed:
M CHANGES.rst
M plone/app/dexterity/browser/types_listing.pt
vangheem added a commit to plone/buildout.coredev that referenced this issue Apr 22, 2015
@vangheem
[fc] Repository: plone.app.layout
a4a9902 
Branch: refs/heads/master
Date: 2015-04-17T18:14:43+02:00
Author: JC Brand (jcbrand) <jc@opkode.com>
Commit: plone/plone.app.layout@f978146

Rename pat-modal to pat-plone-modal. updates plone/mockup#483

Files changed:
M plone/app/layout/viewlets/common.py
M plone/app/layout/viewlets/document_byline.pt
Repository: plone.app.layout
Branch: refs/heads/master
Date: 2015-04-18T19:29:43+02:00
Author: JC Brand (jcbrand) <jc@opkode.com>
Commit: plone/plone.app.layout@cca61ab

Add changelog entry

Files changed:
M CHANGES.rst
Repository: plone.app.layout
Branch: refs/heads/master
Date: 2015-04-22T15:01:36-05:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.layout@c9c1eb5

Merge pull request #42 from plone/pat-modal-rename

Rename pat-modal to pat-plone-modal.

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/common.py
M plone/app/layout/viewlets/document_byline.pt
vangheem added a commit to plone/buildout.coredev that referenced this issue Apr 22, 2015
@vangheem
[fc] Repository: plone.app.portlets
f955e05 
Branch: refs/heads/master
Date: 2015-04-17T18:15:06+02:00
Author: JC Brand (jcbrand) <jc@opkode.com>
Commit: plone/plone.app.portlets@7e5fea8

Rename pat-modal to pat-plone-modal. updates plone/mockup#483

Files changed:
M plone/app/portlets/portlets/actions.pt
Repository: plone.app.portlets
Branch: refs/heads/master
Date: 2015-04-18T19:30:12+02:00
Author: JC Brand (jcbrand) <jc@opkode.com>
Commit: plone/plone.app.portlets@ef5620e

Add changelog entry

Files changed:
M CHANGES.rst
Repository: plone.app.portlets
Branch: refs/heads/master
Date: 2015-04-22T15:01:39-05:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.app.portlets@0fd64f5

Merge pull request #48 from plone/pat-modal-rename

Rename pat-modal to pat-plone-modal.

Files changed:
M CHANGES.rst
M plone/app/portlets/portlets/actions.pt
vangheem added a commit to plone/buildout.coredev that referenced this issue Apr 22, 2015
@vangheem
[fc] Repository: plone.schemaeditor
1d91bc5 
Branch: refs/heads/master
Date: 2015-04-17T18:16:07+02:00
Author: JC Brand (jcbrand) <jc@opkode.com>
Commit: plone/plone.schemaeditor@2f96e1c

Rename pat-modal to pat-plone-modal. updates plone/mockup#483

Files changed:
M plone/schemaeditor/browser/schema/schema_listing.pt
M plone/schemaeditor/tests/robot/test_fields.robot
Repository: plone.schemaeditor
Branch: refs/heads/master
Date: 2015-04-18T19:31:45+02:00
Author: JC Brand (jcbrand) <jc@opkode.com>
Commit: plone/plone.schemaeditor@d63124b

Add changelog entry

Files changed:
M CHANGES.rst
Repository: plone.schemaeditor
Branch: refs/heads/master
Date: 2015-04-22T15:01:42-05:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/plone.schemaeditor@093e218

Merge pull request #23 from plone/pat-modal-rename

Rename pat-modal to pat-plone-modal.

Files changed:
M CHANGES.rst
M plone/schemaeditor/browser/schema/schema_listing.pt
M plone/schemaeditor/tests/robot/test_fields.robot
jcbrand added a commit that referenced this issue Jul 3, 2015
@jcbrand @fulv
Rename pat-modal to pat-plone-modal. updates #483
ee60684 
This is to avoid a naming clash with pat-modal implemented in Patternslib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcbrand jcbrand

Labels
99 tag: pattern:modal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vangheem @jcbrand