Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include column sorting for the structure pattern #848

Closed
frapell opened this issue May 25, 2018 · 4 comments
Closed

Include column sorting for the structure pattern #848

frapell opened this issue May 25, 2018 · 4 comments

Comments

@frapell
Copy link
Member

frapell commented May 25, 2018

We used to have this feature in Plone, where you could sort the elements inside the table for the folder_contents view, without affecting the actual order of items inside the folder.

You can rearrange items in the folder_contents, but that affects the actual order of items.

I am thinking on integrating a solution in order to provide this feature back, and I came across 2 alternatives:

https://datatables.net/ and http://issues.wenzhixin.net.cn/bootstrap-table/

I already integrated datatables in a project, so I know it works well with Mockup, but I don't know if it is something that it would be accepted to be included with the project.

What do you guys think?

@frapell
Copy link
Member Author

frapell commented May 25, 2018

@vangheem @thet What do you guys think?

@thet
Copy link
Member

thet commented May 25, 2018

Sounds good to me + I'm not against it.

AFAIK Datatables brings a lot of table rendering functionality including search, which would make parts of structure patterns code obsolete. I'm not sure if it's easy to integrate.

Before it's going to be a major rewrite I'd put efforts to a React based rewrite of the structure pattern (plone-react). My plan is to look into a React option at the Buschenschanksprint ( https://community.plone.org/t/buschenschanksprint-2018-11-6-15-6-2018/6154 ) including an alternative to the Related Items Widget (a frequent source of complaints from my customers).

/cc @tisto any opinions?

@frapell
Copy link
Member Author

frapell commented May 25, 2018

@thet Sweet, although we have a customer in need for this feature, so we kind of need something working soon, and I was going to be doing it with Datatables...

Hopefully I can merge this enhancement until a replacement in react is ready?

@thet
Copy link
Member

thet commented May 25, 2018

Absolutely. Go for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants