Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade #1334

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Upgrade #1334

merged 3 commits into from
Jul 30, 2023

Conversation

thet
Copy link
Member

@thet thet commented Jul 28, 2023

No description provided.

@thet thet requested a review from petschki July 28, 2023 00:18
package.json Show resolved Hide resolved
"@types/sinon": "^10.0.14",
"npm-run-all": "^4.1.5",
"rimraf": "^4.1.3",
"sinon": "^15.0.4"
"sinon": "^15.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turned out, that this sinon version has to be in transformIgnorePattern in jest config. Now tests are green again.

@petschki petschki self-requested a review July 30, 2023 19:55
@petschki petschki merged commit 0e95a29 into master Jul 30, 2023
2 checks passed
@petschki petschki deleted the upgrade branch July 30, 2023 19:55
@thet
Copy link
Member Author

thet commented Jul 31, 2023

🎉

super!
I had a ton of breaking tests in mockup, glad that these were false flags...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants