-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/help plugin #1376
Feature/help plugin #1376
Conversation
.husky/commit-msg
Outdated
@@ -1,4 +1,4 @@ | |||
#!/bin/sh | |||
. "$(dirname "$0")/_/husky.sh" | |||
|
|||
yarn commitlint --edit | |||
# yarn commitlint --edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's probably a leftover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm... nothing I recall to have changed. Will restore and commit original state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed commented line and a couple of errors.
.husky/commit-msg
Outdated
@@ -1,4 +1,4 @@ | |||
#!/bin/sh | |||
. "$(dirname "$0")/_/husky.sh" | |||
|
|||
yarn commitlint --edit | |||
# yarn commitlint --edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm... nothing I recall to have changed. Will restore and commit original state
Just wondering why this is needed at all, because the help plugin is shipped with the tinymce package ... if the plugin is activated in the controlpanel (which got added in |
@rber474 I'll close this one. If you have any further problems with the help plugin please open a new PR. |
After issue plone/plone.base#41, a PR was requested in order to make
help
plugin available throught TinyMCE controlpanel.Checking this plugin option in would display a toolbar or menu options to show the help view in the editor but an exception was rised because of it could find the resources for navkey translation pages.
This aproach fixes that issue and refactors the code. Now help is displayed and translations are properly shown.
help.js
intinymce-implementation.js
I am not sure if this is the best way to solve the behaviour but I've implemented it in a production site and fits our needs.
Please, review it. Any comments are welcome.
@rber474