Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinymce: Do not include content.min.css as part of the bundle #854

Merged
merged 2 commits into from
Jun 29, 2018

Conversation

frapell
Copy link
Member

@frapell frapell commented Jun 19, 2018

This PR fixes gh-838

@petschki
Copy link
Member

@frapell maybe this can be merged with the test-fixes from PR #853

due to a issue in country specific language handling introduced in #849
@petschki
Copy link
Member

petschki commented Jun 28, 2018

@frapell travis is green. pull-request-5.2 breaks due to a plone.restapi issue which doesn't belongs to us plone/plone.restapi#552 ... can we merge?

@lyralemos lyralemos mentioned this pull request Jun 28, 2018
@frapell
Copy link
Member Author

frapell commented Jun 29, 2018

I would say so... @jensens or @thet ?

@jensens
Copy link
Member

jensens commented Jun 29, 2018

Yeah, merge!

@frapell frapell merged commit 2c92b54 into master Jun 29, 2018
@frapell frapell deleted the issue-838 branch June 29, 2018 18:07
@petschki
Copy link
Member

@frapell who recompiles the resources to the 5.x branches? regarding fixing plone/Products.CMFPlone#2430

@frapell
Copy link
Member Author

frapell commented Jun 29, 2018

@petschki I was going to do it sometime over the weekend... but if you have the time and want to do it, go ahead :)

@petschki
Copy link
Member

petschki commented Jul 2, 2018

@frapell uh ... if you give me some advice how to do this I'll do my best. I know how to build the bundles, but where to copy theese resources over? is there some developer documentation on this? thx.

@frapell
Copy link
Member Author

frapell commented Jul 2, 2018

@petschki Yeah, documentation for this is a bit hidden... You can find it here https://github.com/plone/Products.CMFPlone/blob/master/DEVELOPING_BUNDLES.rst

I was not able to do it myself over the weekend, however if you wait for me to wrap #850 (I hope to be able to put some time into it this week), I can include both changes... Or if you want to give it a try, go ahead :)

@petschki
Copy link
Member

petschki commented Jul 2, 2018

thanks for the docs ... for now I'm fine with waiting 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TinyMCE's content.min.css included in bundle css
3 participants