Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix statusmessage and form validation selectors for Barceloneta LTS #976

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

petschki
Copy link
Member

No description provided.

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

petschki added a commit to plone/plone.staticresources that referenced this pull request May 13, 2020
@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@fredvd
Copy link
Member

fredvd commented May 20, 2020

Are these fixes compatible with Plone 5.2 ? Otherwise maybe a 3.X branch for mockup should be created for Plone 5.2 support and mockup master can be used for Plone 6.

@petschki
Copy link
Member Author

Changes are all backwards compatible. This is a bugfix for #975

@thet thet merged commit 788e1a2 into master Jun 16, 2020
@thet thet deleted the barceloneta-lts-fix branch June 16, 2020 07:25
thet pushed a commit to plone/plone.staticresources that referenced this pull request Jun 16, 2020
…eta LTS (#77)

* fix statusmessage and form validation error selector to work with barceloneta LTS

See plone/mockup#976

* revert wrong optimization
mister-roboto pushed a commit to plone/buildout.coredev that referenced this pull request Jun 16, 2020
Branch: refs/heads/master
Date: 2020-06-16T09:32:32+02:00
Author: Peter Mathis (petschki) <petschki@users.noreply.github.com>
Commit: plone/plone.staticresources@85384f5

fix statusmessage and form validation selectors to work with barceloneta LTS (#77)

* fix statusmessage and form validation error selector to work with barceloneta LTS

See plone/mockup#976

* revert wrong optimization

Files changed:
M news/76.feature
M src/plone/staticresources/profiles/default/registry/bundles.xml
M src/plone/staticresources/static/plone-compiled.css.map
M src/plone/staticresources/static/plone-compiled.js
M src/plone/staticresources/static/plone-compiled.min.js
M src/plone/staticresources/static/plone-compiled.min.js.map
M src/plone/staticresources/upgrades/configure.zcml
erral pushed a commit that referenced this pull request Jul 3, 2020
…976)

* fix statusmessage and form validation error selectors for Barceloneta LTS

* revert wrong optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants