Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test of Preview Build #7

Merged
merged 27 commits into from
May 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
e5d06ee
Test Cloudflare Preview from a pull request
stevepiercy May 9, 2024
6180435
Test Cloudflare Preview from a pull request
stevepiercy May 9, 2024
1727cad
Try GitHub Pages Preview Action
stevepiercy May 9, 2024
ccad6c1
Remove editable install, shorten umbrella-dir
stevepiercy May 9, 2024
8384d05
Try again
stevepiercy May 9, 2024
b034cfb
Try again
stevepiercy May 9, 2024
b083b90
Just run make, no pip
stevepiercy May 9, 2024
eafdcbd
Attempt to resolve `Error: Resource not accessible by integration`
stevepiercy May 9, 2024
a6cbca1
Abort attempt
stevepiercy May 9, 2024
8de26c6
Remove make target for PR previews
stevepiercy May 9, 2024
d136651
Try CF again with wrangler.toml
stevepiercy May 9, 2024
22ca625
Change output dir
stevepiercy May 9, 2024
7105271
Change output dir
stevepiercy May 9, 2024
8f17917
Add link to GitHub Pages
stevepiercy May 9, 2024
645d35e
Try build command in wrangler.toml
stevepiercy May 9, 2024
b0842d6
Revert
stevepiercy May 9, 2024
25677c0
Remove wrangler.html
stevepiercy May 9, 2024
9d13089
Try basic RTD setup
stevepiercy May 10, 2024
a01e907
Add rtd-pr-preview.yml
stevepiercy May 10, 2024
86d6cb8
set argument single-version
stevepiercy May 10, 2024
0991520
poke
stevepiercy May 10, 2024
de82810
Change commands to install only the project and its requirements, and…
stevepiercy May 10, 2024
40ac30d
derp
stevepiercy May 10, 2024
5d61f56
Use correct target
stevepiercy May 10, 2024
f057b50
Revert configuration from other GHA pr-preview
stevepiercy May 10, 2024
b97b0ae
Tidy
stevepiercy May 10, 2024
34b5593
Revert to support Python 3.9
stevepiercy May 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/rtd-pr-preview.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# .github/workflows/rtd-pr-preview.yml
name: readthedocs/actions
on:
pull_request_target:
types:
- opened
# Execute this action only on PRs that touch
# documentation files.
# paths:
# - "docs/**"

permissions:
pull-requests: write

jobs:
documentation-links:
runs-on: ubuntu-latest
steps:
- uses: readthedocs/actions/preview@v1
with:
project-slug: "plone-sphinx-theme"
single-version: "true"
24 changes: 24 additions & 0 deletions .readthedocs.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# .readthedocs.yaml
# Read the Docs configuration file
# See https://docs.readthedocs.io/en/stable/config-file/v2.html for details

# Required
version: 2

# Set the OS, Python version and other tools you might need
build:
os: ubuntu-22.04
tools:
python: "3.12"
# nodejs: "19"
commands:
- make rtd-pr-preview

# Build documentation in the "docs/" directory with Sphinx
#sphinx:
# configuration: docs/conf.py

# See https://docs.readthedocs.io/en/stable/guides/reproducible-builds.html
#python:
# install:
# - requirements: docs/requirements.txt
8 changes: 3 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -212,11 +212,9 @@ sbt-styles-update: ## Copy Sphinx Book Theme styles to Plone Sphinx Theme
kitchen-sink-update: ## Copy Kitchen Sink documentation files to Plone Sphinx Theme
bin/python scripts/kitchen_sink_update.py

.PHONY: netlify
netlify:
pip install -r requirements-netlify.txt
pip install .
cd $(DOCS_DIR) && sphinx-build -b html $(ALLSPHINXOPTS) $(BUILDDIR)/html && cp ./netlify_robots.txt $(BUILDDIR)/html/robots.txt
.PHONY: rtd-pr-preview
rtd-pr-preview: bin/python ## Build pull request preview on Read the Docs
cd $(DOCS_DIR) && $(SPHINXBUILD) -b html $(ALLSPHINXOPTS) ${READTHEDOCS_OUTPUT}/html/

.PHONY: all
all: clean vale linkcheck html ## Clean docs build, then run vale and linkcheck, and build html
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ It is based on [`sphinx-book-theme`](https://sphinx-book-theme.readthedocs.io/en

## Documentation and demonstration

Documentation is hosted on GitHub at a temporary URL:

https://plone.github.io/plone-sphinx-theme/

TODO:

To build documentation and a demonstration of this project, you can use `make` commands.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"extract-loader": "^4.0.3",
"file-loader": "^5.0.2",
"html-webpack-plugin": "^4.3.0",
"sass": "^1.75.0",
"optimize-css-assets-webpack-plugin": "^5.0.3",
"sass": "^1.75.0",
"sass-loader": "^10.1.1",
"style-loader": "^1.1.3",
"webpack": "^4.41.6",
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ classifiers = [
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Expand Down