Use Read the Docs for pull request previews #545
Conversation
|
@stevepiercy thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@stevepiercy thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
w00t! Success! https://ploneapi--545.org.readthedocs.build/ Who else should I add to the Read the Docs plone.api project as an Admin? I should not be the only person. |
|
@stevepiercy You can add me, and I'd suggest @ericof as well. |
|
Ack! It wasn't ready! Sorry, I should have set this to draft. |
|
@stevepiercy Sorry...but what wasn't ready? I saw your link in #545 (comment) and took that as an indication that it was working. |
|
I have to remove some noise and Netlify. |
|
Also I wanted to come up with a more elegant tox environment, other than copy-paste and tweak, to make it more maintainable. |
Invitations sent. Follow up PR incoming, but I decided to expand the scope of docs improvements. |
- Sort and remove duplicate entries in `pyproject.toml` - Remove unused docs requirements. - Fix comments and remove unnecessary steps from `tox.ini`. - Enable copy button for code blocks. - Add linkcheck to documentation of documentation.
Remove Netlify stuff, follow up to #545
This pull request replaces the Netlify pull request preview build which supports only Python 3.8.