Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix api.content.get when a item in the path is not acccessible #550

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Fix api.content.get when a item in the path is not acccessible #550

merged 2 commits into from
Dec 21, 2024

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Dec 20, 2024 •
edited by github-actions bot
Loading

Fixes #549

📚 Documentation preview 📚: https://ploneapi--550.org.readthedocs.build/

@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@pbauer pbauer requested a review from davisagli December 20, 2024 05:49
@pbauer pbauer force-pushed the fix_getting_content_in_inaccessible_containers branch from 5c732ea to 0da4d70 Compare December 20, 2024 05:52
@pbauer
Copy link
Member Author

pbauer commented Dec 20, 2024

@jenkins-plone-org please run jobs

@pbauer pbauer requested a review from ale-rt December 20, 2024 05:54
ale-rt
ale-rt approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be sure we do not have regression a test would be nice, but this looks good

@pbauer
Copy link
Member Author

pbauer commented Dec 20, 2024

@jenkins-plone-org please run jobs

@pbauer pbauer closed this Dec 20, 2024
@pbauer pbauer reopened this Dec 20, 2024
@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@pbauer
Copy link
Member Author

pbauer commented Dec 20, 2024

@jenkins-plone-org please run jobs

@pbauer pbauer merged commit ef01287 into main Dec 21, 2024
25 of 28 checks passed
@pbauer pbauer deleted the fix_getting_content_in_inaccessible_containers branch December 21, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ale-rt ale-rt ale-rt approved these changes

@davisagli davisagli Awaiting requested review from davisagli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api.content.get no longer returns content that is inside a inaccessible container
3 participants
@pbauer @mister-roboto @ale-rt