Skip to content

Commit

Permalink
Show status after synchronous purge if it is an error status.
Browse files Browse the repository at this point in the history
I had a misconfiguration, where all purge requests were denied by
varnish because my ip address was not in the allowed list.  This gave
a status 504 on all purge requests, but this was nowhere visible.  The
controlpanel only showed 'The following items were purged:' with the
list I expected, no errors.
  • Loading branch information
mauritsvanrees committed Mar 3, 2016
1 parent fb756f6 commit 2cac516
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
9 changes: 8 additions & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,14 @@ Changelog
1.1.11 (unreleased)
~~~~~~~~~~~~~~~~~~~

- Nothing changed yet.
New:

- Show status after synchronous purge if it is an error status.
[maurits]

Fixes:

- *add item here*


1.1.10 (2015-06-09)
Expand Down
2 changes: 2 additions & 0 deletions plone/app/caching/browser/controlpanel.py
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,8 @@ def purge(url):
log += " (X-Cache header: " + xcache + ")"
if xerror:
log += " -- " + xerror
if not str(status).startswith('2'):
log += " -- WARNING status " + str(status)
self.purgeLog.append(log)
else:
purger.purgeAsync(url)
Expand Down

0 comments on commit 2cac516

Please sign in to comment.