make thumb size in folder contents listing adjustable/supressable #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgrcon
force-pushed
the
plip1734thumbs
branch
from
d286787 to
088d083
Compare
16 tasks
fgrcon
force-pushed
the
plip1734thumbs
branch
from
f586f8e to
0d6f73f
Compare
fgrcon
force-pushed
the
plip1734thumbs
branch
from
0d6f73f to
7269285
Compare
fgrcon
force-pushed
the
plip1734thumbs
branch
2 times, most recently
from
ad3a0f0 to
75d8703
Compare
jensens
reviewed
Apr 9, 2017
| else: | ||
| item[key] = val | ||
| if key == 'getMimeIcon': | ||
| item[key] = None | ||
| if vocab_item.portal_type =='File': |
There was a problem hiding this comment.
I don't like it is bound to type File only.
jensens
reviewed
Apr 9, 2017
| item[key] = None | ||
| if vocab_item.portal_type =='File': | ||
| #get mime type icon url from mimetype registry' | ||
| portal_url = api.portal.get().absolute_url() |
There was a problem hiding this comment.
use plone.api.portal.get_navigation_root instead
There was a problem hiding this comment.
No plone.api should be used actually...
There was a problem hiding this comment.
ok removed api and use naroot
jensens
reviewed
Apr 9, 2017
| portal_url = api.portal.get().absolute_url() | ||
| mtt = api.portal.get_tool( | ||
| name='mimetypes_registry') | ||
| if vocab_item.getObject().file.contentType: |
There was a problem hiding this comment.
we really need the mimetype as catalog metadata.
There was a problem hiding this comment.
thats why i proposed plone/Products.CMFPlone#1995. I suggest to merge 1995 first. (upgrade changes are interdependent)
gforcada
reviewed
Apr 12, 2017
| @@ -168,6 +170,7 @@ def ignored_columns(self): | |||
| 'effective', | |||
| 'expires', | |||
| 'getIcon', | |||
| 'getMimeIcon', | |||
gforcada
reviewed
Apr 12, 2017
| item[key] = os.path.join( | ||
| portal_url, | ||
| guess_icon_path(ctype[0])) | ||
| except: |
(uses site control panel settings: thumb_size_tables ...) clean up deprecated icon related code replace paperclip icon with mime type icons plone/Products.CMFPlone#1734
ebrehault
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(uses site control panel settings: thumb_size_tables ...)
plone/Products.CMFPlone#1734