Merge pull request #29 from plone/fix-toolbar-state

fix state icon position in toolbar when no permission
plone · Jul 9, 2020 · b786ef8 · b786ef8
2 parents e9be42f + b56dc02
commit b786ef8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/news/29.bugfix b/news/29.bugfix
@@ -0,0 +1,3 @@
+Fix review state icon position in toolbar when the user doesn't have the permission to change the review state.
+This fixes https://github.com/plone/plonetheme.barceloneta/issues/110
+[vincentfretin]
diff --git a/plone/app/contentmenu/contentmenu.pt b/plone/app/contentmenu/contentmenu.pt
@@ -10,12 +10,13 @@
       <a
           href="#"
           i18n:attributes="title;"
-          tal:attributes="href menuItem/action;
+          tal:attributes="href python:menuItem['action'] or 'javascript:void(0)';
+                          style python:not menuItem['action'] and 'cursor: default;; pointer-events: none' or None;
                           title menuItem/description;
                           class string:label-${state_class}"
           tal:define="state_class menuItem/extra/class | nothing;
                       state_class python:state_class and state_class or ''"
-          tal:omit-tag="not:menuItem/action">
+          >
         <span
             aria-hidden="true"
             class=""