Fix a write on read situation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd add a short comment why its twice inside the block to the code. |
|
and changelog entry is missing |
Only get the rule management assignable if it's going to be used. Getting it has the side effect of creating it if it does not exist, thus causing a write on read.
gforcada
force-pushed
the
write-on-read
branch
from
e9d8abd to
ec3bedc
Compare
|
@jensens change log entry added. From the last commits seems that this can only be applied on plone 5, it will be needed to be backported at 4.3 (will do afterwards). |
|
Jenkins is green :-) so ready to be merged |
jensens
added a commit
to plone/buildout.coredev
that referenced
this pull request
Oct 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the assignable where is actually needed, thus preventing a write on read.
Note that there is a possible vector for a write on read, see
assigned_rulesmethod, where it needs the assignable, but if that is not found it causes a write on read.This last issue is fixed with plone/plone.contentrules#2