Fix a write on read situation (Plone 4.3) #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only get the rule management assignable if it's going to be used. Getting it has the side effect of creating it if it does not exist, thus causing a write on read.
gforcada
changed the title
|
Yet another pull request that needs to be merged together with plone/buildout.coredev#131 |
|
Sorry I was wrong on this one, there's no need to wait for adding plone.protect > 3.x on Plone 4.3 to merge this one. And jenkins said so: http://jenkins.plone.org/job/pull-request-4.3/140/ |
|
I have merged this manually. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only get the rule management assignable if it's going to be used.
Getting it has the side effect of creating it if it does not exist,
thus causing a write on read.