Plone base overhaul #71
Conversation
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
| elif IFileContent is None: | ||
| return False | ||
| elif not IFileContent.providedBy(obj): | ||
| return False | ||
| else: |
There was a problem hiding this comment.
This else was only executed if IFileContent.providedBy(obj). This can no longer be true, so this code branch can be removed.
There was a problem hiding this comment.
Hmm, no, its now executed if not IFile.providedBy(obj)
isort/black/pyupgrade
plone base usage
get rid of six and archetypes