Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dx container site root #475

Merged
merged 31 commits into from
Sep 11, 2021
Merged

Dx container site root #475

merged 31 commits into from
Sep 11, 2021

Conversation

jaroel
Copy link
Member

@jaroel jaroel commented Jun 22, 2018 •
edited
Loading

No description provided.

@jaroel jaroel changed the title WIP Dxcontainer siteroot Dxc ontainer site root Jun 23, 2018
@jaroel jaroel changed the title Dxc ontainer site root Dx container site root Jun 23, 2018
@jaroel jaroel mentioned this pull request Jun 25, 2018
Closed
@jaroel jaroel force-pushed the dxcontainer-siteroot branch from 512acec to 66339cb Compare July 30, 2018 19:58
jaroel and others added 23 commits July 31, 2018 22:51
@jaroel
Remove old tests + update changelog
7349f54
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
099de5f
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
566286f
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
4b34c98
@jaroel
strip whitespace in robot test and stick value
fed9890
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
bfbbf52
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
455975d
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
1ccce19
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
5135194
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
cc29391
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
41206f9
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
ea6af80
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
1940d02
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
e78bc9d
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
cdd5fa0
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
dd225e6
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
1ae3523
@jaroel
Fix robot tests.
942c48c
@jaroel
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
8bfa7d9
@ale-rt
Try to not change an already configured site
c4d837d
@ale-rt
Merge remote-tracking branch 'origin/master' into dxcontainer-siteroot
6707890
@ale-rt
Modify the plone site when there is no text
c4cac77
@ale-rt
Restore some tests
6fcbf96
mauritsvanrees
mauritsvanrees approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this and a few other PRs, but framework team has final say. I am just one person.

@ale-rt
Copy link
Member

ale-rt commented Sep 7, 2021

I started the jenkin jobs using the following parameters:

https://github.com/plone/Products.CMFPlone/pull/2612
https://github.com/plone/plone.app.contenttypes/pull/475
https://github.com/plone/plone.app.upgrade/pull/256

@mauritsvanrees mauritsvanrees merged commit 324e699 into master Sep 11, 2021
@jensens jensens deleted the dxcontainer-siteroot branch April 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisto tisto tisto approved these changes

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

Assignees
No one assigned
Labels
03 type: feature (plip) 22 status: in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaroel @ale-rt @mauritsvanrees @tisto @jensens