Skip to content

Commit

Permalink
fix doctests for py2
Browse files Browse the repository at this point in the history
  • Loading branch information
@pbauer
pbauer committed Jun 13, 2018
1 parent ff054dd commit 0cba5c5
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions plone/app/customerize/tests/testDocTests.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ class Py23DocChecker(doctest.OutputChecker):
def check_output(self, want, got, optionflags):
if six.PY2:
got = re.sub('zExceptions.NotFound', 'NotFound', got)
else:
want = re.sub("u'(.*?)'", "'\\1'", want)
got = re.sub("u'(.*?)'", "'\\1'", want)
return doctest.OutputChecker.check_output(self, want, got, optionflags)


Expand Down

1 comment on commit 0cba5c5

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbauer Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.app.customerize/20/violations

plone/app/customerize/tool.py:31:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/customerize/registration.py:16:1: I001 isort found an import in the wrong position
plone/app/customerize/registration.py:49:15: P002 found "hasattr", consider replacing it
plone/app/customerize/registration.py:51:11: T000 Todo note found.
plone/app/customerize/registration.py:74:15: T000 Todo note found.
plone/app/customerize/registration.py:112:35: C812 missing trailing comma
plone/app/customerize/registration.py:135:31: C812 missing trailing comma
plone/app/customerize/registration.py:155:7: T000 Todo note found.
plone/app/customerize/testing.py:13:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/testing.py:16:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/testing.py:19:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/customerize/tests/testDocTests.py:31:63: C812 missing trailing comma
plone/app/customerize/tests/testDocTests.py:32:14: C812 missing trailing comma

Follow these instructions to reproduce it locally.

Please sign in to comment.