Plone base overhaul

[jensens]

• isort, black, pyupgrade
• remove six and some bbb
• use plone.base and move annotation key over to here

[mister-roboto]

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[jensens]

@jenkins-plone-org please run jobs

[ksuess]

LGTM. Just two docs that still have explicit unicode strings.

[jensens]

LGTM. Just two docs that still have explicit unicode strings.

Can you give me a hint where? pyupgrade only covers code, so that is probably why.

[petschki]

LGTM

[mauritsvanrees]

LGTM. Just two docs that still have explicit unicode strings.

Can you give me a hint where? pyupgrade only covers code, so that is probably why.

git grep -w u finds them. I have fixed them and pushed a commit.

[ksuess]

LGTM. Just two docs that still have explicit unicode strings.

Can you give me a hint where? pyupgrade only covers code, so that is probably why.

docs:

plone.app.discussion/docs/source/howtos/howto_make_pad_work_with_a_dexterity_content_type.txt

Lines 20 to 28 in bcb9315

	Define an interface IMyDexterityContentType groked schema, I added::
	allowDiscussion = schema.Bool(
	title=_(u"Allow Users to Comment"),
	description=_(u"Allow users to commemt on you. Comments
	are shown at the end of each page"),
	required=True,
	default=True,
	)

plone.app.discussion/docs/source/howtos/howto_extend_the_comment_form.txt

Lines 59 to 67 in bcb9315

	# Interface to define the fields we want to add to the comment form.
	class ICommentExtenderFields(Interface):
	website = schema.TextLine(title=u"Website", required=False)
	# Persistent class that implements the ICommentExtenderFields interface
	@adapter(Comment)
	class CommentExtenderFields(Persistent):
	interface.implements(ICommentExtenderFields)
	website = u""

[jensens]

@jenkins-plone-org please run jobs